Skip to content

[vcpkg-cmake] get more logs#38409

Merged
BillyONeal merged 8 commits intomicrosoft:masterfrom
Neumann-A:copy_configure_tests
Jun 14, 2024
Merged

[vcpkg-cmake] get more logs#38409
BillyONeal merged 8 commits intomicrosoft:masterfrom
Neumann-A:copy_configure_tests

Conversation

@Neumann-A
Copy link
Copy Markdown
Contributor

@Neumann-A Neumann-A commented Apr 25, 2024

No description provided.

dg0yt
dg0yt suggested changes Apr 25, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMakeConfigureLog.yaml is great.

Note that another change to this port is pending in #38249.

@dg0yt
Copy link
Copy Markdown
Contributor

dg0yt commented Apr 25, 2024

And IIUC all these logs become part of the GH issues.

Neumann-A and others added 2 commits April 25, 2024 08:04
@Neumann-A @dg0yt
Update ports/vcpkg-cmake/vcpkg_cmake_configure.cmake
027f2d3 
Co-authored-by: Kai Pastor <dg0yt@darc.de>
@Neumann-A
v db
27a8469
@FrankXie05 FrankXie05 added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Apr 25, 2024
@dg0yt
Copy link
Copy Markdown
Contributor

dg0yt commented Apr 25, 2024

meson and gn use ninja, too. At which point will "build with ninja" be generalized?

@Neumann-A
Copy link
Copy Markdown
Contributor Author

Neumann-A commented Apr 26, 2024 

REGRESSION: openmvs:x64-windows-static failed with BUILD_FAILED. If expected, add openmvs:x64-windows-static=fail to D:\a\_work\1\s\scripts\azure-pipelines/../ci.baseline.txt.
REGRESSION: rtabmap:x64-windows-static failed with BUILD_FAILED. If expected, add rtabmap:x64-windows-static=fail to D:\a\_work\1\s\scripts\azure-pipelines/../ci.baseline.txt.

are baseline due to the removal of CBLAS_LIBRARIES from the lapack-wrapper is fixed in the VTK PR

@Neumann-A Neumann-A mentioned this pull request Apr 29, 2024
Closed
7 tasks
@Neumann-A
Copy link
Copy Markdown
Contributor Author

Neumann-A commented Apr 30, 2024 •
edited
Loading

I wouldn't mind SAVE_LOG_FILES to be exposed to the caller somehow. Maybe some Z_VCPKG_ variable would make sense here? The main use is debugging especially for the build.ninja file.

(CMakeConfigureLog.yaml should always be parts of the logs)

Neumann-A added 2 commits May 27, 2024 16:42
@Neumann-A
Merge remote-tracking branch 'upstream/master' into copy_configure_tests
4c5c7e8 
# Conflicts:
#	ports/vcpkg-cmake/vcpkg.json
#	versions/baseline.json
#	versions/v-/vcpkg-cmake.json
@Neumann-A
v db
733c4c6
@Neumann-A Neumann-A marked this pull request as ready for review May 27, 2024 14:42
@BillyONeal BillyONeal added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jun 12, 2024
@BillyONeal BillyONeal merged commit 81bf2ee into microsoft:master Jun 14, 2024
@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Jun 14, 2024

Thanks for the logs!

@Neumann-A Neumann-A deleted the copy_configure_tests branch June 15, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@dg0yt dg0yt dg0yt requested changes

@FrankXie05 FrankXie05 FrankXie05 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@FrankXie05 FrankXie05

Labels

category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Neumann-A @dg0yt @BillyONeal @FrankXie05