Skip to content

Update Apache Arrow to 0.9 and add Apache Parquet-cpp 1.4#3839

Merged
alexkaratarakis merged 3 commits intomicrosoft:masterfrom
philjdf:master
Jul 13, 2018
Merged

Update Apache Arrow to 0.9 and add Apache Parquet-cpp 1.4#3839
alexkaratarakis merged 3 commits intomicrosoft:masterfrom
philjdf:master

Conversation

@philjdf
Copy link
Copy Markdown
Contributor

@philjdf philjdf commented Jul 3, 2018 •
edited
Loading

I wanted to build Parquet-cpp on Windows, so I made a port for it in Vcpkg. This also required updating the Arrow version. It all compiles for x64-windows-static and x64-windows, debug and release, but I haven't tried Linux.

I made a few changes to the original CMake code:

  • The original behaviour didn't find the right .lib in many instances. So I simplified the find_* calls and trusted the default paths Vcpkg defines.
  • The original FindGTest.cmake downloaded and compiled gtest if it couldn't find it, and had a different interface to the standard FindGTest.cmake. So I switched to the standard way to find/use gtest.
  • In Parquet, the transitive dependencies from Arrow are now handled without needing env variables.

I hope this is suitable for inclusion. Happy to make any changes or do my best with any questions!

@msftclas
Copy link
Copy Markdown

msftclas commented Jul 3, 2018 •
edited
Loading

CLA assistant check
All CLA requirements met.

@philjdf philjdf changed the title Update Apache Arrow to 0.6 and add Apache Parquet-cpp 1.4 Update Apache Arrow to 0.9 and add Apache Parquet-cpp 1.4 Jul 3, 2018
@philjdf philjdf mentioned this pull request Jul 10, 2018
Closed
@alexkaratarakis alexkaratarakis self-assigned this Jul 13, 2018
@alexkaratarakis alexkaratarakis merged commit 1014557 into microsoft:master Jul 13, 2018
@alexkaratarakis
Copy link
Copy Markdown
Contributor

alexkaratarakis commented Jul 13, 2018

Looks good! Thanks!

@jeanga
Copy link
Copy Markdown
Contributor

jeanga commented Jul 18, 2018

Hi,
Thank you for porting parquet-cpp on Windows 👍
Any reason why this port is x64 only and not x86?

Thanks!
Jean

@philjdf
Copy link
Copy Markdown
Contributor Author

philjdf commented Jul 18, 2018 •
edited
Loading

Hi,

Good question! This is inherited from the Arrow dependency, but why that is x64 only, I don't know!

Cheers, Phil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexkaratarakis alexkaratarakis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@philjdf @msftclas @alexkaratarakis @jeanga