[chakracore] Avoid using MSVC-internal _STRINGIZE#37242
Merged
vicroms merged 2 commits intomicrosoft:masterfrom Mar 8, 2024
Merged
[chakracore] Avoid using MSVC-internal _STRINGIZE#37242vicroms merged 2 commits intomicrosoft:masterfrom
vicroms merged 2 commits intomicrosoft:masterfrom
Conversation
Cheney-W
approved these changes
Mar 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft's C++ standard library recently merged microsoft/STL#4405 to remove the internal
_STRINGIZEmacro.chakracorewas using this MSVC internal macro, soavoid_msvc_internal_STRINGIZE.patchwas added to adapt it to the microsoft/STL changes. Reference: chakra-core/ChakraCore#6970.SHA512s are updated for each updated download.The "supports" clause reflects platforms that may be fixed by this new version.Any fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --alland committing the result.