Skip to content

[leveldb] Fix build on linux#3519

Merged
alexkaratarakis merged 2 commits intomicrosoft:masterfrom
HungMingWu:master
Jul 10, 2018
Merged

[leveldb] Fix build on linux#3519
alexkaratarakis merged 2 commits intomicrosoft:masterfrom
HungMingWu:master

Conversation

@HungMingWu
Copy link
Copy Markdown
Contributor

@HungMingWu HungMingWu commented May 17, 2018 •
edited
Loading

Fix build on linux

@alexkaratarakis alexkaratarakis self-assigned this May 17, 2018
@edmBernard edmBernard mentioned this pull request Jun 19, 2018
Closed
@edmBernard
Copy link
Copy Markdown
Contributor

edmBernard commented Jun 19, 2018 •
edited
Loading

@HungMingWu
you need to add C++11 option in compiler flag. Currently, there is an error with std::atomic.
you can add these two line at the beginning of the file :

set(CMAKE_CXX_STANDARD 11)
set(CMAKE_CXX_STANDARD_REQUIRED ON)

@HungMingWu
Copy link
Copy Markdown
Contributor Author

HungMingWu commented Jun 19, 2018

Fix it

@edmBernard
Copy link
Copy Markdown
Contributor

edmBernard commented Jun 19, 2018

For me it works perfect now

@HungMingWu
Copy link
Copy Markdown
Contributor Author

HungMingWu commented Jul 9, 2018

Is it need to merge iinto master?

@alexkaratarakis alexkaratarakis merged commit 91db517 into microsoft:master Jul 10, 2018
@alexkaratarakis
Copy link
Copy Markdown
Contributor

alexkaratarakis commented Jul 10, 2018

Thanks! Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexkaratarakis alexkaratarakis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HungMingWu @edmBernard @alexkaratarakis