Closed
Conversation
LilyWangLL
suggested changes
Jul 31, 2023
Comment on lines
+2
to
+16
| "name": "cpptrace", | ||
| "version-string": "v0.1", | ||
| "description": "Lightweight, zero-configuration-required, and cross-platform stacktrace library for C++ ", | ||
| "homepage": "https://github.com/jeremy-rifkin/cpptrace", | ||
| "license": "MIT", | ||
| "dependencies": [ | ||
| { | ||
| "name": "vcpkg-cmake", | ||
| "host": true | ||
| }, | ||
| { | ||
| "name": "vcpkg-cmake-config", | ||
| "host": true | ||
| } | ||
| ] |
Contributor
There was a problem hiding this comment.
Please use command .\vcpkg.exe format-manifest ports/cpptrace/vcpkg.json to format the file vcpkg.json.
Comment on lines
+2
to
+7
| OUT_SOURCE_PATH SOURCE_PATH | ||
| REPO jeremy-rifkin/cpptrace | ||
| REF 4b11b87e4d905d003d0325a53994441cc767017a | ||
| SHA512 | ||
| 7800f38e765bf667abf6b91dff88041ec9f3d6bc94a98f0745c90cfa575b6694adbe9f620de9518ebab1b1cb65d2c3c16fc58d8fae23084a94d3806cd7901c5b | ||
| HEAD_REF main |
Contributor
There was a problem hiding this comment.
Suggested change
| OUT_SOURCE_PATH SOURCE_PATH | |
| REPO jeremy-rifkin/cpptrace | |
| REF 4b11b87e4d905d003d0325a53994441cc767017a | |
| SHA512 | |
| 7800f38e765bf667abf6b91dff88041ec9f3d6bc94a98f0745c90cfa575b6694adbe9f620de9518ebab1b1cb65d2c3c16fc58d8fae23084a94d3806cd7901c5b | |
| HEAD_REF main | |
| OUT_SOURCE_PATH SOURCE_PATH | |
| REPO jeremy-rifkin/cpptrace | |
| REF 4b11b87e4d905d003d0325a53994441cc767017a | |
| SHA512 7800f38e765bf667abf6b91dff88041ec9f3d6bc94a98f0745c90cfa575b6694adbe9f620de9518ebab1b1cb65d2c3c16fc58d8fae23084a94d3806cd7901c5b | |
| HEAD_REF main |
Contributor
There was a problem hiding this comment.
Just some suggestions on formatting.
| ) | ||
|
|
||
| vcpkg_cmake_configure( | ||
| SOURCE_PATH "${SOURCE_PATH}" |
Contributor
There was a problem hiding this comment.
Suggested change
| SOURCE_PATH "${SOURCE_PATH}" | |
| SOURCE_PATH "${SOURCE_PATH}" |
dg0yt
reviewed
Jul 31, 2023
| vcpkg_from_github( | ||
| OUT_SOURCE_PATH SOURCE_PATH | ||
| REPO jeremy-rifkin/cpptrace | ||
| REF 4b11b87e4d905d003d0325a53994441cc767017a |
Contributor
There was a problem hiding this comment.
Suggested change
| REF 4b11b87e4d905d003d0325a53994441cc767017a | |
| REF "v${VERSION}" |
(Note that this requires a change to SHA512.)
LilyWangLL
suggested changes
Jul 31, 2023
| @@ -0,0 +1,17 @@ | |||
| { | |||
| "name": "cpptrace", | |||
| "version-string": "v0.1", | |||
Contributor
There was a problem hiding this comment.
Suggested change
| "version-string": "v0.1", | |
| "version": "0.1", |
Contributor
|
Pinging @jeremy-rifkin for response. Is work still being done for this PR? |
Contributor
Author
|
Hi @LilyWangLL, thank you so much for the comments! I've gotten sidetracked - I will close this and create a new PR when I'm able to return to this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
find_packagecalls are REQUIRED, are satisfied byvcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxxvcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says../vcpkg x-add-version --alland committing the result.