Skip to content

[vcpkg_find_acquire_program(PKGCONFIG)] Switch to pkgconf, add arm64#31924

Merged
vicroms merged 3 commits intomicrosoft:masterfrom
dg0yt:msys2-pkgconfig
Jun 12, 2023
Merged

[vcpkg_find_acquire_program(PKGCONFIG)] Switch to pkgconf, add arm64#31924
vicroms merged 3 commits intomicrosoft:masterfrom
dg0yt:msys2-pkgconfig

Conversation

@dg0yt
Copy link
Copy Markdown
Contributor

@dg0yt dg0yt commented Jun 10, 2023 •
edited
Loading

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download

msys2 switch to pkgconf as provider for pkg-config some time ago. The new package still provides a pkg-config.exe.

The ARM64 binary is using UCRT. There are also UCRT builds for x86, but this would raise the requirements on the host operating system version.

Note: Not tested on an ARM64 windows host, but the download and update check was verified using modified if conditions on a linux host.

@dg0yt dg0yt marked this pull request as ready for review June 10, 2023 15:45
@Adela0814 Adela0814 self-assigned this Jun 12, 2023
@Adela0814 Adela0814 added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Jun 12, 2023
@Adela0814 Adela0814 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jun 12, 2023
@vicroms vicroms merged commit 66444e1 into microsoft:master Jun 12, 2023
@dg0yt dg0yt deleted the msys2-pkgconfig branch June 13, 2023 06:19
@Cheney-W Cheney-W mentioned this pull request Jun 16, 2023
Merged
7 tasks
@akrieger akrieger mentioned this pull request Nov 20, 2023
Merged
@traversaro traversaro mentioned this pull request Feb 25, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Adela0814 Adela0814 Adela0814 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Adela0814 Adela0814

Labels

category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dg0yt @Adela0814 @vicroms