Skip to content

[curl] Update curl to 8.0.1#30304

Closed
talregev wants to merge 1 commit intomicrosoft:masterfrom
talregev:TalR/curl8
Closed

[curl] Update curl to 8.0.1#30304
talregev wants to merge 1 commit intomicrosoft:masterfrom
talregev:TalR/curl8

Conversation

@talregev
Copy link
Copy Markdown
Contributor

@talregev talregev commented Mar 20, 2023 •
edited
Loading

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@dg0yt
Copy link
Copy Markdown
Contributor

dg0yt commented Mar 20, 2023

We need 8.0.1 now.

@talregev
Copy link
Copy Markdown
Contributor Author

talregev commented Mar 20, 2023

We need 8.0.1 now.

Can you help and tell me why the CI is failing?

@talregev talregev changed the title [curl] Update curl to 8.0.0 [curl] Update curl to 8.0.1 Mar 20, 2023
@dg0yt
Copy link
Copy Markdown
Contributor

dg0yt commented Mar 20, 2023

Can you help and tell me why the CI is failing?

azure-core-cpp

CMake Error at D:/installed/x64-windows-static/share/curl/vcpkg-cmake-wrapper.cmake:11 (_find_package):
  Could not find a configuration file for package "CURL" that is compatible
  with requested version "7.44".

  The following configuration files were considered but not accepted:

    D:/installed/x64-windows-static/share/curl/CURLConfig.cmake, version: 8.0.0-DEV

kubernetes:

CMake Error at D:/installed/x64-windows-static/share/curl/vcpkg-cmake-wrapper.cmake:11 (_find_package):
  Could not find a configuration file for package "CURL" that is compatible
  with requested version "7.58.0".

  The following configuration files were considered but not accepted:

    D:/installed/x64-windows-static/share/curl/CURLConfig.cmake, version: 8.0.0-DEV

This isn't really surprising, given that curl bumped its major version. OTOH they say they didn't change the API, just celebrate 25 years. So it should be safe to patch those ports, or maybe to neutralize the version check in port curl's cmake wrapper. I did the latter for port gdal:

vcpkg/ports/gdal/vcpkg-cmake-wrapper.cmake

Lines 7 to 11 in e249dfb

# The current port version should satisfy GDAL 3.0 ... 3.5
list(GET ARGS 1 vcpkg_gdal_maybe_version)
if(vcpkg_gdal_maybe_version MATCHES "(^3\$|^3[.][0-5])")
list(REMOVE_AT ARGS "1")
endif()

@talregev
Copy link
Copy Markdown
Contributor Author

talregev commented Mar 20, 2023

Can you help and tell me why the CI is failing?

azure-core-cpp

CMake Error at D:/installed/x64-windows-static/share/curl/vcpkg-cmake-wrapper.cmake:11 (_find_package):
  Could not find a configuration file for package "CURL" that is compatible
  with requested version "7.44".

  The following configuration files were considered but not accepted:

    D:/installed/x64-windows-static/share/curl/CURLConfig.cmake, version: 8.0.0-DEV

kubernetes:

CMake Error at D:/installed/x64-windows-static/share/curl/vcpkg-cmake-wrapper.cmake:11 (_find_package):
  Could not find a configuration file for package "CURL" that is compatible
  with requested version "7.58.0".

  The following configuration files were considered but not accepted:

    D:/installed/x64-windows-static/share/curl/CURLConfig.cmake, version: 8.0.0-DEV

This isn't really surprising, given that curl bumped its major version. OTOH they say they didn't change the API, just celebrate 25 years. So it should be safe to patch those ports, or maybe to neutralize the version check in port curl's cmake wrapper. I did the latter for port gdal:

vcpkg/ports/gdal/vcpkg-cmake-wrapper.cmake

Lines 7 to 11 in e249dfb

# The current port version should satisfy GDAL 3.0 ... 3.5
list(GET ARGS 1 vcpkg_gdal_maybe_version)
if(vcpkg_gdal_maybe_version MATCHES "(^3\$|^3[.][0-5])")
list(REMOVE_AT ARGS "1")
endif()

Do you want to take this honor? If not, I will close this PR.

@talregev talregev marked this pull request as draft March 20, 2023 21:22
@talregev talregev closed this Mar 20, 2023
@dg0yt dg0yt mentioned this pull request Mar 22, 2023
Merged
7 tasks
@talregev talregev deleted the TalR/curl8 branch March 24, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@talregev @dg0yt