Skip to content

[baseline][hunspell] Use make on all platforms#28607

Merged
vicroms merged 1 commit intomicrosoft:masterfrom
vicroms:pr/hunspell-baseline-fix
Dec 29, 2022
Merged

[baseline][hunspell] Use make on all platforms#28607
vicroms merged 1 commit intomicrosoft:masterfrom
vicroms:pr/hunspell-baseline-fix

Conversation

@vicroms
Copy link
Copy Markdown
Member

@vicroms vicroms commented Dec 29, 2022

No description provided.

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/hunspell/portfile.cmake

@vicroms vicroms changed the title [hunspell] Use make on all platforms [baseline][hunspell] Use make on all platforms Dec 29, 2022
@vicroms vicroms merged commit ecce051 into microsoft:master Dec 29, 2022
@vicroms vicroms deleted the pr/hunspell-baseline-fix branch January 16, 2026 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant