Skip to content

Update cmake to 3.25.1#28522

Merged
vicroms merged 5 commits intomicrosoft:masterfrom
autoantwort:cmake-3.25.1-new
Jan 15, 2023
Merged

Update cmake to 3.25.1#28522
vicroms merged 5 commits intomicrosoft:masterfrom
autoantwort:cmake-3.25.1-new

Conversation

@autoantwort
Copy link
Copy Markdown
Contributor

Changes from #28126 but triggers a new pipeline run

github-actions[bot]
github-actions bot previously approved these changes Dec 24, 2022
github-actions[bot]
github-actions bot previously approved these changes Dec 24, 2022
@Neumann-A
Copy link
Copy Markdown
Contributor

Probably won't be green on first run so you need to trigger a second one shortly after the first finished.
But I assume you know how vcpkg CI works and why it will be green in the second run ;)

@Osyotr
Copy link
Copy Markdown
Contributor

Osyotr commented Dec 24, 2022

But I assume you know how vcpkg CI works and why it will be green in the second run ;)

Please tell me :)

@Neumann-A
Copy link
Copy Markdown
Contributor

Neumann-A commented Dec 24, 2022

Please tell me :)

triggering a rebuild will most likely only rebuild the failing ports and as such stuff like file conflicts or non declared optional dependencies will no longer fail CI due to the partial rebuild.

But i doubt that the libphonenumber baseline regression will be fixed by it.

github-actions[bot]
github-actions bot previously approved these changes Dec 25, 2022
@autoantwort
Copy link
Copy Markdown
Contributor Author

Depends on #28485

@FrankXie05 FrankXie05 added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Dec 26, 2022
@autoantwort
Copy link
Copy Markdown
Contributor Author

I don't get why libphonenumber does not find protobuf-lite. It works locally. In the ci the protobuf-lite file is there and it already finds the header. I don't see a difference between the ci and my local setup.

@FrankXie05
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@FrankXie05
Copy link
Copy Markdown
Contributor

Re-run ci to get the latest error messages. :)

@dg0yt
Copy link
Copy Markdown
Contributor

dg0yt commented Dec 27, 2022

I don't get why libphonenumber does not find protobuf-lite. It works locally. In the ci the protobuf-lite file is there and it already finds the header. I don't see a difference between the ci and my local setup.

Check the names:
libphonenumber searches for protobuf which means protobuf.lib for MSVC.
protobuf installs libprotobuf.lib and libprotobufd.lib.

github-actions[bot]
github-actions bot previously approved these changes Jan 2, 2023
@autoantwort
Copy link
Copy Markdown
Contributor Author

@FrankXie05 The last failure is a baseline regression. So maybe already add the review label?

@FrankXie05
Copy link
Copy Markdown
Contributor

Merge master for ci baseline regression.

github-actions[bot]
github-actions bot previously approved these changes Jan 12, 2023
@Neumann-A
Copy link
Copy Markdown
Contributor

@vicroms it would have been good if this pr would have been merged together with vcpkg_find_acquire_program pr since it would have halved the number of world rebuilds.
The only regression here was/is a know baseline regression which is also a leaf in the dependency tree.
How about adding a tag: Has/Shows/Discovers: baseline regression to not stop PRs from being looked at and being tagged as reviewed?

@vicroms vicroms added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jan 12, 2023
vicroms
vicroms previously approved these changes Jan 12, 2023
@vicroms vicroms removed the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jan 12, 2023
@autoantwort
Copy link
Copy Markdown
Contributor Author

@FrankXie05 The baseline regression is still there...

@FrankXie05
Copy link
Copy Markdown
Contributor

@autoantwort we will solve this regression today. :)

@vicroms
Copy link
Copy Markdown
Member

vicroms commented Jan 13, 2023

I'm ok with merging even with the existing regression on zeroc-ice, it will be addressed in another PR.

FrankXie05
FrankXie05 previously approved these changes Jan 13, 2023
@FrankXie05
Copy link
Copy Markdown
Contributor

FrankXie05 commented Jan 13, 2023

I'm ok with merging even with the existing regression on zeroc-ice, it will be addressed in another PR.

LGTM.

@FrankXie05 FrankXie05 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants