[caffe] Add new port by willyd · Pull Request #2848 · microsoft/vcpkg

willyd · 2018-02-21T01:49:49Z

WIP Do not merge. I am waiting for CI builds to pass on Caffe's side to update the github URLs in the portfile.

Alternative to PR #2570.

More features, based off caffe windows branch, dynamic and static linking should work (provided consuming projects use the /WHOLEARCHIVE flag)

New modular boost dependencies kindly provided by @cmpute.

@jasjuang @vlj your comments are welcome.

willyd · 2018-02-21T03:32:51Z

x64-windows-static build does not work with the opencv feature because patches failed to be applied (see #2762)

cmpute · 2018-02-21T14:04:06Z

I found a bug here: https://github.com/willyd/caffe/blob/vcpkg/cmake/Cuda.cmake#L42

The output of the detect code can contains warning information like

c:\program files\nvidia gpu computing toolkit\cuda\v9.1\include\crt\math_functions.h: warning C4819: The file contains a character that cannot be represented in the current code page (936). Save the file in Unicode format to prevent data loss
c:\program files\nvidia gpu computing toolkit\cuda\v9.1\include\crt\math_functions.h(838): warning C4819: The file contains a character that cannot be represented in the current code page (936). Save the file in Unicode format to prevent data loss
c:\program files\nvidia gpu computing toolkit\cuda\v9.1\include\crt\math_functions.h(1772): warning C4819: The file contains a character that cannot be represented in the current code page (936). Save the file in Unicode format to prevent data loss
c:\program files\nvidia gpu computing toolkit\cuda\v9.1\include\crt\math_functions.h(2628): warning C4819: The file contains a character that cannot be represented in the current code page (936). Save the file in Unicode format to prevent data loss
c:\program files\nvidia gpu computing toolkit\cuda\v9.1\include\crt\math_functions.h(3477): warning C4819: The file contains a character that cannot be represented in the current code page (936). Save the file in Unicode format to prevent data loss
c:\program files\nvidia gpu computing toolkit\cuda\v9.1\include\crt\math_functions.h(4417): warning C4819: The file contains a character that cannot be represented in the current code page (936). Save the file in Unicode format to prevent data loss
c:\program files\nvidia gpu computing toolkit\cuda\v9.1\include\crt\math_functions.h(5319): warning C4819: The file contains a character that cannot be represented in the current code page (936). Save the file in Unicode format to prevent data loss
c:\program files\nvidia gpu computing toolkit\cuda\v9.1\include\crt\math_functions.h(6229): warning C4819: The file contains a character that cannot be represented in the current code page (936). Save the file in Unicode format to prevent data loss
c:\program files\nvidia gpu computing toolkit\cuda\v9.1\include\crt\math_functions.h(7104): warning C4819: The file contains a character that cannot be represented in the current code page (936). Save the file in Unicode format to prevent data loss
c:\program files\nvidia gpu computing toolkit\cuda\v9.1\include\crt\math_functions.h(7914): warning C4819: The file contains a character that cannot be represented in the current code page (936). Save the file in Unicode format to prevent data loss
   Creating library a.lib and object a.exp
5.0

The last line is the expected version, however, the previous 9.1 will be fetched.

Edit regex from "([1-9].[0-9])" to "([1-9].[0-9])"$ will fix this.

cmpute · 2018-02-21T14:33:20Z

Besides, generated *.exe should be copied into ${CURRENT_PACKAGES_DIR}/tools/caffe instead of ${CURRENT_PACKAGES_DIR}/tools imo, and vcpkg_copy_tool_dependencies(${CURRENT_PACKAGES_DIR}/tools/caffe) should be called after copying the executables

willyd · 2018-02-22T13:00:10Z

@cmpute Thanks for you comments I will have a look.

cenit · 2018-02-24T23:36:29Z

A big rework of OpenCV has been recently merged. Other work will come soon, but the first part maybe is enough for your x64-windows-static to be successful. Please let me know, I am very interested in a caffe working port here on vcpkg

cmpute · 2018-03-04T11:37:43Z

@willyd Any update pls?

Cheney-W · 2019-03-07T06:32:36Z

Here are the test results. The left results column is the latest commit to this PR, the right results column is test results from master: Blank space means the port did not exist.

Processing x64-linux                      585 vs 585
    caffe                                                       Fail vs 
Processing x64-osx                        577 vs 577
    caffe                                                       Fail vs  
Processing x64-windows                    856 vs 856
    caffe                                                       Fail vs 
Processing x64-windows-static             759 vs 759
    caffe                                                       Fail vs

BTW, please modify the control version in vcpkg/ports/caffe2/control file, because you modified the vcpkg/ports/caffe2/portfile.cmake file.

cenit · 2019-03-07T11:25:38Z

@Cheney-W instead of destroying the installed caffe2 installation, I would make them exclusive, blocking the installation in case the other is found.

cbezault · 2019-08-28T22:48:51Z

/azp run

azure-pipelines · 2019-08-28T22:48:59Z

Azure Pipelines successfully started running 1 pipeline(s).

NancyLi1013 · 2020-01-14T06:00:13Z

/azp run

NancyLi1013 · 2020-01-14T06:16:23Z

ports/caffe/CONTROL

+Source: caffe
+Version: 1.0.0
+Build-Depends: boost-smart-ptr, boost-thread, boost-function, boost-date-time, boost-bind, boost-filesystem, boost-random, boost-math, boost-algorithm, gflags, glog, hdf5, protobuf, openblas
+Description: Caffe: a fast open framework for deep learning.


Could you please add Homepage here?

NancyLi1013 · 2020-01-14T06:17:35Z

ports/caffe/portfile.cmake

@@ -0,0 +1,92 @@
+if (VCPKG_TARGET_ARCHITECTURE STREQUAL x86)
+    message(FATAL_ERROR "Caffe cannot be built for the x86 architecture")
+endif()


Maybe we can use vcpkg_fail_port_install(ON_ARCH "x86") instead.

NancyLi1013 · 2020-01-14T06:18:24Z

ports/caffe/portfile.cmake

+    message(FATAL_ERROR "Caffe cannot be built for the x86 architecture")
+endif()
+
+include(vcpkg_common_functions)


include(vcpkg_common_functions) is no longer needed.
Could you please remove this line?

NancyLi1013 · 2020-01-14T06:20:26Z

ports/caffe/portfile.cmake

+
+vcpkg_from_github(
+    OUT_SOURCE_PATH SOURCE_PATH
+    REPO willyd/caffe


Is this a fork repo?

NancyLi1013 · 2020-01-14T06:22:17Z

ports/caffe/portfile.cmake

+    set(USE_LEVELDB ON)
+else()
+    set(USE_LEVELDB OFF)
+endif()


As for these features, please use vcpkg_check_features() instead.

NancyLi1013 · 2020-01-14T06:24:23Z

ports/caffe/portfile.cmake

+file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/share)
+
+
+file(INSTALL ${SOURCE_PATH}/LICENSE DESTINATION ${CURRENT_PACKAGES_DIR}/share/caffe RENAME copyright)


Could you update
file(INSTALL ${SOURCE_PATH}/LICENSE DESTINATION ${CURRENT_PACKAGES_DIR}/share/caffe RENAME copyright)
as
file(INSTALL ${SOURCE_PATH}/LICENSE DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT} RENAME copyright)?

NancyLi1013 · 2020-01-14T06:30:05Z

ports/caffe2/portfile.cmake

 file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/caffe)
 file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/caffe2)

+# Remove caffe includes to avoid conflict with caffe port


if (VCPKG_TARGET_ARCHITECTURE STREQUAL x86) message(FATAL_ERROR "Caffe2 cannot be built for the x86 architecture") endif()

This can be replaced by vcpkg_fail_port_install(ON_ARCH "x86").

please also remove include(vcpkg_common_functions) here.

vcpkg_apply_patches( SOURCE_PATH ${SOURCE_PATH} PATCHES ${CMAKE_CURRENT_LIST_DIR}/msvc-fixes.patch )

This can be merged in

vcpkg_from_github( ... PATCHES msvc-fixes.patch )

NancyLi1013 · 2020-01-14T06:37:58Z

ports/caffe2/portfile.cmake

+
 # Remove empty directories from include (should probably fix or
 # patch caffe2 install script)
 file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/include/caffe2/test)


# Remove bin directory if(VCPKG_LIBRARY_LINKAGE STREQUAL static) file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/bin) endif()

# Remove bin directory if(VCPKG_LIBRARY_LINKAGE STREQUAL static) file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/bin) endif()

These two parts can be merged to this:

if(VCPKG_LIBRARY_LINKAGE STREQUAL static) file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/bin ${CURRENT_PACKAGES_DIR}/debug/bin) endif()

Could you please update

file(MAKE_DIRECTORY ${CURRENT_PACKAGES_DIR}/share/caffe2) file(INSTALL ${SOURCE_PATH}/LICENSE DESTINATION ${CURRENT_PACKAGES_DIR}/share/caffe2 RENAME copyright)

as
file(INSTALL ${SOURCE_PATH}/LICENSE DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT} RENAME copyright)?

NancyLi1013 · 2020-01-14T06:43:31Z

Hi @willyd thanks for this PR.
Could you please also update the version in ports/caffe2/CONTROLfile?

I also noticed that this port is forked different branch from that in PR #2570.

dan-shaw · 2020-01-31T01:02:57Z

I’m going to close this PR because it’s been a long time since any update has been made. If this is something you’d like to see merged and work is being done, please reopen.

Added caffe port

3610437

jasjuang mentioned this pull request Aug 9, 2018

which branch has caffe? #4017

Closed

Neumann-A mentioned this pull request Oct 12, 2018

Add Tensorflow & Caffe libraries #4455

Closed

PhoebeHui added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jan 22, 2019

Cheney-W removed the category:new-port The issue is requesting a new library to be added; consider making a PR! label Mar 7, 2019

microsoft deleted a comment from azure-pipelines bot May 10, 2019

cbezault assigned Rastaban Aug 28, 2019

luncliff mentioned this pull request Sep 30, 2019

[libtorch] Add new port #8318

Closed

Rastaban assigned vicroms and unassigned Rastaban Oct 3, 2019

PhoebeHui assigned NancyLi1013 Jan 14, 2020

NancyLi1013 suggested changes Jan 14, 2020

View reviewed changes

NancyLi1013 changed the title ~~Added caffe port~~ [caffe] Add new port Jan 14, 2020

NancyLi1013 added the waiting for response label Jan 20, 2020

dan-shaw closed this Jan 31, 2020

		file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/share)


		file(INSTALL ${SOURCE_PATH}/LICENSE DESTINATION ${CURRENT_PACKAGES_DIR}/share/caffe RENAME copyright)

Conversation

willyd commented Feb 21, 2018

Uh oh!

willyd commented Feb 21, 2018

Uh oh!

cmpute commented Feb 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmpute commented Feb 21, 2018

Uh oh!

willyd commented Feb 22, 2018

Uh oh!

cenit commented Feb 24, 2018

Uh oh!

cmpute commented Mar 4, 2018

Uh oh!

Cheney-W commented Mar 7, 2019

Uh oh!

cenit commented Mar 7, 2019

Uh oh!

cbezault commented Aug 28, 2019

Uh oh!

azure-pipelines bot commented Aug 28, 2019

Uh oh!

NancyLi1013 commented Jan 14, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NancyLi1013 commented Jan 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dan-shaw commented Jan 31, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

cmpute commented Feb 21, 2018 •

edited

Loading

NancyLi1013 commented Jan 14, 2020 •

edited

Loading