Skip to content

[vulkan-headers] Update port to latest 1.3.234 version#27746

Merged
JavierMatosD merged 9 commits intomicrosoft:masterfrom
Honeybunch:vulkan-headers
Nov 11, 2022
Merged

[vulkan-headers] Update port to latest 1.3.234 version#27746
JavierMatosD merged 9 commits intomicrosoft:masterfrom
Honeybunch:vulkan-headers

Conversation

@Honeybunch
Copy link
Copy Markdown
Contributor

@Honeybunch Honeybunch commented Nov 10, 2022

Describe the pull request

  • What does your PR fix?

    Updates vulkan-headers

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    All

  • Does your PR follow the maintainer guide?

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

github-actions[bot]
github-actions bot previously approved these changes Nov 10, 2022
View reviewed changes
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/vulkan-headers/vcpkg.json

Valid values for the license field can be found in the documentation

@MonicaLiu0311 MonicaLiu0311 added the category:port-update The issue is with a library, which is requesting update new revision label Nov 10, 2022
MonicaLiu0311
MonicaLiu0311 reviewed Nov 10, 2022
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Nov 10, 2022
View reviewed changes
@juan-lunarg
Copy link
Copy Markdown
Contributor

juan-lunarg commented Nov 10, 2022

@Honeybunch as of v1.3.234 there is now proper find_package support for Vulkan-Headers.

# https://github.com/KhronosGroup/Vulkan-Headers/blob/v1.3.234/BUILD.md#usage-in-cmake
find_package(VulkanHeaders REQUIRED CONFIG)

target_link_libraries(foobar PRIVATE Vulkan::Headers)

@juan-lunarg
Copy link
Copy Markdown
Contributor

juan-lunarg commented Nov 10, 2022

This find_package support is actively tested via the validation layers and the loader.

See KhronosGroup/Vulkan-ValidationLayers@e09172e as an example.

@Honeybunch Honeybunch changed the title [vulkan-headers] Update port to latest 1.3.233 version [vulkan-headers] Update port to latest 1.3.234 version Nov 11, 2022
@Honeybunch
Copy link
Copy Markdown
Contributor Author

Honeybunch commented Nov 11, 2022

Bumped to latest version

github-actions[bot]
github-actions bot previously approved these changes Nov 11, 2022
View reviewed changes
@MonicaLiu0311 MonicaLiu0311 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Nov 11, 2022
@JavierMatosD
Copy link
Copy Markdown
Contributor

JavierMatosD commented Nov 11, 2022

Thank you!

@JavierMatosD JavierMatosD merged commit 4ecb439 into microsoft:master Nov 11, 2022
@njakob njakob mentioned this pull request Dec 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

+1 more reviewer

@MonicaLiu0311 MonicaLiu0311 MonicaLiu0311 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MonicaLiu0311 MonicaLiu0311

Labels

category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Honeybunch @juan-lunarg @JavierMatosD @MonicaLiu0311