[vcpkg.cmake] fix find_package not restoring variables correctly.#27689
Merged
ras0219-msft merged 8 commits intomicrosoft:masterfrom Nov 16, 2022
Merged
[vcpkg.cmake] fix find_package not restoring variables correctly.#27689ras0219-msft merged 8 commits intomicrosoft:masterfrom
ras0219-msft merged 8 commits intomicrosoft:masterfrom
Conversation
Contributor
Author
|
@BillyONeal: another angle related failure in @dg0yt: I assume you already encountered that one. |
Contributor
Author
|
@BillyONeal: I also request a full rebuild here. (which will automatically resolve the x64-linux error) |
LilyWangLL
approved these changes
Nov 14, 2022
BillyONeal
approved these changes
Nov 14, 2022
Member
BillyONeal
left a comment
There was a problem hiding this comment.
@ras0219-msft This LGTM, can you double check?
Member
|
Note to self: If Robert doesn't merge by EOD Wednesday, merge. |
ras0219-msft
approved these changes
Nov 16, 2022
Contributor
ras0219-msft
left a comment
There was a problem hiding this comment.
LGTM, I think we could use slightly shorter variable names but all the logic looks correct.
Thank you very much for fixing this issue!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #27498
closes #19030