Skip to content

[libgd] Fixes, feature "tools"#27551

Merged
BillyONeal merged 5 commits intomicrosoft:masterfrom
dg0yt:libgd
Nov 2, 2022
Merged

[libgd] Fixes, feature "tools"#27551
BillyONeal merged 5 commits intomicrosoft:masterfrom
dg0yt:libgd

Conversation

@dg0yt
Copy link
Copy Markdown
Contributor

@dg0yt dg0yt commented Oct 30, 2022

Needed for #27471.

dg0yt added 2 commits October 30, 2022 06:16
Fix dependencies and pkg-config export.
Add tools feature.
github-actions[bot]
github-actions bot previously approved these changes Oct 30, 2022
github-actions[bot]
github-actions bot previously approved these changes Oct 30, 2022
@dg0yt dg0yt marked this pull request as draft October 30, 2022 06:32
github-actions[bot]
github-actions bot previously approved these changes Oct 30, 2022
@dg0yt dg0yt marked this pull request as ready for review October 30, 2022 09:09
@dg0yt
Copy link
Copy Markdown
Contributor Author

dg0yt commented Oct 30, 2022

gdlib.pc used and validated in #27471.
MSVC fix submitted merged as libgd/libgd#849.
libwebp pkg-config usage submitted as libgd/libgd#851.
Feature control problem reported as libgd/libgd#850.

@Cheney-W Cheney-W self-assigned this Oct 31, 2022
@Cheney-W Cheney-W added category:port-bug The issue is with a library, which is something the port should already support category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist labels Oct 31, 2022
@Cheney-W
Copy link
Copy Markdown
Contributor

Cheney-W commented Nov 1, 2022

All features passed with following triplets:
x86-windows
x64-windows
x64-windows-static

@Cheney-W Cheney-W added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Nov 1, 2022
@BillyONeal
Copy link
Copy Markdown
Member

gdlib.pc used and validated in #27471. MSVC fix submitted merged as libgd/libgd#849. libwebp pkg-config usage submitted as libgd/libgd#851. Feature control problem reported as libgd/libgd#850.

Thank you so much!

@BillyONeal BillyONeal merged commit cafd398 into microsoft:master Nov 2, 2022
@dg0yt dg0yt deleted the libgd branch November 2, 2022 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants