Skip to content

[pthreads] Fixed build on Windows ARM64#27299

Merged
BillyONeal merged 4 commits intomicrosoft:masterfrom
ice0:fix-pthreads-win-arm64
Nov 2, 2022
Merged

[pthreads] Fixed build on Windows ARM64#27299
BillyONeal merged 4 commits intomicrosoft:masterfrom
ice0:fix-pthreads-win-arm64

Conversation

@ice0
Copy link
Copy Markdown
Contributor

@ice0 ice0 commented Oct 18, 2022 •
edited by Cheney-W
Loading

Build stops with an error:

version.rc(132) : error RC2104 : undefined keyword or key name: __PTW32_VERSIONINFO_DESCRIPTION

Fixed by adding definitions for ARM64 arch.

Fixing #27258

@LilyWangLL LilyWangLL added the category:port-bug The issue is with a library, which is something the port should already support label Oct 18, 2022
github-actions[bot]
github-actions bot previously approved these changes Oct 18, 2022
View reviewed changes
@ice0 ice0 mentioned this pull request Oct 19, 2022
Merged
@ice0
Copy link
Copy Markdown
Contributor Author

ice0 commented Oct 19, 2022 •
edited
Loading

@LilyWangLL @Cheney-W
#27312 needs to be merged before we can continue here.

@LilyWangLL LilyWangLL added the depends:different-pr This PR or Issue depends on a PR which has been filed label Oct 19, 2022
@ice0 ice0 force-pushed the fix-pthreads-win-arm64 branch from f08a221 to d9c59b9 Compare October 21, 2022 00:43
github-actions[bot]
github-actions bot previously approved these changes Oct 21, 2022
View reviewed changes
@Cheney-W Cheney-W removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Oct 21, 2022
@Cheney-W Cheney-W added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. labels Oct 28, 2022
@BillyONeal
* Add upstream submission link.
693ac8b 
* Use VERSION
* Add quotes around NMAKE's path.
BillyONeal
BillyONeal approved these changes Oct 29, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I submitted upstream as https://sourceforge.net/p/pthreads4w/code/merge-requests/6/

As you noted, upstream seems completely inactive, and this is identical to surrounding code but for the architecture, so I'm happy to merge without waiting for confirmation.

@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Nov 1, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Nov 1, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Nov 1, 2022

This run seemed wedged so I cancelled and restarted it.

@BillyONeal BillyONeal merged commit 6cf58ad into microsoft:master Nov 2, 2022
@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Nov 2, 2022

Thanks!

@JonLiu1993 JonLiu1993 mentioned this pull request Feb 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@Cheney-W Cheney-W

Labels

category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ice0 @BillyONeal @Cheney-W @LilyWangLL