Skip to content

gtk 3.24.34 port#27026

Merged
vicroms merged 1 commit intomicrosoft:masterfrom
mkhon:feature/gtk3
Oct 3, 2022
Merged

gtk 3.24.34 port#27026
vicroms merged 1 commit intomicrosoft:masterfrom
mkhon:feature/gtk3

Conversation

@mkhon
Copy link
Copy Markdown
Contributor

@mkhon mkhon commented Sep 28, 2022

Describe the pull request

  • What does your PR fix?

    Fixes #...

  • Which triplets are supported/not supported? Have you updated the CI baseline?

all

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

github-actions[bot]
github-actions bot previously approved these changes Sep 28, 2022
View reviewed changes
@talregev talregev mentioned this pull request Sep 28, 2022
Closed
@talregev
Copy link
Copy Markdown
Contributor

talregev commented Sep 28, 2022

This PR hold the latest master?

@talregev
Copy link
Copy Markdown
Contributor

talregev commented Sep 28, 2022

@dg0yt @JackBoosY Can you help?

@FrankXie05 FrankXie05 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Sep 29, 2022
@JackBoosY
Copy link
Copy Markdown
Contributor

JackBoosY commented Sep 29, 2022 •
edited
Loading 

Run-time dependency atk-bridge-2.0 found: NO (tried pkgconfig and cmake)

../src/3.24.34-35fefc5b4d.clean/meson.build:585:2: ERROR: Dependency "atk-bridge-2.0" not found, tried pkgconfig and cmake

Determining dependency 'atk-bridge-2.0' with pkg-config executable '/bin/pkg-config'
env[PKG_CONFIG]: /bin/pkg-config
env[PKG_CONFIG_PATH]: /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/:/mnt/vcpkg-ci/installed/x64-linux/debug/share/pkgconfig/
Called `/bin/pkg-config --modversion atk-bridge-2.0` -> 1

CMake binary for 1 is cached.
Preliminary CMake check failed. Aborting.
Run-time dependency atk-bridge-2.0 found: NO (tried pkgconfig and cmake)

../src/3.24.34-35fefc5b4d.clean/meson.build:585:2: ERROR: Dependency "atk-bridge-2.0" not found, tried pkgconfig and cmake

There only have installed/x64-linux/lib/pkgconfig/atk.pc, not atk-bridge-2.0.pc.

@talregev
Copy link
Copy Markdown
Contributor

talregev commented Sep 29, 2022 •
edited
Loading

@JackBoosY We should add at-spi2-atk port to the dependencies. Can you do it?

@talregev
Copy link
Copy Markdown
Contributor

talregev commented Sep 29, 2022

@mkhon Can you add at-spi2-atk port to the dependencies?

@talregev
Copy link
Copy Markdown
Contributor

talregev commented Sep 29, 2022 •
edited
Loading

@JackBoosY Please review again. Thank you!

JackBoosY
JackBoosY suggested changes Sep 30, 2022
View reviewed changes
@JackBoosY JackBoosY added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Sep 30, 2022
@abitrolly abitrolly mentioned this pull request Oct 1, 2022
Closed
@stevapple
Copy link
Copy Markdown

stevapple commented Oct 2, 2022

Is it ready for merge now?👀 Gtk3 is a long awaited port and many OSS projects could benefit from it🎉

Thank you for all the work!

@vicroms vicroms merged commit 8709c33 into microsoft:master Oct 3, 2022
@mkhon mkhon deleted the feature/gtk3 branch October 3, 2022 16:14
@dg0yt dg0yt mentioned this pull request Oct 3, 2022
Closed
@JonLiu1993 JonLiu1993 mentioned this pull request Feb 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

+1 more reviewer

@JackBoosY JackBoosY JackBoosY approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JackBoosY JackBoosY

@FrankXie05 FrankXie05

Labels

category:new-port The issue is requesting a new library to be added; consider making a PR! info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mkhon @talregev @JackBoosY @stevapple @vicroms @FrankXie05