[vcpkg baseline][dpp] Add DISABLE_PARALLEL_CONFIGURE#26687
Merged
dan-shaw merged 1 commit intomicrosoft:masterfrom Sep 6, 2022
Merged
[vcpkg baseline][dpp] Add DISABLE_PARALLEL_CONFIGURE#26687dan-shaw merged 1 commit intomicrosoft:masterfrom
dan-shaw merged 1 commit intomicrosoft:masterfrom
Conversation
JackBoosY
approved these changes
Sep 5, 2022
Contributor
|
@JavierMatosD Please merge this PR first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
In VCPKG CI testing, dpp failed with following error:This issue is because the upstream's CMakeLists.txt file contains following codes:
configure_file("${CMAKE_CURRENT_SOURCE_DIR}/src/dpp/dpp.rc.in" "${CMAKE_CURRENT_SOURCE_DIR}/src/dpp/dpp.rc" NEWLINE_STYLE WIN32)The file operation here may cause the same file to be operated at the same time during parallel config, resulting in the above error. This issue could be fixed by adding
DISABLE_PARALLEL_CONFIGUREin the config step.