[windres-rc] support --define, --include-dir#26454
Merged
JavierMatosD merged 2 commits intomicrosoft:masterfrom Aug 23, 2022
Merged
[windres-rc] support --define, --include-dir#26454JavierMatosD merged 2 commits intomicrosoft:masterfrom
JavierMatosD merged 2 commits intomicrosoft:masterfrom
Conversation
55d1ed8 to
5666689
Compare
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for gpgme have changed but the version was not updated
version: 1.14.0#2
old SHA: f037926ddc1a092f0db7089609e65ff9f221fa77
new SHA: aa178ab736a0cdb40ebbae130bdaf55dc136743b
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
4 tasks
Contributor
|
I'm not sure about this part, needs @BillyONeal @ras0219-msft review this. |
Neumann-A
reviewed
Aug 23, 2022
| ;; | ||
| --include-dir*) | ||
| eat=1 | ||
| set x "$@" "-I $2" |
Contributor
There was a problem hiding this comment.
since $2 is a path doesn't this require func_file_conv ?
Member
|
Related: #26424 |
Contributor
|
Thanks! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Adds support for missing windres CLI switches:
--defineand--includeWhich triplets are supported/not supported? Have you updated the CI baseline?
Not applicable
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Not applicable