Skip to content

Deprecated VCPKG_PREFER_SYSTEM_LIBS#26449

Merged
JavierMatosD merged 1 commit intomicrosoft:masterfrom
dg0yt:deprecate-prefer-system-libs
Aug 23, 2022
Merged

Deprecated VCPKG_PREFER_SYSTEM_LIBS#26449
JavierMatosD merged 1 commit intomicrosoft:masterfrom
dg0yt:deprecate-prefer-system-libs

Conversation

@dg0yt
Copy link
Copy Markdown
Contributor

@dg0yt dg0yt commented Aug 21, 2022

Factored out of #21783.

  • What does your PR fix?

    Deprecates VCPKG_PREFER_SYSTEM_LIBS, suggesting overlay ports as a reliable alternative.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all, no

  • Does your PR follow the maintainer guide?

    yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    not needed

@dg0yt dg0yt changed the title [world rebuild] Deprecated VCPKG_PREFER_SYSTEM_LIBS Deprecated VCPKG_PREFER_SYSTEM_LIBS Aug 21, 2022
@dg0yt
Copy link
Copy Markdown
Contributor Author

dg0yt commented Aug 21, 2022

No world rebuild (and it is not needed anyways).

@JackBoosY JackBoosY added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Aug 22, 2022
@JackBoosY
Copy link
Copy Markdown
Contributor

cc @Neumann-A

@JackBoosY
Copy link
Copy Markdown
Contributor

@dg0yt dg0yt marked this pull request as ready for review August 22, 2022 06:28

### `VCPKG_PREFER_SYSTEM_LIBS`

**This feature has been deprecated. Use empty overlay ports instead.**
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to add a link to the overlay documentation here.

@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Aug 23, 2022
@JavierMatosD JavierMatosD merged commit 02fcf92 into microsoft:master Aug 23, 2022
@dg0yt dg0yt deleted the deprecate-prefer-system-libs branch August 24, 2022 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants