[scripts|msbuild] pass toolchain flags#26370
[scripts|msbuild] pass toolchain flags#26370Neumann-A wants to merge 81 commits intomicrosoft:masterfrom
Conversation
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for libirecovery have changed but the version was not updated
version: 1.0.25#4
old SHA: 1396dbed8e08ee556ad00ce3a67ba0de7c7b6298
new SHA: d0ea3a8db039ff53fc18b93eebe641eef6d1128e
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for libirecovery have changed but the version was not updated
version: 1.0.25#4
old SHA: 1396dbed8e08ee556ad00ce3a67ba0de7c7b6298
new SHA: d0ea3a8db039ff53fc18b93eebe641eef6d1128e
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for libirecovery have changed but the version was not updated
version: 1.0.25#4
old SHA: 1396dbed8e08ee556ad00ce3a67ba0de7c7b6298
new SHA: d0ea3a8db039ff53fc18b93eebe641eef6d1128e
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
|
ACE looks like supports |
|
@BillyONeal Are the releases of the WindowsSDK also gated by vcpkg? The errors I see here in ecsutil are related to https://developercommunity.visualstudio.com/t/code-using-windows-10-sdk-100203480-cant-be-compil/1521695 |
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for libirecovery have changed but the version was not updated
version: 1.0.25#4
old SHA: 1396dbed8e08ee556ad00ce3a67ba0de7c7b6298
new SHA: d0ea3a8db039ff53fc18b93eebe641eef6d1128e
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for libirecovery have changed but the version was not updated
version: 1.0.25#4
old SHA: 1396dbed8e08ee556ad00ce3a67ba0de7c7b6298
new SHA: d0ea3a8db039ff53fc18b93eebe641eef6d1128e
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for zeroc-ice have changed but the version was not updated
version: 3.7.7#2
old SHA: 1ddc4746c1f19fca41706071fac4575ea99fe6b9
new SHA: 08c5d9acb5c03a155e0b506ad8960fc815771466
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
I believe we are currently installing 22621 in our lab: |
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for python3 have changed but the version was not updated
version: 3.10.5#2
old SHA: 6e7ddcd01a8341a906d5dde6b3d221c955571684
new SHA: 1a67cfede8f633634a022371ac4d9ff8cc163d6a
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for libirecovery have changed but the version was not updated
version: 1.0.25#4
old SHA: 1396dbed8e08ee556ad00ce3a67ba0de7c7b6298
new SHA: d0ea3a8db039ff53fc18b93eebe641eef6d1128e
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for zeroc-ice have changed but the version was not updated
version: 3.7.7#2
old SHA: 1ddc4746c1f19fca41706071fac4575ea99fe6b9
new SHA: 08c5d9acb5c03a155e0b506ad8960fc815771466
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for python3 have changed but the version was not updated
version: 3.10.5#2
old SHA: 6e7ddcd01a8341a906d5dde6b3d221c955571684
new SHA: ddd9cf9142504b4a69ed00d7ce2cfa31d6e0ecf8
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for pmdk have changed but the version was not updated
version: 1.12.0
old SHA: a5b1d48503eab5f709ccc7cb62630817275f93e5
new SHA: bb5fddd396b353c211f4079f0f25a43d80e073ac
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for libirecovery have changed but the version was not updated
version: 1.0.25#4
old SHA: 1396dbed8e08ee556ad00ce3a67ba0de7c7b6298
new SHA: d0ea3a8db039ff53fc18b93eebe641eef6d1128e
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for libfabric have changed but the version was not updated
version: 1.13.2#1
old SHA: d0a766bd1f01a742dcc12e13bafd741b94d7a3c0
new SHA: 0f701400e46d829310941bf007f5ec5e81173288
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for zeroc-ice have changed but the version was not updated
version: 3.7.7#2
old SHA: 1ddc4746c1f19fca41706071fac4575ea99fe6b9
new SHA: 08c5d9acb5c03a155e0b506ad8960fc815771466
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for python3 have changed but the version was not updated
version: 3.10.5#2
old SHA: 6e7ddcd01a8341a906d5dde6b3d221c955571684
new SHA: ddd9cf9142504b4a69ed00d7ce2cfa31d6e0ecf8
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for pmdk have changed but the version was not updated
version: 1.12.0
old SHA: a5b1d48503eab5f709ccc7cb62630817275f93e5
new SHA: bb5fddd396b353c211f4079f0f25a43d80e073ac
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for libirecovery have changed but the version was not updated
version: 1.0.25#4
old SHA: 1396dbed8e08ee556ad00ce3a67ba0de7c7b6298
new SHA: d0ea3a8db039ff53fc18b93eebe641eef6d1128e
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for libfabric have changed but the version was not updated
version: 1.13.2#1
old SHA: d0a766bd1f01a742dcc12e13bafd741b94d7a3c0
new SHA: 0f701400e46d829310941bf007f5ec5e81173288
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for zeroc-ice have changed but the version was not updated
version: 3.7.7#2
old SHA: 1ddc4746c1f19fca41706071fac4575ea99fe6b9
new SHA: 08c5d9acb5c03a155e0b506ad8960fc815771466
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
There was a problem hiding this comment.
You have modified or added at least one portfile where deprecated functions are used.
Details
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}The following files are affected:
ports/libusbmuxd/portfile.cmake
You have modified or added at least one vcpkg.json where you should check the license field.
Details
If you feel able to do so, please consider adding a "license" field to the following files:
ports/3fd/vcpkg.jsonports/activemq-cpp/vcpkg.jsonports/chakracore/vcpkg.jsonports/easyhook/vcpkg.jsonports/ecsutil/vcpkg.jsonports/gsoap/vcpkg.jsonports/ideviceinstaller/vcpkg.jsonports/idevicerestore/vcpkg.jsonports/libfabric/vcpkg.jsonports/libgpg-error/vcpkg.jsonports/libimobiledevice/vcpkg.jsonports/libirecovery/vcpkg.jsonports/libmicrohttpd/vcpkg.jsonports/libosip2/vcpkg.jsonports/libusbmuxd/vcpkg.jsonports/monkeys-audio/vcpkg.jsonports/nmap/vcpkg.jsonports/pbc/vcpkg.jsonports/rsasynccpp/vcpkg.jsonports/scintilla/vcpkg.jsonports/usbmuxd/vcpkg.jsonports/winpcap/vcpkg.json
Valid values for the license field can be found in the documentation
If you feel able to do so, please consider replacing the deprecated license identifiers in the following files:
ports/libusb/vcpkg.json(has deprecated licenseLGPL-2.1)
Deprecated and non deprecated license identifiers can be found here
# Conflicts: # versions/p-/python3.json
There was a problem hiding this comment.
You have modified or added at least one portfile where deprecated functions are used.
Details
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}The following files are affected:
ports/libusbmuxd/portfile.cmake
You have modified or added at least one vcpkg.json where you should check the license field.
Details
If you feel able to do so, please consider adding a "license" field to the following files:
ports/3fd/vcpkg.jsonports/activemq-cpp/vcpkg.jsonports/chakracore/vcpkg.jsonports/easyhook/vcpkg.jsonports/ecsutil/vcpkg.jsonports/gsoap/vcpkg.jsonports/ideviceinstaller/vcpkg.jsonports/idevicerestore/vcpkg.jsonports/libfabric/vcpkg.jsonports/libgpg-error/vcpkg.jsonports/libimobiledevice/vcpkg.jsonports/libirecovery/vcpkg.jsonports/libmicrohttpd/vcpkg.jsonports/libosip2/vcpkg.jsonports/libusbmuxd/vcpkg.jsonports/monkeys-audio/vcpkg.jsonports/nmap/vcpkg.jsonports/pbc/vcpkg.jsonports/rsasynccpp/vcpkg.jsonports/scintilla/vcpkg.jsonports/usbmuxd/vcpkg.jsonports/winpcap/vcpkg.json
Valid values for the license field can be found in the documentation
If you feel able to do so, please consider replacing the deprecated license identifiers in the following files:
ports/libusb/vcpkg.json(has deprecated licenseLGPL-2.1)
Deprecated and non deprecated license identifiers can be found here
# Conflicts: # ports/nmap/portfile.cmake # versions/l-/libusb.json # versions/n-/nmap.json # versions/z-/zeroc-ice.json
There was a problem hiding this comment.
You have modified or added at least one portfile where deprecated functions are used.
Details
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}The following files are affected:
ports/ace/portfile.cmakeports/activemq-cpp/portfile.cmakeports/chakracore/portfile.cmakeports/hunspell/portfile.cmakeports/libmicrohttpd/portfile.cmakeports/libosip2/portfile.cmakeports/libusbmuxd/portfile.cmakeports/mdnsresponder/portfile.cmakeports/monkeys-audio/portfile.cmakeports/ngspice/portfile.cmakeports/nmap/portfile.cmakeports/pbc/portfile.cmakeports/python2/portfile.cmakeports/python3/portfile.cmakeports/scintilla/portfile.cmakeports/tracy/portfile.cmakeports/unrar/portfile.cmakeports/winpcap/portfile.cmake
You have modified or added at least one vcpkg.json where you should check the license field.
Details
If you feel able to do so, please consider adding a "license" field to the following files:
ports/3fd/vcpkg.jsonports/activemq-cpp/vcpkg.jsonports/chakracore/vcpkg.jsonports/easyhook/vcpkg.jsonports/ecsutil/vcpkg.jsonports/gsoap/vcpkg.jsonports/ideviceinstaller/vcpkg.jsonports/idevicerestore/vcpkg.jsonports/libfabric/vcpkg.jsonports/libgpg-error/vcpkg.jsonports/libimobiledevice/vcpkg.jsonports/libirecovery/vcpkg.jsonports/libmicrohttpd/vcpkg.jsonports/libosip2/vcpkg.jsonports/libusbmuxd/vcpkg.jsonports/monkeys-audio/vcpkg.jsonports/nmap/vcpkg.jsonports/pbc/vcpkg.jsonports/rsasynccpp/vcpkg.jsonports/scintilla/vcpkg.jsonports/usbmuxd/vcpkg.jsonports/winpcap/vcpkg.json
Valid values for the license field can be found in the documentation
If you feel able to do so, please consider replacing the deprecated license identifiers in the following files:
ports/libusb/vcpkg.json(has deprecated licenseLGPL-2.1)
Deprecated and non deprecated license identifiers can be found here
|
@BillyONeal Should I split this PR in only the |
|
@Neumann-A, according to your PR, I split |
| set(msvc "") | ||
| if(arg_MSVC_SYNTAX) | ||
| set(msvc "--msvc-syntax") | ||
| endif() |
There was a problem hiding this comment.
This isn't satisfying yet. I already pass --msvc-syntax with the modules list in some ports. Each of these ports must decide whether it needs to use the option. IMO it should be the default for MSVC triplets, possibly overriden with MSVC_SYNTAX <bool>, or with a triplet variable for use in custom triplets.
There was a problem hiding this comment.
Currently 9 files with x_vcpkg_pkgconfig_get_modules. 4 with --msvc-syntax. Looks more like a fifty-fifty for me.
There was a problem hiding this comment.
Well, I have been cautious to not use it too much, given its x prefix.
The use cases are:
nmakebuilds: MSVC syntax- autotools builds: no MSVC syntax (at least for my coinutils PR).
qt5: I don't remember right now.
|
Converting to draft. This PR is more like a port status PR for the transition as soon as the other PR with the scripts is merged. It also shows how to convert. |
# Conflicts: # ports/3fd/portfile.cmake # ports/3fd/vcpkg.json # ports/ace/portfile.cmake # ports/ace/vcpkg.json # ports/activemq-cpp/portfile.cmake # ports/activemq-cpp/vcpkg.json # ports/boost-vcpkg-helpers/LICENSE.txt # ports/chakracore/portfile.cmake # ports/chakracore/vcpkg.json # ports/easyhook/portfile.cmake # ports/easyhook/vcpkg.json # ports/ecsutil/portfile.cmake # ports/ecsutil/vcpkg.json # ports/hunspell/portfile.cmake # ports/hunspell/vcpkg.json # ports/ideviceinstaller/portfile.cmake # ports/ideviceinstaller/vcpkg.json # ports/libgpg-error/portfile.cmake # ports/libgpg-error/vcpkg.json # ports/libimobiledevice/vcpkg.json # ports/libirecovery/vcpkg.json # ports/libmicrohttpd/portfile.cmake # ports/libmicrohttpd/vcpkg.json # ports/libusb/vcpkg.json # ports/libusbmuxd/portfile.cmake # ports/mdnsresponder/portfile.cmake # ports/mdnsresponder/vcpkg.json # ports/monkeys-audio/portfile.cmake # ports/monkeys-audio/vcpkg.json # ports/ngspice/vcpkg.json # ports/nmap/vcpkg.json # ports/ocilib/portfile.cmake # ports/ocilib/vcpkg.json # ports/pbc/portfile.cmake # ports/python3/portfile.cmake # ports/python3/python_vcpkg.props.in # ports/python3/vcpkg.json # ports/rsasynccpp/portfile.cmake # ports/sdl1/portfile.cmake # ports/shiftmedia-libgcrypt/vcpkg.json # ports/tracy/portfile.cmake # ports/tracy/vcpkg.json # ports/unrar/vcpkg.json # ports/usbmuxd/vcpkg.json # ports/vcpkg-msbuild/portfile.cmake # ports/vcpkg-msbuild/vcpkg-port-config.cmake # ports/vcpkg-msbuild/vcpkg.json # ports/vcpkg-msbuild/vcpkg_msbuild_install.cmake # ports/vcpkg-pkgconfig-get-modules/vcpkg.json # ports/vcpkg-pkgconfig-get-modules/x_vcpkg_pkgconfig_get_modules.cmake # ports/winpcap/vcpkg.json # ports/zeroc-ice/vcpkg.json # scripts/ci.baseline.txt # versions/3-/3fd.json # versions/a-/ace.json # versions/a-/activemq-cpp.json # versions/baseline.json # versions/c-/chakracore.json # versions/e-/easyhook.json # versions/e-/ecsutil.json # versions/h-/hunspell.json # versions/i-/ideviceinstaller.json # versions/l-/libgpg-error.json # versions/l-/libimobiledevice.json # versions/l-/libirecovery.json # versions/l-/libmicrohttpd.json # versions/l-/libosip2.json # versions/l-/libusb.json # versions/l-/libusbmuxd.json # versions/l-/libvpx.json # versions/m-/mdnsresponder.json # versions/m-/monkeys-audio.json # versions/m-/mp3lame.json # versions/n-/ngspice.json # versions/n-/nmap.json # versions/o-/ocilib.json # versions/p-/pbc.json # versions/p-/python2.json # versions/p-/python3.json # versions/r-/rsasynccpp.json # versions/s-/scintilla.json # versions/s-/sdl1.json # versions/s-/shiftmedia-libgcrypt.json # versions/t-/tracy.json # versions/u-/unrar.json # versions/u-/usbmuxd.json # versions/v-/vcpkg-msbuild.json # versions/v-/vcpkg-pkgconfig-get-modules.json # versions/w-/winpcap.json # versions/z-/zeroc-ice.json
Ports using msbuild:
chakracorezeroc-ice
3fdaceactivemq-cppeasyhookecsutilgsoaphunspell-> moved to makeideviceinstalleridevicerestorelibfabriclibgpg-errorlibirecoverylibmicrohttpdlibosip2libusblibvpxmdnsrespondermonkeys-audiomp3lamempirngspicenmapocilibopenni2pbcpmdkpython2python3rsasynccppscintillasdl1tbb-> moved to cmaketracy-> done by somebody elseunicornunrarusbmuxdwinpcap