Skip to content

[vcpkg baseline][libharu] update to 2.4.0-rc1#25569

Merged
vicroms merged 10 commits intomicrosoft:masterfrom
Adela0814:Dev/Mengna/libharu
Jul 13, 2022
Merged

[vcpkg baseline][libharu] update to 2.4.0-rc1#25569
vicroms merged 10 commits intomicrosoft:masterfrom
Adela0814:Dev/Mengna/libharu

Conversation

@Adela0814
Copy link
Copy Markdown
Contributor

@Adela0814 Adela0814 commented Jul 5, 2022

Fix #25537

The duplicated symbols of tiff/libharu have been fixed, so remove the patch tiff.patch and the feature.

@Adela0814 Adela0814 added info:internal category:port-update The issue is with a library, which is requesting update new revision labels Jul 5, 2022
github-actions[bot]
github-actions bot previously approved these changes Jul 5, 2022
View reviewed changes
@JonLiu1993 JonLiu1993 mentioned this pull request Jul 5, 2022
Closed
@larshg
Copy link
Copy Markdown
Contributor

larshg commented Jul 5, 2022

Missing updating here - thx for the PR 😄

@larshg
Copy link
Copy Markdown
Contributor

larshg commented Jul 5, 2022 •
edited
Loading

Seems libharu doesn't produce any .lib files, so VTK fails on windows-x64 😢

-- Could NOT find LibHaru (missing: LibHaru_LIBRARY) (found suitable version "2.4.0-dev", minimum required is "2.4.0")
CMake Error at CMake/vtkModule.cmake:4228 (message):
  Could not find the LibHaru external dependency.
Call Stack (most recent call first):
  CMake/vtkModule.cmake:4784 (vtk_module_find_package)
  CMake/vtkModule.cmake:4655 (vtk_module_third_party_external)
  ThirdParty/libharu/CMakeLists.txt:1 (vtk_module_third_party)

@Adela0814
Copy link
Copy Markdown
Contributor Author

Adela0814 commented Jul 6, 2022

Missing updating here - thx for the PR 😄

Thanks for your reminder, I'm working on this.

github-actions[bot]
github-actions bot previously approved these changes Jul 6, 2022
View reviewed changes
@larshg
Copy link
Copy Markdown
Contributor

larshg commented Jul 6, 2022 •
edited
Loading

This looks odd: https://github.com/libharu/libharu/blob/6997cf775b2345e3db82ac774fe2931faf348458/src/CMakeLists.txt#L90-L95 - there are no targets in the install command. Seems to be fixed on master. Seems to how it is on development branch. Not sure if it just defaults to all targets then?

github-actions[bot]
github-actions bot previously approved these changes Jul 6, 2022
View reviewed changes
@larshg
Copy link
Copy Markdown
Contributor

larshg commented Jul 6, 2022

Still no import libraries (.lib):
image

@dg0yt
Copy link
Copy Markdown
Contributor

dg0yt commented Jul 6, 2022

No exported symbols?

@Adela0814
Copy link
Copy Markdown
Contributor Author

Adela0814 commented Jul 6, 2022

Still no import libraries (.lib): image

I'm fixing this, I will teel you if ready.

github-actions[bot]
github-actions bot previously approved these changes Jul 6, 2022
View reviewed changes
@larshg
Copy link
Copy Markdown
Contributor

larshg commented Jul 6, 2022

Got .lib now 😄 - but VTK still fails to find libharu:

-- Could NOT find LibHaru (missing: LibHaru_LIBRARY) (found suitable version "2.4.0-dev", minimum required is "2.4.0")
CMake Error at CMake/vtkModule.cmake:4228 (message):
  Could not find the LibHaru external dependency.
Call Stack (most recent call first):
  CMake/vtkModule.cmake:4784 (vtk_module_find_package)
  CMake/vtkModule.cmake:4655 (vtk_module_third_party_external)
  ThirdParty/libharu/CMakeLists.txt:1 (vtk_module_third_party)

github-actions[bot]
github-actions bot previously approved these changes Jul 7, 2022
View reviewed changes
@Adela0814
Copy link
Copy Markdown
Contributor Author

Adela0814 commented Jul 7, 2022

To do: update vtk port (fix FindLibHaru.cmake).

dg0yt
dg0yt reviewed Jul 7, 2022
View reviewed changes
@Adela0814 Adela0814 mentioned this pull request Jul 8, 2022
Closed
@JonLiu1993 JonLiu1993 mentioned this pull request Jul 8, 2022
Closed
@Adela0814 Adela0814 requested a review from JackBoosY July 8, 2022 06:12
@JackBoosY JackBoosY changed the title [libharu] update to 2.4.0-rc1 [vcpkg baseline][libharu] update to 2.4.0-rc1 Jul 8, 2022
@Adela0814 Adela0814 marked this pull request as ready for review July 8, 2022 07:08
@Adela0814
Copy link
Copy Markdown
Contributor Author

Adela0814 commented Jul 8, 2022

@larshg Please try the latest commit.

@Adela0814 Adela0814 added the category:port-bug The issue is with a library, which is something the port should already support label Jul 8, 2022
@larshg
Copy link
Copy Markdown
Contributor

larshg commented Jul 8, 2022

@larshg Please try the latest commit.

Already did and it build succesfully 👍

JackBoosY
JackBoosY suggested changes Jul 8, 2022
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Jul 8, 2022
View reviewed changes
JackBoosY
JackBoosY suggested changes Jul 8, 2022
View reviewed changes
@MCJack123 MCJack123 mentioned this pull request Jul 12, 2022
Merged
github-actions[bot]
github-actions bot previously approved these changes Jul 12, 2022
View reviewed changes
JackBoosY
JackBoosY suggested changes Jul 12, 2022
View reviewed changes
@Adela0814 Adela0814 requested a review from JackBoosY July 13, 2022 01:11
@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jul 13, 2022
@vicroms vicroms merged commit 72cdfe2 into microsoft:master Jul 13, 2022
@JonLiu1993 JonLiu1993 mentioned this pull request Jul 21, 2022
Closed
@xuqiancheng xuqiancheng mentioned this pull request Sep 19, 2022
Merged
@njakob njakob mentioned this pull request Jan 2, 2023
Merged
@Adela0814 Adela0814 deleted the Dev/Mengna/libharu branch January 16, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

+2 more reviewers

@dg0yt dg0yt dg0yt left review comments

@JackBoosY JackBoosY JackBoosY approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Cheney-W Cheney-W

@JackBoosY JackBoosY

Labels

category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[libharu] build failure - File does not have the expected hash

7 participants

@Adela0814 @larshg @dg0yt @JackBoosY @vicroms @Cheney-W @Mengna-Li