[OpenCV] update to v4.6.0 by cenit · Pull Request #25431 · microsoft/vcpkg

cenit · 2022-06-25T10:18:42Z

Which triplets are supported/not supported? Have you updated the CI baseline?

all, yes
Does your PR follow the maintainer guide?

yes
If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

yes

FrankXie05 · 2022-06-27T06:17:31Z

Logs from x64-windows :

D:\buildtrees\opencv4\src\4.6.0-b3a3e01510.clean\modules\sfm\src\libmv_light\libmv\simple_pipeline\bundle.cc(552): error C2664: 'void ceres::Problem::SetParameterization(double *,ceres::LocalParameterization *)': cannot convert argument 2 from 'ceres::SubsetManifold *' to 'ceres::LocalParameterization *'
D:\buildtrees\opencv4\src\4.6.0-b3a3e01510.clean\modules\sfm\src\libmv_light\libmv\simple_pipeline\bundle.cc(553): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast

install-x64-windows-dbg-out.log

github-actions

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/libharu/vcpkg.json

Valid values for the license field can be found in the documentation

cenit · 2022-06-27T13:30:54Z

@BillyONeal error on osx is the following:

Building libharu[core,notiffsymbols]:x64-osx...
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:14 (message):
  

  File does not have expected hash:

          File path: [ /Users/vagrant/Data/downloads/libharu-shading-pr-157.patch ]
      Expected hash: [ 10562c8c9c6975b74d625912e7d3b850376941d5e46136679371ce1315f416b6b8e91d73fd1257b907327b2d71d50b8c026547203f280e42fb7b1901245de03c ]
        Actual hash: [ f2ddb22b54b4eccc79400b6a4b2d245a221898f75456a5a559523eab7a523a87dfc5dfd0ec5fb17a771697e03c7ea6ed4c6095eff73e0a4302cd6eb24584c957 ]

  The cached file SHA512 doesn't match.  The file may have been corrupted.
  To re-download this file please delete cached file at path
  /Users/vagrant/Data/downloads/libharu-shading-pr-157.patch and retry.

Call Stack (most recent call first):
  scripts/cmake/vcpkg_download_distfile.cmake:171 (z_vcpkg_download_distfile_test_hash)
  ports/libharu/portfile.cmake:6 (vcpkg_download_distfile)
  scripts/ports.cmake:146 (include)


error: building libharu:x64-osx failed with: BUILD_FAILED

it looks like the osx pipeline is not cleaning the downloads folder??

BillyONeal · 2022-06-27T18:03:42Z

it looks like the osx pipeline is not cleaning the downloads folder??

They shouldn't clear the downloads folder because users don't clear downloads folders either. We should change the name of the file for the new SHA.

github-actions

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/opencv/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/opencv/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/opencv/vcpkg.json
scripts/test_ports/vcpkg-ci-opencv/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/opencv/vcpkg.json
scripts/test_ports/vcpkg-ci-opencv/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for opencv4 have changed but the version was not updated
version: 4.6.0
old SHA: fbe591743e0340229f0e9fc6132f8af8736705e6
new SHA: bbd5a8949435a95137f7970fb734f3e18cd9ceb0
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for opencv2 have changed but the version was not updated
version: 2.4.13.7#14
old SHA: b89a2a7aa58c1d70a0f36db3618570dfb899330e
new SHA: 83cd03cdf262a9ecd38df7c585edd83f3cbbec4e
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/opencv/vcpkg.json
scripts/test_ports/vcpkg-ci-opencv/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/opencv/vcpkg.json
scripts/test_ports/vcpkg-ci-opencv/vcpkg.json

Valid values for the license field can be found in the documentation

cenit · 2022-07-29T10:47:46Z

somehow I lost some commits that fixed problems highlighted by github actions bot

github-actions

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/dbow3/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/dbow3/vcpkg.json
ports/opencv/vcpkg.json
ports/rtabmap/vcpkg.json

Valid values for the license field can be found in the documentation

ras0219-msft · 2022-07-30T05:05:01Z

Hmm, looks like a patch failure?

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for opencv4 have changed but the version was not updated
version: 4.6.0
old SHA: d899e0fe819a033d94f41acddcdd2a6232217bd0
new SHA: 1ff543272c91a32d242ad5320e9ca63b29b34ed2
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/dbow3/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/dbow3/vcpkg.json
ports/opencv/vcpkg.json
ports/rtabmap/vcpkg.json

Valid values for the license field can be found in the documentation

* Update opencv4.json * fix github-actions issues * formating vcpkg.json * update git-trees

cenit · 2022-08-03T13:16:16Z

Hmm, looks like a patch failure?

should be fixed now

BillyONeal

Can you submit upstream PRs for most of these patches? They generally don't seem to be vcpkg-specific.

BillyONeal · 2022-08-05T00:12:15Z

ports/cctag/0001-fix-osx.patch

+ #ifndef _CCTAG_EXCEPTIONS_HPP_
+ #define _CCTAG_EXCEPTIONS_HPP_
+-
+#define _GNU_SOURCE


Can you please submit a PR to https://github.com/alicevision/CCTag ?

BillyONeal · 2022-08-05T00:14:52Z

ports/opencv2/portfile.cmake

+    message("/usr/bin/python2 get-pip.py")
+    message("and finally")
+    message("pip install virtualenv")
+    message("On some system, these commands must be run as root, otherwise error about virtualenv module missing will persist!")


Suggested change

message("On some system, these commands must be run as root, otherwise error about virtualenv module missing will persist!")

message("On some systems, these commands must be run as root, otherwise error about virtualenv module missing will persist!")

BillyONeal · 2022-08-05T00:20:18Z

ports/vcpkg-get-python-packages/x_vcpkg_get_python_packages.cmake

+                    vcpkg_execute_required_process(COMMAND "${arg_PYTHON_EXECUTABLE}" "${PYFILE_PATH}/public/get-pip.py" --no-warn-script-location
+                                                   WORKING_DIRECTORY "${CURRENT_BUILDTREES_DIR}"
+                                                   LOGNAME "get-pip-${TARGET_TRIPLET}")
+                elseif(arg_PYTHON_VERSION STREQUAL 2)


:sigh: I'm not going to completely block over this but I hate doing anything in support of something that's irresponsible to use because it's out of support for 2 years.

BillyONeal · 2022-08-05T00:22:02Z

Thanks for the update :)

github-actions bot previously approved these changes Jun 25, 2022

View reviewed changes

JonLiu1993 assigned FrankXie05 Jun 27, 2022

FrankXie05 added the category:port-update The issue is with a library, which is requesting update new revision label Jun 27, 2022

cenit dismissed github-actions[bot]’s stale review via e373c1d June 27, 2022 08:25

github-actions bot previously approved these changes Jun 27, 2022

View reviewed changes

cenit dismissed github-actions[bot]’s stale review via 0a43925 June 27, 2022 08:29

github-actions bot previously approved these changes Jun 27, 2022

View reviewed changes

cenit dismissed github-actions[bot]’s stale review via 1cdcbfa June 27, 2022 09:27

github-actions bot previously approved these changes Jun 27, 2022

View reviewed changes

cenit dismissed github-actions[bot]’s stale review via dbf95ad June 27, 2022 09:35

github-actions bot previously approved these changes Jun 27, 2022

View reviewed changes

cenit dismissed github-actions[bot]’s stale review via f9967d9 June 28, 2022 06:37

github-actions bot previously approved these changes Jun 28, 2022

View reviewed changes

cenit dismissed github-actions[bot]’s stale review via 8f4a2ee June 28, 2022 12:15

github-actions bot previously approved these changes Jun 28, 2022

View reviewed changes

cenit dismissed github-actions[bot]’s stale review via 8f3bd4a June 28, 2022 14:18

github-actions bot previously approved these changes Jun 28, 2022

View reviewed changes

cenit dismissed github-actions[bot]’s stale review via d94a64d June 28, 2022 14:32

github-actions bot previously approved these changes Jun 28, 2022

View reviewed changes

cenit dismissed github-actions[bot]’s stale review via 278c325 June 28, 2022 15:24

github-actions bot previously approved these changes Jun 28, 2022

View reviewed changes

cenit dismissed github-actions[bot]’s stale review via 8d91bdf June 28, 2022 16:31

github-actions bot previously approved these changes Jun 28, 2022

View reviewed changes

cenit dismissed github-actions[bot]’s stale review via c926bae June 30, 2022 06:36

github-actions bot requested changes Jun 30, 2022

View reviewed changes

github-actions bot previously approved these changes Jun 30, 2022

View reviewed changes

cenit dismissed github-actions[bot]’s stale review via b2614ef June 30, 2022 10:34

cenit dismissed github-actions[bot]’s stale review via acafe22 July 29, 2022 10:47

github-actions bot previously approved these changes Jul 29, 2022

View reviewed changes

Cheney-W added requires:author-response and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Aug 1, 2022

Thieum and others added 2 commits August 1, 2022 09:49

wrong checksum (tested on windows)

5548908

Merge pull request #1 from Thieum/dev/cenit/opencv460

68c5976

cenit dismissed github-actions[bot]’s stale review via 68c5976 August 1, 2022 21:57

github-actions bot requested changes Aug 1, 2022

View reviewed changes

Github-actions fixes (#2)

f78c640

* Update opencv4.json * fix github-actions issues * formating vcpkg.json * update git-trees

github-actions bot previously approved these changes Aug 3, 2022

View reviewed changes

cenit added 2 commits August 3, 2022 08:52

fix rtabmap license

eabea69

fix references

f441d53

cenit dismissed github-actions[bot]’s stale review via f441d53 August 3, 2022 06:55

github-actions bot previously approved these changes Aug 3, 2022

View reviewed changes

cenit added 2 commits August 3, 2022 08:58

fix also dbow3 license

83fe792

fix references

782e97c

github-actions bot approved these changes Aug 3, 2022

View reviewed changes

Merge branch 'master' into dev/cenit/opencv460

e9ec2c6

github-actions bot previously approved these changes Aug 3, 2022

View reviewed changes

cenit added 2 commits August 3, 2022 15:43

[cctag] remove unnecessary patch section

f21bc69

fix references

7890b7c

github-actions bot approved these changes Aug 3, 2022

View reviewed changes

BillyONeal approved these changes Aug 5, 2022

View reviewed changes

This was referenced Oct 20, 2022

[opencv4] Build the opencv4 with the MinGW compiler. #25775

Closed

Building package opencv4:x64-mingw-dynamic/static failed with: BUILD_FAILED #25492

Closed

dg0yt mentioned this pull request Aug 13, 2024

[opencv] update to 4.9 #38928

Merged

7 tasks

	message("On some system, these commands must be run as root, otherwise error about virtualenv module missing will persist!")
	message("On some systems, these commands must be run as root, otherwise error about virtualenv module missing will persist!")

Conversation

cenit commented Jun 25, 2022

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Uh oh!

FrankXie05 commented Jun 27, 2022

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

cenit commented Jun 27, 2022

Uh oh!

BillyONeal commented Jun 27, 2022

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

cenit commented Jul 29, 2022

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

ras0219-msft commented Jul 30, 2022

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

cenit commented Aug 3, 2022

Uh oh!

BillyONeal left a comment

Choose a reason for hiding this comment

Uh oh!

BillyONeal Aug 5, 2022

Choose a reason for hiding this comment

Uh oh!

BillyONeal Aug 5, 2022

Choose a reason for hiding this comment

Uh oh!

BillyONeal Aug 5, 2022

Choose a reason for hiding this comment

Uh oh!

BillyONeal commented Aug 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?