[harfbuzz] Fix CMake config#25092
Merged
ras0219-msft merged 4 commits intomicrosoft:masterfrom Jun 8, 2022
Merged
Conversation
ras0219-msft
approved these changes
Jun 6, 2022
JonLiu1993
approved these changes
Jun 8, 2022
ras0219-msft
approved these changes
Jun 8, 2022
Contributor
|
Thanks! This was really annoying -- so happy to see it fixed :) |
|
Perfect, it works like a charm, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does your PR fix?
Fixes [harfbuzz] Regression: Cannot set "HARFBUZZ_LIBRARY": current scope has no parent #23694. Alternative to [harfbuzz] Remove PARENT_SCOPE in harfbuzzConfig.cmake.in #23709.
This is my minimal version of the fix. The config provides variables likes a find module. Some of these variables should be set as (global) cache variables, some should always be set because they are scoped. Only the target can be skipped if it already exists.
(Note: Trying to complement this port with a test port indicates that the config still needs significant work to be complete, so I decided to only offer a minimal fix now. Even
FindICU.cmakedoesn't provide release+debug config or transitive usage requirements. And the provided config is "unofficial" - there is a semi-deprecated official config which provides additonal targets.)Which triplets are supported/not supported? Have you updated the CI baseline?
unchanged
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?yes