Skip to content

[openssl] Fix build for Android x86.#24801

Closed
AenBleidd wants to merge 3 commits intomicrosoft:masterfrom
AenBleidd:vko_fix_openssl3_issue_on_android_x86
Closed

[openssl] Fix build for Android x86.#24801
AenBleidd wants to merge 3 commits intomicrosoft:masterfrom
AenBleidd:vko_fix_openssl3_issue_on_android_x86

Conversation

@AenBleidd
Copy link
Copy Markdown
Contributor

@AenBleidd AenBleidd commented May 19, 2022

OpenSSL3 uses atomics that are broken on clang for Android x86.
This commit fixes the build by disabling usage of these atomics on Android x86 only.

This fixes #24021.

Signed-off-by: Vitalii Koshura lestat.de.lionkur@gmail.com

@AenBleidd
[openssl] Fix build for Android x86.
bd7f0fc 
OpenSSL3 uses atomics that are broken on clang for Android x86.
This commit fixes the build by disabling usage of these atomics on Android x86 only.

This fixes microsoft#24021.

Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
@AenBleidd
Copy link
Copy Markdown
Contributor Author

AenBleidd commented May 19, 2022

This PR is tested using overlay ports here: BOINC/boinc#4749

@AenBleidd AenBleidd mentioned this pull request May 19, 2022
Closed
@Adela0814 Adela0814 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. labels May 20, 2022
@talregev
Copy link
Copy Markdown
Contributor

talregev commented May 20, 2022

follow

@talregev talregev mentioned this pull request May 20, 2022
Closed
2 tasks
github-actions[bot]
github-actions bot requested changes May 20, 2022
View reviewed changes
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for openssl have changed but the version was not updated
version: 3.0.3#3
old SHA: f72e602e3fde9d592c2f8d01c4ca0ed21c4df63b
new SHA: 03f8e7e77fd71aaf31af19896c07deaa58b02662
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@talregev
Copy link
Copy Markdown
Contributor

talregev commented May 20, 2022

Please hold for this fix. I want to investigate another solution.
@AenBleidd Can you put this PR on draft? Thank you.

talregev
talregev suggested changes May 20, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@talregev talregev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another solution for update the ndk version (the clang version) and it solve the bug.
@AenBleidd please put this PR on draft.

@AenBleidd
Copy link
Copy Markdown
Contributor Author

AenBleidd commented May 20, 2022

@BillyONeal, sorry for 'not nice' words. Didn't know you have such a policy. Next time I'll try to be more polite.
@talregev, I remember I tried with NDK update, and failed, but of course you can try again. Previous build took 11 hours, so you have enough time to test your fix

@talregev
Copy link
Copy Markdown
Contributor

talregev commented May 20, 2022

@BillyONeal, sorry for 'not nice' words. Didn't know you have such a policy. Next time I'll try to be more polite. @talregev, I remember I tried with NDK update, and failed, but of course you can try again. Previous build took 11 hours, so you have enough time to test your fix

Please review my PR:
BOINC/boinc#4751

@talregev
Copy link
Copy Markdown
Contributor

talregev commented May 20, 2022

@BillyONeal, sorry for 'not nice' words. Didn't know you have such a policy. Next time I'll try to be more polite. @talregev, I remember I tried with NDK update, and failed, but of course you can try again. Previous build took 11 hours, so you have enough time to test your fix

Because of your comment I understand the problem.

@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented May 20, 2022

@BillyONeal, sorry for 'not nice' words.

No problem!

@talregev
Copy link
Copy Markdown
Contributor

talregev commented May 20, 2022 •
edited
Loading

@BillyONeal, sorry for 'not nice' words. Didn't know you have such a policy. Next time I'll try to be more polite. @talregev, I remember I tried with NDK update, and failed, but of course you can try again. Previous build took 11 hours, so you have enough time to test your fix

I fix #24021 issue in this PR BOINC/boinc#4751 without this PR fix.

@AenBleidd
Copy link
Copy Markdown
Contributor Author

AenBleidd commented May 20, 2022

@talregev, congratulations with the fix.
@BillyONeal, I'm closing this PR because looks like my previous assumption was not correct and tests were not correct either. I was just using an NDK with an incomplete implementation of atomics for x86.

@AenBleidd AenBleidd closed this May 20, 2022
@AenBleidd AenBleidd deleted the vko_fix_openssl3_issue_on_android_x86 branch May 20, 2022 22:55
@AenBleidd AenBleidd mentioned this pull request May 20, 2022
Closed
@rami3l rami3l mentioned this pull request Feb 11, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

+2 more reviewers

@talregev talregev talregev requested changes

@Adela0814 Adela0814 Adela0814 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Adela0814 Adela0814

Labels

category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[openssl] build failure on Android x86

4 participants

@AenBleidd @talregev @BillyONeal @Adela0814