[opensubdiv] Various improvements#24467
[opensubdiv] Various improvements#24467theblackunknown wants to merge 4 commits intomicrosoft:masterfrom
Conversation
|
|
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where you should check the license field.
Details
If you feel able to do so, please consider adding a "license" field to the following files:
ports/opensubdiv/vcpkg.json
Valid values for the license field can be found in the documentation
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where you should check the license field.
Details
If you feel able to do so, please consider adding a "license" field to the following files:
ports/opensubdiv/vcpkg.json
Valid values for the license field can be found in the documentation
|
Did something changed recently about the CLA ? Something strange is that it says that the open source projects if affiliated to SAP which I though |
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for opensubdiv but no changes to version or port version.
-- Version: 3.4.3#5
-- Old SHA: c0d413da81ccb867d4498ea4220616a6270d3dab
-- New SHA: 5400fa1040be46057990dba7cb9253b3cb558530
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
You have modified or added at least one vcpkg.json where you should check the license field.
Details
If you feel able to do so, please consider adding a "license" field to the following files:
ports/opensubdiv/vcpkg.json
Valid values for the license field can be found in the documentation
c9b527f to
bfe9580
Compare
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where you should check the license field.
Details
If you feel able to do so, please consider adding a "license" field to the following files:
ports/opensubdiv/vcpkg.json
Valid values for the license field can be found in the documentation
|
@LilyWangL @Adela0814 Thansk for having a look at this PR. |
|
I am closing this PR due to the strange error about CLA check, I have opened #24615 which supersed this one |
Describe the pull request
What does your PR fix?
This PR:
openglfeature toopensubdivto support OpenGL backend.Which triplets are supported/not supported? Have you updated the CI baseline?
all, No
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/