[toolchain windows] set CMAKE_SYSTEM_PROCESSOR by strega-nil-ms · Pull Request #24100 · microsoft/vcpkg

strega-nil-ms · 2022-04-12T16:39:02Z

In specific, I did this for the cpuinfo PR (#23944) - I realized the reason
that cpuinfo doesn't support arm64 windows cross compilation is because
we don't set CMAKE_SYSTEM_PROCESSOR.

This is based on @Neumann-A's #16111, but is updated and simplified.

Neumann-A · 2022-04-12T17:17:16Z

This won't set CMAKE_CROSSCOMPILING correctly so configure checks are still probably wrong

Neumann-A · 2022-04-13T11:07:21Z

Yeah and CI agrees to not set CMAKE_SYSTEM_NAME if it is on a native platform ;)
You don't want to force CMAKE_CROSSCOMPILING in all cases.

scripts/toolchains/windows.cmake

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff

diff --git a/ports/corrade/vcpkg.json b/ports/corrade/vcpkg.json
index 750e9be..17c71da 100644
--- a/ports/corrade/vcpkg.json
+++ b/ports/corrade/vcpkg.json
@@ -9,7 +9,9 @@
       "name": "corrade",
       "host": true,
       "default-features": false,
-      "features": [ "utility" ]
+      "features": [
+        "utility"
+      ]
     }
   ],
   "default-features": [

Use the version scheme "version-date" instead of "version-string" in port "ampl-mp".

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout e3d79356af3e224222af88558b3201a46c4e5598 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/a-/ampl-mp.json b/versions/a-/ampl-mp.json
index f10ce12..f0f0a41 100644
--- a/versions/a-/ampl-mp.json
+++ b/versions/a-/ampl-mp.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "1d951708b2e6ee8011c08b0a133b28a9d460ef26",
+      "version-string": "2020-11-11",
+      "port-version": 3
+    },
     {
       "git-tree": "d52dd1ac4a69a74bb658b52be36c7457ca6049ef",
       "version-string": "2020-11-11",
diff --git a/versions/baseline.json b/versions/baseline.json
index dc7d7dd..cf78a60 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -70,7 +70,7 @@
     },
     "ampl-mp": {
       "baseline": "2020-11-11",
-      "port-version": 2
+      "port-version": 3
     },
     "amqpcpp": {
       "baseline": "4.3.15",
@@ -1218,7 +1218,7 @@
     },
     "caf": {
       "baseline": "0.18.5",
-      "port-version": 0
+      "port-version": 1
     },
     "caffe2": {
       "baseline": "0.8.1",
@@ -1546,7 +1546,7 @@
     },
     "corrade": {
       "baseline": "2020.06",
-      "port-version": 3
+      "port-version": 4
     },
     "cpp-base64": {
       "baseline": "V2.rc.08",
@@ -2246,7 +2246,7 @@
     },
     "fltk": {
       "baseline": "1.3.8",
-      "port-version": 1
+      "port-version": 2
     },
     "fluidlite": {
       "baseline": "2020-08-27",
diff --git a/versions/c-/caf.json b/versions/c-/caf.json
index 7e81e9e..a3f9dc4 100644
--- a/versions/c-/caf.json
+++ b/versions/c-/caf.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "6a7204110249a48fad125404b795f01c3734470b",
+      "version": "0.18.5",
+      "port-version": 1
+    },
     {
       "git-tree": "6f4b297fc5ad4bd021fa9d72787b27e69a558237",
       "version": "0.18.5",
diff --git a/versions/c-/corrade.json b/versions/c-/corrade.json
index 6a1a88a..9b14d21 100644
--- a/versions/c-/corrade.json
+++ b/versions/c-/corrade.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "a9dd31a865e16cef7d05c7f610cfefe9e9cc683c",
+      "version-string": "2020.06",
+      "port-version": 4
+    },
     {
       "git-tree": "087770e2a196c44cb1b56473bd57797ed9b9bc87",
       "version-string": "2020.06",
diff --git a/versions/f-/fltk.json b/versions/f-/fltk.json
index 07d0695..96d9824 100644
--- a/versions/f-/fltk.json
+++ b/versions/f-/fltk.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "67f9090df208862fcd949bfae2214dd5fb0a3157",
+      "version": "1.3.8",
+      "port-version": 2
+    },
     {
       "git-tree": "86da5d186aa27c3a6a9a9903eaa2806edde44bd8",
       "version": "1.3.8",

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/corrade/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/ampl-mp/vcpkg.json
ports/caf/vcpkg.json
ports/corrade/vcpkg.json
ports/fltk/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff

diff --git a/ports/corrade/vcpkg.json b/ports/corrade/vcpkg.json
index 750e9be..17c71da 100644
--- a/ports/corrade/vcpkg.json
+++ b/ports/corrade/vcpkg.json
@@ -9,7 +9,9 @@
       "name": "corrade",
       "host": true,
       "default-features": false,
-      "features": [ "utility" ]
+      "features": [
+        "utility"
+      ]
     }
   ],
   "default-features": [

Use the version scheme "version-date" instead of "version-string" in port "ampl-mp".

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout e3d79356af3e224222af88558b3201a46c4e5598 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/a-/ampl-mp.json b/versions/a-/ampl-mp.json
index f10ce12..f0f0a41 100644
--- a/versions/a-/ampl-mp.json
+++ b/versions/a-/ampl-mp.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "1d951708b2e6ee8011c08b0a133b28a9d460ef26",
+      "version-string": "2020-11-11",
+      "port-version": 3
+    },
     {
       "git-tree": "d52dd1ac4a69a74bb658b52be36c7457ca6049ef",
       "version-string": "2020-11-11",
diff --git a/versions/baseline.json b/versions/baseline.json
index dc7d7dd..9ed9906 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -70,7 +70,7 @@
     },
     "ampl-mp": {
       "baseline": "2020-11-11",
-      "port-version": 2
+      "port-version": 3
     },
     "amqpcpp": {
       "baseline": "4.3.15",
@@ -1218,7 +1218,7 @@
     },
     "caf": {
       "baseline": "0.18.5",
-      "port-version": 0
+      "port-version": 1
     },
     "caffe2": {
       "baseline": "0.8.1",
@@ -1546,7 +1546,7 @@
     },
     "corrade": {
       "baseline": "2020.06",
-      "port-version": 3
+      "port-version": 4
     },
     "cpp-base64": {
       "baseline": "V2.rc.08",
@@ -2246,7 +2246,7 @@
     },
     "fltk": {
       "baseline": "1.3.8",
-      "port-version": 1
+      "port-version": 2
     },
     "fluidlite": {
       "baseline": "2020-08-27",
@@ -2394,7 +2394,7 @@
     },
     "gainput": {
       "baseline": "1.0.0",
-      "port-version": 5
+      "port-version": 6
     },
     "gamedev-framework": {
       "baseline": "0.20.0",
@@ -2550,7 +2550,7 @@
     },
     "glog": {
       "baseline": "0.5.0",
-      "port-version": 0
+      "port-version": 1
     },
     "gloo": {
       "baseline": "20201203",
@@ -4390,7 +4390,7 @@
     },
     "mapnik": {
       "baseline": "2022-01-28",
-      "port-version": 1
+      "port-version": 2
     },
     "marble": {
       "baseline": "19.08.2",
@@ -5222,7 +5222,7 @@
     },
     "orc": {
       "baseline": "1.6.4",
-      "port-version": 2
+      "port-version": 3
     },
     "orocos-kdl": {
       "baseline": "1.4",
@@ -6398,7 +6398,7 @@
     },
     "seal": {
       "baseline": "3.7.2",
-      "port-version": 2
+      "port-version": 3
     },
     "secp256k1": {
       "baseline": "2017-19-10",
@@ -7510,7 +7510,7 @@
     },
     "wxwidgets": {
       "baseline": "3.1.5",
-      "port-version": 8
+      "port-version": 9
     },
     "x-plane": {
       "baseline": "3.0.3",
diff --git a/versions/c-/caf.json b/versions/c-/caf.json
index 7e81e9e..a3f9dc4 100644
--- a/versions/c-/caf.json
+++ b/versions/c-/caf.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "6a7204110249a48fad125404b795f01c3734470b",
+      "version": "0.18.5",
+      "port-version": 1
+    },
     {
       "git-tree": "6f4b297fc5ad4bd021fa9d72787b27e69a558237",
       "version": "0.18.5",
diff --git a/versions/c-/corrade.json b/versions/c-/corrade.json
index 6a1a88a..9b14d21 100644
--- a/versions/c-/corrade.json
+++ b/versions/c-/corrade.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "a9dd31a865e16cef7d05c7f610cfefe9e9cc683c",
+      "version-string": "2020.06",
+      "port-version": 4
+    },
     {
       "git-tree": "087770e2a196c44cb1b56473bd57797ed9b9bc87",
       "version-string": "2020.06",
diff --git a/versions/f-/fltk.json b/versions/f-/fltk.json
index 07d0695..96d9824 100644
--- a/versions/f-/fltk.json
+++ b/versions/f-/fltk.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "67f9090df208862fcd949bfae2214dd5fb0a3157",
+      "version": "1.3.8",
+      "port-version": 2
+    },
     {
       "git-tree": "86da5d186aa27c3a6a9a9903eaa2806edde44bd8",
       "version": "1.3.8",
diff --git a/versions/g-/gainput.json b/versions/g-/gainput.json
index 9ce5b1b..d23cb9d 100644
--- a/versions/g-/gainput.json
+++ b/versions/g-/gainput.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "d7d03d82f8c42466bcd155b94e0dcefa79763931",
+      "version": "1.0.0",
+      "port-version": 6
+    },
     {
       "git-tree": "6edb146db254b1cec192c12f335bef0e54455770",
       "version": "1.0.0",
diff --git a/versions/g-/glog.json b/versions/g-/glog.json
index b34d373..3013a90 100644
--- a/versions/g-/glog.json
+++ b/versions/g-/glog.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "ce445bc76dba490e663352328addd51963c78bcb",
+      "version": "0.5.0",
+      "port-version": 1
+    },
     {
       "git-tree": "55b03c1cae45ba6b081c9072e6431d720467c82b",
       "version": "0.5.0",
diff --git a/versions/m-/mapnik.json b/versions/m-/mapnik.json
index 19ea139..7f11caf 100644
--- a/versions/m-/mapnik.json
+++ b/versions/m-/mapnik.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "dd7ab22238efd828be89e8e17677aa5b395ac07b",
+      "version-date": "2022-01-28",
+      "port-version": 2
+    },
     {
       "git-tree": "ab089220fb5ecc215804a68c2122d3e0d3ed58bc",
       "version-date": "2022-01-28",
diff --git a/versions/o-/orc.json b/versions/o-/orc.json
index 23e58df..d7f414b 100644
--- a/versions/o-/orc.json
+++ b/versions/o-/orc.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "fd719ab20f150796b63d3984636e89b6301d4a58",
+      "version-string": "1.6.4",
+      "port-version": 3
+    },
     {
       "git-tree": "8cd78baa4d8b7df9077f76b8f5d600aac6e09716",
       "version-string": "1.6.4",
diff --git a/versions/s-/seal.json b/versions/s-/seal.json
index 5fd1786..c7ea117 100644
--- a/versions/s-/seal.json
+++ b/versions/s-/seal.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "323502a09f055a964f6b501aed82701570b96cba",
+      "version-semver": "3.7.2",
+      "port-version": 3
+    },
     {
       "git-tree": "c3499eaa1c19049bc521c3d2799d8d7d6d032a8a",
       "version-semver": "3.7.2",
diff --git a/versions/w-/wxwidgets.json b/versions/w-/wxwidgets.json
index ec84429..b1e3aff 100644
--- a/versions/w-/wxwidgets.json
+++ b/versions/w-/wxwidgets.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "c84960c796cf15517384bff719305417fc15bf69",
+      "version-semver": "3.1.5",
+      "port-version": 9
+    },
     {
       "git-tree": "dba058c37782edf771e7a62ae1bef98274c86b9f",
       "version-semver": "3.1.5",

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/corrade/portfile.cmake
ports/orc/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/ampl-mp/vcpkg.json
ports/caf/vcpkg.json
ports/corrade/vcpkg.json
ports/fltk/vcpkg.json
ports/orc/vcpkg.json
ports/seal/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout e3d79356af3e224222af88558b3201a46c4e5598 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index e077bc1..9ed9906 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6398,7 +6398,7 @@
     },
     "seal": {
       "baseline": "3.7.2",
-      "port-version": 2
+      "port-version": 3
     },
     "secp256k1": {
       "baseline": "2017-19-10",
@@ -7510,7 +7510,7 @@
     },
     "wxwidgets": {
       "baseline": "3.1.5",
-      "port-version": 8
+      "port-version": 9
     },
     "x-plane": {
       "baseline": "3.0.3",
diff --git a/versions/s-/seal.json b/versions/s-/seal.json
index 5fd1786..c7ea117 100644
--- a/versions/s-/seal.json
+++ b/versions/s-/seal.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "323502a09f055a964f6b501aed82701570b96cba",
+      "version-semver": "3.7.2",
+      "port-version": 3
+    },
     {
       "git-tree": "c3499eaa1c19049bc521c3d2799d8d7d6d032a8a",
       "version-semver": "3.7.2",
diff --git a/versions/w-/wxwidgets.json b/versions/w-/wxwidgets.json
index ec84429..b1e3aff 100644
--- a/versions/w-/wxwidgets.json
+++ b/versions/w-/wxwidgets.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "c84960c796cf15517384bff719305417fc15bf69",
+      "version-semver": "3.1.5",
+      "port-version": 9
+    },
     {
       "git-tree": "dba058c37782edf771e7a62ae1bef98274c86b9f",
       "version-semver": "3.1.5",

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/corrade/portfile.cmake
ports/orc/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/ampl-mp/vcpkg.json
ports/caf/vcpkg.json
ports/corrade/vcpkg.json
ports/fltk/vcpkg.json
ports/orc/vcpkg.json
ports/seal/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout aebb363eaa0b658beb19cbefdd5aa2f9cbc14f1e -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 5488380..8f2ad9d 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6398,7 +6398,7 @@
     },
     "seal": {
       "baseline": "3.7.2",
-      "port-version": 2
+      "port-version": 3
     },
     "secp256k1": {
       "baseline": "2017-19-10",
@@ -7510,7 +7510,7 @@
     },
     "wxwidgets": {
       "baseline": "3.1.5",
-      "port-version": 8
+      "port-version": 9
     },
     "x-plane": {
       "baseline": "3.0.3",
diff --git a/versions/s-/seal.json b/versions/s-/seal.json
index 5fd1786..c7ea117 100644
--- a/versions/s-/seal.json
+++ b/versions/s-/seal.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "323502a09f055a964f6b501aed82701570b96cba",
+      "version-semver": "3.7.2",
+      "port-version": 3
+    },
     {
       "git-tree": "c3499eaa1c19049bc521c3d2799d8d7d6d032a8a",
       "version-semver": "3.7.2",
diff --git a/versions/w-/wxwidgets.json b/versions/w-/wxwidgets.json
index ec84429..b1e3aff 100644
--- a/versions/w-/wxwidgets.json
+++ b/versions/w-/wxwidgets.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "c84960c796cf15517384bff719305417fc15bf69",
+      "version-semver": "3.1.5",
+      "port-version": 9
+    },
     {
       "git-tree": "dba058c37782edf771e7a62ae1bef98274c86b9f",
       "version-semver": "3.1.5",

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/corrade/portfile.cmake
ports/orc/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/ampl-mp/vcpkg.json
ports/caf/vcpkg.json
ports/corrade/vcpkg.json
ports/fltk/vcpkg.json
ports/orc/vcpkg.json
ports/seal/vcpkg.json

Valid values for the license field can be found in the documentation

dg0yt · 2022-04-16T06:32:55Z

scripts/toolchains/windows.cmake

In general, CMAKE_CROSSCOMPILING is a normal variable, not a cache variable.

It's a cache variable in other toolchains so I kept it the same

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 48d15f4db6593ec677a9e0625537d227b308b4d5 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 8a5d09e..d766308 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6398,7 +6398,7 @@
     },
     "seal": {
       "baseline": "3.7.2",
-      "port-version": 2
+      "port-version": 3
     },
     "secp256k1": {
       "baseline": "2017-19-10",
diff --git a/versions/s-/seal.json b/versions/s-/seal.json
index 5fd1786..c7ea117 100644
--- a/versions/s-/seal.json
+++ b/versions/s-/seal.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "323502a09f055a964f6b501aed82701570b96cba",
+      "version-semver": "3.7.2",
+      "port-version": 3
+    },
     {
       "git-tree": "c3499eaa1c19049bc521c3d2799d8d7d6d032a8a",
       "version-semver": "3.7.2",

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/corrade/portfile.cmake
ports/orc/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/ampl-mp/vcpkg.json
ports/caf/vcpkg.json
ports/corrade/vcpkg.json
ports/fltk/vcpkg.json
ports/orc/vcpkg.json
ports/seal/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/corrade/portfile.cmake
ports/orc/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/ampl-mp/vcpkg.json
ports/caf/vcpkg.json
ports/corrade/vcpkg.json
ports/fltk/vcpkg.json
ports/orc/vcpkg.json
ports/seal/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/corrade/portfile.cmake
ports/orc/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/ampl-mp/vcpkg.json
ports/caf/vcpkg.json
ports/corrade/vcpkg.json
ports/fltk/vcpkg.json
ports/orc/vcpkg.json
ports/seal/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/corrade/portfile.cmake
ports/orc/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/ampl-mp/vcpkg.json
ports/caf/vcpkg.json
ports/corrade/vcpkg.json
ports/fltk/vcpkg.json
ports/orc/vcpkg.json
ports/seal/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/corrade/portfile.cmake
ports/orc/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/ampl-mp/vcpkg.json
ports/caf/vcpkg.json
ports/corrade/vcpkg.json
ports/fltk/vcpkg.json
ports/orc/vcpkg.json
ports/seal/vcpkg.json

Valid values for the license field can be found in the documentation

Neumann-A · 2022-04-19T22:20:32Z

versions/g-/glog.json

This seems wrong

@vicroms seems like we should catch this...

You probably passed --overwrite-version so it needs to be catched by the github bot.

yeah, I mean the gh bot should catch this

we should probably start running x-ci-verify-versions --verify-git-trees

github-actions

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/corrade/portfile.cmake
ports/orc/portfile.cmake
ports/vc/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/ampl-mp/vcpkg.json
ports/aom/vcpkg.json
ports/caf/vcpkg.json
ports/corrade/vcpkg.json
ports/fltk/vcpkg.json
ports/libhydrogen/vcpkg.json
ports/openblas/vcpkg.json
ports/orc/vcpkg.json
ports/pthreadpool/vcpkg.json
ports/seal/vcpkg.json
ports/vc/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/corrade/portfile.cmake
ports/orc/portfile.cmake
ports/vc/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/ampl-mp/vcpkg.json
ports/aom/vcpkg.json
ports/corrade/vcpkg.json
ports/fltk/vcpkg.json
ports/libhydrogen/vcpkg.json
ports/openblas/vcpkg.json
ports/orc/vcpkg.json
ports/pthreadpool/vcpkg.json
ports/seal/vcpkg.json
ports/vc/vcpkg.json

Valid values for the license field can be found in the documentation

# Conflicts: # versions/o-/orc.json

github-actions

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/corrade/portfile.cmake
ports/vc/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/ampl-mp/vcpkg.json
ports/aom/vcpkg.json
ports/corrade/vcpkg.json
ports/fltk/vcpkg.json
ports/libhydrogen/vcpkg.json
ports/openblas/vcpkg.json
ports/orc/vcpkg.json
ports/pthreadpool/vcpkg.json
ports/seal/vcpkg.json
ports/vc/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/corrade/portfile.cmake
ports/vc/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/ampl-mp/vcpkg.json
ports/aom/vcpkg.json
ports/corrade/vcpkg.json
ports/fltk/vcpkg.json
ports/libhydrogen/vcpkg.json
ports/openblas/vcpkg.json
ports/orc/vcpkg.json
ports/pthreadpool/vcpkg.json
ports/seal/vcpkg.json
ports/vc/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/corrade/portfile.cmake
ports/vc/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/ampl-mp/vcpkg.json
ports/aom/vcpkg.json
ports/corrade/vcpkg.json
ports/fltk/vcpkg.json
ports/libhydrogen/vcpkg.json
ports/openblas/vcpkg.json
ports/orc/vcpkg.json
ports/pthreadpool/vcpkg.json
ports/seal/vcpkg.json
ports/vc/vcpkg.json

Valid values for the license field can be found in the documentation

ports/corrade/portfile.cmake

Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>

ghost · 2022-04-29T04:06:32Z

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ strega-nil-ms sign now
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for corrade but no changes to version or port version.
-- Version: 2020.06#4
-- Old SHA: c84d0ad4a87f4845d8e769416676d1ab85cfe464
-- New SHA: 91ad9b127c41c0538051a0c81e2cb9206a2587dd
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/corrade/portfile.cmake
ports/vc/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/ampl-mp/vcpkg.json
ports/aom/vcpkg.json
ports/corrade/vcpkg.json
ports/fltk/vcpkg.json
ports/libhydrogen/vcpkg.json
ports/openblas/vcpkg.json
ports/orc/vcpkg.json
ports/pthreadpool/vcpkg.json
ports/seal/vcpkg.json
ports/vc/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/corrade/portfile.cmake
ports/vc/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/ampl-mp/vcpkg.json
ports/aom/vcpkg.json
ports/corrade/vcpkg.json
ports/fltk/vcpkg.json
ports/libhydrogen/vcpkg.json
ports/openblas/vcpkg.json
ports/orc/vcpkg.json
ports/pthreadpool/vcpkg.json
ports/seal/vcpkg.json
ports/vc/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions bot approved these changes Apr 12, 2022

View reviewed changes

JackBoosY self-assigned this Apr 13, 2022

JackBoosY added category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal labels Apr 13, 2022

Neumann-A reviewed Apr 13, 2022

View reviewed changes

scripts/toolchains/windows.cmake Outdated Show resolved Hide resolved

github-actions bot approved these changes Apr 13, 2022

View reviewed changes

Neumann-A reviewed Apr 13, 2022

View reviewed changes

scripts/toolchains/windows.cmake Outdated Show resolved Hide resolved

github-actions bot requested changes Apr 14, 2022

View reviewed changes

github-actions bot requested changes Apr 15, 2022

View reviewed changes

dg0yt reviewed Apr 16, 2022

View reviewed changes

strega-nil-ms force-pushed the windows-toolchain-cmake_system_processor branch from 848f3dd to b5aaa2f Compare April 18, 2022 18:02

github-actions bot requested changes Apr 18, 2022

View reviewed changes

strega-nil-ms force-pushed the windows-toolchain-cmake_system_processor branch from b5aaa2f to 5b2b9d5 Compare April 19, 2022 17:26

github-actions bot approved these changes Apr 19, 2022

View reviewed changes

strega-nil-ms force-pushed the windows-toolchain-cmake_system_processor branch from 5b2b9d5 to 77e1877 Compare April 19, 2022 17:29

github-actions bot approved these changes Apr 19, 2022

View reviewed changes

strega-nil-ms force-pushed the windows-toolchain-cmake_system_processor branch from 77e1877 to f9e88f3 Compare April 19, 2022 20:35

github-actions bot approved these changes Apr 19, 2022

View reviewed changes

strega-nil-ms force-pushed the windows-toolchain-cmake_system_processor branch from f9e88f3 to 0dc0a70 Compare April 19, 2022 20:36

github-actions bot approved these changes Apr 19, 2022

View reviewed changes

Neumann-A reviewed Apr 19, 2022

View reviewed changes

This was referenced Apr 20, 2022

[vcpkg/toolchain] set CMAKE_SYSTEM_PROCESSOR for arm on windows #16111

Closed

[fortran] use flang-classic for windows instead of gfortran #23987

Closed

[vcpkg-cmake|cmake buildsystem] synchronize and sanitize scripts. #23259

Merged

JackBoosY mentioned this pull request Apr 20, 2022

[vcpkg baseline][qpid-proton] Fix dependencies #24267

Merged

strega-nil-ms force-pushed the windows-toolchain-cmake_system_processor branch from 276cec6 to 25da982 Compare April 20, 2022 15:15

strega-nil added 5 commits April 21, 2022 09:29

fix x86-windows

66d472d

fix qpid-proton, glog

bb55b95

build corrade-rc

e506da4

fix x64-uwp ports

28a33e3

forgot to _actually_ always build corrade-rc .,.

ec1a1bc

strega-nil-ms force-pushed the windows-toolchain-cmake_system_processor branch from 29ac446 to ec1a1bc Compare April 21, 2022 16:31

github-actions bot approved these changes Apr 21, 2022

View reviewed changes

Neumann-A mentioned this pull request Apr 27, 2022

[boringssl] Mark that arm-windows doesn't work #24435

Closed

Merge remote-tracking branch 'origin/master' into HEAD

b564031

github-actions bot approved these changes Apr 27, 2022

View reviewed changes

Merge remote-tracking branch 'origin/master' into HEAD

7c12aba

# Conflicts: # versions/o-/orc.json

github-actions bot approved these changes Apr 28, 2022

View reviewed changes

Replay microsoft#22831

566b8ff

github-actions bot approved these changes Apr 28, 2022

View reviewed changes

Dedupe CMAKE_SYSTEM_NAME settings.

b641e34

github-actions bot approved these changes Apr 28, 2022

View reviewed changes

BillyONeal approved these changes Apr 28, 2022

View reviewed changes

JackBoosY suggested changes Apr 29, 2022

View reviewed changes

ports/corrade/portfile.cmake Outdated Show resolved Hide resolved

Add quotes for corrade_rc_param

89fc203

Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>

github-actions bot requested changes Apr 29, 2022

View reviewed changes

Update version DB.

31e5a53

BillyONeal requested a review from JackBoosY April 29, 2022 04:07

github-actions bot approved these changes Apr 29, 2022

View reviewed changes

JackBoosY approved these changes Apr 29, 2022

View reviewed changes

BillyONeal merged commit 9ccd693 into microsoft:master Apr 29, 2022

pezcode mentioned this pull request Apr 30, 2022

vcpkg install x86-uwp error: Native corrade-rc executable not found mosra/corrade#81

Closed

ekilmer mentioned this pull request Aug 9, 2022

[vcpkg] Fix cross compiling macOS #26240

Merged

WangWeiLin-MV mentioned this pull request Aug 16, 2024

[vcpkg scripts] toolchain/osx: Fix CMAKE_HOST_SYSTEM_PROCESSOR condition with lower case arm64 #40503

Merged

strega-nil deleted the windows-toolchain-cmake_system_processor branch March 31, 2025 16:14

Conversation

strega-nil-ms commented Apr 12, 2022

Uh oh!

Neumann-A commented Apr 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Neumann-A commented Apr 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

dg0yt Apr 16, 2022

Choose a reason for hiding this comment

Uh oh!

strega-nil-ms Apr 18, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Neumann-A Apr 19, 2022

Choose a reason for hiding this comment

Uh oh!

strega-nil-ms Apr 20, 2022

Choose a reason for hiding this comment

Uh oh!

Neumann-A Apr 20, 2022

Choose a reason for hiding this comment

Uh oh!

strega-nil-ms Apr 20, 2022

Choose a reason for hiding this comment

Uh oh!

vicroms Apr 20, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ghost commented Apr 29, 2022

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Neumann-A commented Apr 12, 2022 •

edited

Loading

Neumann-A commented Apr 13, 2022 •

edited

Loading