[vcpkg baseline][cairo] Add option atomic-ops and disable it#23999
Merged
strega-nil-ms merged 4 commits intomicrosoft:masterfrom Apr 7, 2022
Merged
[vcpkg baseline][cairo] Add option atomic-ops and disable it#23999strega-nil-ms merged 4 commits intomicrosoft:masterfrom
strega-nil-ms merged 4 commits intomicrosoft:masterfrom
Conversation
This was referenced Apr 6, 2022
LilyWangLL
approved these changes
Apr 6, 2022
strega-nil-ms
suggested changes
Apr 6, 2022
Contributor
strega-nil-ms
left a comment
There was a problem hiding this comment.
I also think we should just remove the check for atomic_ops.h, so that it will still check for atomic-ops-cxx11 and atomic-ops-gcc-legacy and libkern/OSAtomic.h (OSX built-in atomics)
added 2 commits
April 7, 2022 00:01
Contributor
Author
|
@strega-nil-ms Done. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cairo will automatically detect
libatomic-opsand enable this feature when discovered. But using it in cairo has some issues.I have opened an issue upstream: https://gitlab.freedesktop.org/cairo/cairo/-/issues/554
Since cairo uses auto-detection instead of options, we can't add dependencies explicitly, so I added a feature and disabled it until upstream fixes this.
Replace #23995.