Merged
Conversation
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
Details
If you feel able to do so, please consider adding a "license" field to the following files:
ports/libiconv/vcpkg.json
Valid values for the license field can be found in the documentation
Contributor
|
@Thomas1664 ,Thanks for your pr, have you tested the usage? |
Contributor
|
@JonLiu1993 This is canonical usage: https://cmake.org/cmake/help/v3.21/module/FindIconv.html?highlight=findiconv |
Contributor
Thanks for your clarify |
JonLiu1993
approved these changes
Apr 6, 2022
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Fixes [iconv] How to use with vcpkg?
vcpkg install iconvthen "Could not find a package configuration file" #22539Which triplets are supported/not supported? Have you updated the CI baseline?
unchanged
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes