[sdl2-image] Features must use sdl2[x11] on Linux by Thomas1664 · Pull Request #23725 · microsoft/vcpkg

Thomas1664 · 2022-03-22T23:48:33Z

Describe the pull request

What does your PR fix?

Fixes [sdl2-image] JPEG and WEBP features do not work on Linux #21331
Which triplets are supported/not supported? Have you updated the CI baseline?

unchanged
Does your PR follow the maintainer guide?

Yes
If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/sdl2-image/vcpkg.json

Valid values for the license field can be found in the documentation

Thomas1664 · 2022-03-22T23:52:14Z

Note: Need to test all features

ports/sdl2-image/CMakeLists.txt

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/sdl2-image/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/sdl2-image/vcpkg.json

Valid values for the license field can be found in the documentation

JonLiu1993 · 2022-03-23T08:13:56Z

All features are tested successfully in the following triplet:

x86-windows
x64-windows
x64-windows-static

ports/sdl2-image/CMakeLists.txt

dg0yt · 2022-03-23T09:34:58Z

I realize that this port uses a custom build CMake system. So some problems are native to vcpkg. Maybe it needs a more general review towards best practice for CMake, instead of local modifications.

Upstream has a CMake build system now in the main branch but I don't know if it is feasible to backport that one.

Thomas1664 · 2022-03-23T10:00:29Z

I think I tried to fix the wrong thing. The DLL thing was never a problem. The problem is that sdl2-image incorrectly consumes sdl2 because on Linux the feature x11 is needed. I'll fix that in the evening (UTC).

ports/sdl2-image/CMakeLists.txt

ports/sdl2-image/portfile.cmake

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/sdl2-image/vcpkg.json
ports/sdl2/vcpkg.json
ports/sdl2pp/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/sdl2-image/vcpkg.json
ports/sdl2/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/sdl2-image/vcpkg.json
ports/sdl2/vcpkg.json

Valid values for the license field can be found in the documentation

ports/sdl2-image/CMakeLists.txt

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/sdl2-image/vcpkg.json
ports/sdl2/vcpkg.json

Valid values for the license field can be found in the documentation

kogiokka · 2022-03-30T14:22:14Z

I've tested it. Now I can successfully load both image types.

Thomas1664 · 2022-04-11T15:44:13Z

@JackBoosY Can you please review this PR?

ports/sdl2-image/CMakeLists.txt

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/sdl2-image/vcpkg.json
ports/sdl2/vcpkg.json

Valid values for the license field can be found in the documentation

strega-nil-ms · 2022-04-15T20:44:05Z

LGTM, thanks!

Thomas1664 added 3 commits March 23, 2022 00:44

Fix shared libs suffix

23cd9b3

Remove version-string

84d47f9

version

cac9869

github-actions bot approved these changes Mar 22, 2022

View reviewed changes

JonLiu1993 assigned JackBoosY Mar 23, 2022

JonLiu1993 added the category:port-bug The issue is with a library, which is something the port should already support label Mar 23, 2022

JackBoosY approved these changes Mar 23, 2022

View reviewed changes

dg0yt reviewed Mar 23, 2022

View reviewed changes

ports/sdl2-image/CMakeLists.txt Outdated Show resolved Hide resolved

JackBoosY added the requires:author-response label Mar 23, 2022

Thomas1664 added 2 commits March 23, 2022 09:04

Use cmake version of shared lib suffix

6552875

version

23c4705

github-actions bot approved these changes Mar 23, 2022

View reviewed changes

Thomas1664 added 2 commits March 23, 2022 09:07

Remove old feature processing

70d329d

version

e29dd62

github-actions bot approved these changes Mar 23, 2022

View reviewed changes

JackBoosY approved these changes Mar 23, 2022

View reviewed changes

JackBoosY removed the requires:author-response label Mar 23, 2022

JonLiu1993 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Mar 23, 2022

dg0yt suggested changes Mar 23, 2022

View reviewed changes

ports/sdl2-image/CMakeLists.txt Outdated Show resolved Hide resolved

JonLiu1993 added requires:author-response and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Mar 23, 2022

Thomas1664 marked this pull request as draft March 23, 2022 10:34

Thomas1664 added 4 commits March 23, 2022 14:13

Real fix

f1a4799

[sdl2] Fix x11 feature

0979f2b

format

5371158

version

7d8df1b

dg0yt suggested changes Mar 26, 2022

View reviewed changes

ports/sdl2-image/CMakeLists.txt Outdated Show resolved Hide resolved

ports/sdl2-image/portfile.cmake Show resolved Hide resolved

Thomas1664 added 2 commits March 26, 2022 17:33

Fix config

845da5a

version

b8a2623

github-actions bot approved these changes Mar 26, 2022

View reviewed changes

Revert sdl2pp

b51f26d

github-actions bot approved these changes Mar 26, 2022

View reviewed changes

Thomas1664 marked this pull request as draft March 27, 2022 20:26

JonLiu1993 removed the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Mar 28, 2022

Thomas1664 added 2 commits March 30, 2022 11:19

Fix config

d368664

version

18bee6e

github-actions bot approved these changes Mar 30, 2022

View reviewed changes

Thomas1664 marked this pull request as ready for review March 30, 2022 09:32

dg0yt suggested changes Mar 30, 2022

View reviewed changes

ports/sdl2-image/CMakeLists.txt Outdated Show resolved Hide resolved

Thomas1664 added 2 commits March 30, 2022 15:29

Create config.cmake.in file

999299d

version

70ea256

github-actions bot approved these changes Mar 30, 2022

View reviewed changes

JackBoosY suggested changes Apr 12, 2022

View reviewed changes

ports/sdl2-image/CMakeLists.txt Show resolved Hide resolved

JackBoosY added the requires:author-response label Apr 12, 2022

dg0yt reviewed Apr 12, 2022

View reviewed changes

ports/sdl2-image/CMakeLists.txt Show resolved Hide resolved

Merge branch 'microsoft:master' into sdl2-image

bf841dd

github-actions bot approved these changes Apr 14, 2022

View reviewed changes

JackBoosY approved these changes Apr 15, 2022

View reviewed changes

JackBoosY added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Apr 15, 2022

strega-nil-ms merged commit 05bcc5f into microsoft:master Apr 15, 2022

Thomas1664 deleted the sdl2-image branch April 15, 2022 21:17

Conversation

Thomas1664 commented Mar 22, 2022

What does your PR fix?

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Thomas1664 commented Mar 22, 2022

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

JonLiu1993 commented Mar 23, 2022

Uh oh!

Uh oh!

dg0yt commented Mar 23, 2022

Uh oh!

Thomas1664 commented Mar 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

kogiokka commented Mar 30, 2022

Uh oh!

Thomas1664 commented Apr 11, 2022

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

strega-nil-ms commented Apr 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?

Thomas1664 commented Mar 23, 2022 •

edited

Loading