[shapelib] Fix shapelib usage#22633
Merged
BillyONeal merged 4 commits intomicrosoft:masterfrom Mar 21, 2022
Merged
Conversation
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/shapelib/vcpkg.json
Valid values for the license field are listed at https://spdx.org/licenses/
JackBoosY
reviewed
Mar 18, 2022
| -# for the export_shp name. | ||
| -install(EXPORT export_shp DESTINATION ${CMAKE_INSTALL_SHP_DATADIR}) | ||
| +# for the shpConfig name. | ||
| +install(EXPORT shpConfig DESTINATION ${CMAKE_INSTALL_SHP_DATADIR}) |
Contributor
There was a problem hiding this comment.
Also please report this to the upstream plase.
JackBoosY
approved these changes
Mar 18, 2022
Member
|
Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Fixes [shapelib] Unable to find shp-config.cmake when including in build #16041Shapelib unable to find shp-config.cmake when including in build
Export the shpConfig file can solved the bug
I have test the usage successfully on my local machine: