Merged
Conversation
96 tasks
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 2b543e52da6a7a595760f10c1160e808d89c41ed -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/c-/cgal.json b/versions/c-/cgal.json
index 7cc6c29..e1dc39a 100644
--- a/versions/c-/cgal.json
+++ b/versions/c-/cgal.json
@@ -5,11 +5,6 @@
"version": "5.4",
"port-version": 0
},
- {
- "git-tree": "e9d6d93929952a260387c0604db0bc72473ff795",
- "version-semver": "5.4.0-beta1",
- "port-version": 0
- },
{
"git-tree": "da69aec4c03275e85108ebc2dc2d512057d6ac32",
"version": "5.3.1",You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/cgal/vcpkg.json
Valid values for the license field are listed at https://spdx.org/licenses/
That is required by the CI.
That is required by the CI.
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 2b543e52da6a7a595760f10c1160e808d89c41ed -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/c-/cgal.json b/versions/c-/cgal.json
index e1dc39a..13b6b72 100644
--- a/versions/c-/cgal.json
+++ b/versions/c-/cgal.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "f4443135f45633a2c024df0d4218b8f86db35dcd",
+ "git-tree": "0acdd574cd028b7ca4acd762f01938492c6d4719",
"version": "5.4",
"port-version": 0
},
Contributor
Author
|
@JonLiu1993 Now that CGAL-5.4 was published, this PR has been updated, and the CI seems fine with it. |
JonLiu1993
approved these changes
Feb 7, 2022
Contributor
|
All features are tested successfully in the following triplet:
|
Contributor
|
Thanks for the update! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does your PR fix?
Update to CGAL-5.4.
Which triplets are supported/not supported? Have you updated the CI baseline?
all
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes, I did.