Skip to content

[python3] Install pkg-config files on Windows platforms#22198

Merged
BillyONeal merged 1 commit intomicrosoft:masterfrom
soylent-io:fix/python3-pkgconfig
Jan 3, 2022
Merged

[python3] Install pkg-config files on Windows platforms#22198
BillyONeal merged 1 commit intomicrosoft:masterfrom
soylent-io:fix/python3-pkgconfig

Conversation

@mkhon
Copy link
Copy Markdown
Contributor

@mkhon mkhon commented Dec 25, 2021 •
edited
Loading

Install pkg-config configuration files on Windows platforms (msbuild builds)

  • What does your PR fix?

  • Which triplets are supported/not supported? Have you updated the CI baseline?

all

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@ghost
Copy link
Copy Markdown

ghost commented Dec 25, 2021 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@JackBoosY JackBoosY added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Dec 25, 2021
@mkhon mkhon mentioned this pull request Dec 25, 2021
Merged
Hoikas
Hoikas reviewed Dec 26, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Hoikas Hoikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes assume that both release and debug builds are being built. It needs to be made safe for release only and debug only triplets.

@LilyWangLL
Copy link
Copy Markdown
Contributor

LilyWangLL commented Dec 27, 2021

Thanks for your PR. Please run command vcpkg x-add-version --all then commit the changes.

@mkhon
Copy link
Copy Markdown
Contributor Author

mkhon commented Dec 28, 2021

These changes assume that both release and debug builds are being built. It needs to be made safe for release only and debug only triplets.

Fixed now

@LilyWangLL LilyWangLL added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Dec 29, 2021
@mkhon mkhon changed the title [python3] Install pkg-config files [python3] Install pkg-config files on Windows platforms Dec 29, 2021
BillyONeal
BillyONeal reviewed Dec 29, 2021
View reviewed changes
ports/python3/portfile.cmake Outdated
Copy link
Copy Markdown
Member

@BillyONeal BillyONeal Dec 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm confused by my understanding is that configure_file only looks at CMake variables, not environment variables, so this call to vcpkg_backup_env_variables and vcpkg_restore_env_variables doesn't seem to have an effect?

Copy link
Copy Markdown
Contributor

@JackBoosY JackBoosY Dec 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping @mkhon for response.

Copy link
Copy Markdown
Contributor Author

@mkhon mkhon Dec 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, @BillyONeal is right - I updated the PR

@BillyONeal BillyONeal added requires:author-response and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Dec 29, 2021
@BillyONeal BillyONeal merged commit c662463 into microsoft:master Jan 3, 2022
@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Jan 3, 2022

Thanks!

@mkhon mkhon deleted the fix/python3-pkgconfig branch January 4, 2022 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillyONeal BillyONeal BillyONeal left review comments

@github-actions github-actions[bot] github-actions[bot] approved these changes

+3 more reviewers

@Hoikas Hoikas Hoikas left review comments

@JackBoosY JackBoosY JackBoosY left review comments

@LilyWangLL LilyWangLL LilyWangLL approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LilyWangLL LilyWangLL

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mkhon @LilyWangLL @BillyONeal @Hoikas @JackBoosY