Skip to content

[sdl2-mixer] Fix feature mpg123 build error#21812

Merged
BillyONeal merged 4 commits intomicrosoft:masterfrom
LilyWangLL:dev/LilyWang/issue21776
Dec 7, 2021
Merged

[sdl2-mixer] Fix feature mpg123 build error#21812
BillyONeal merged 4 commits intomicrosoft:masterfrom
LilyWangLL:dev/LilyWang/issue21776

Conversation

@LilyWangLL
Copy link
Copy Markdown
Contributor

@LilyWangLL LilyWangLL commented Dec 2, 2021 •
edited
Loading

Due to sdl2-mixer depends on old version of mpg123, it doesn't support latest version of mpg123. Fix #21776
Upstream issue: libsdl-org/SDL_mixer#340. This PR add patch for sdl2-mixer to merge upstream change.
Feature mpg123 and libflac test pass on x64-windows.

Features of sdl2-mixer:

  • [libvorbis] If change find_library to find_package, it will build failed with link error
  • [libmodplug, opusfile, fluidsynth] These ports don't export config.cmake files

I will fix these features in other PRs.

@LilyWangLL LilyWangLL added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Dec 2, 2021
@LilyWangLL LilyWangLL requested a review from JackBoosY December 2, 2021 08:22
@LilyWangLL LilyWangLL changed the title [sdl2-mixer] Disable feature mpg123 temporarily [sdl2-mixer] Fix feature mpg123 build error Dec 3, 2021
@LilyWangLL LilyWangLL marked this pull request as ready for review December 3, 2021 09:00
@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Dec 6, 2021
JackBoosY
JackBoosY reviewed Dec 6, 2021
View reviewed changes
ports/sdl2-mixer/fix-featurempg123.patch
@@ -0,0 +1,47 @@
diff --git a/music_mpg123.c b/music_mpg123.c
Copy link
Copy Markdown
Contributor

@JackBoosY JackBoosY Dec 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes is in the upstream.

Copy link
Copy Markdown
Member

@BillyONeal BillyONeal Dec 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking!

@BillyONeal BillyONeal merged commit 86fb7a1 into microsoft:master Dec 7, 2021
@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Dec 7, 2021

Thanks for the fix!

@JackBoosY JackBoosY mentioned this pull request Dec 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillyONeal BillyONeal BillyONeal left review comments

@github-actions github-actions[bot] github-actions[bot] approved these changes

+1 more reviewer

@JackBoosY JackBoosY JackBoosY approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JackBoosY JackBoosY

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[sdl2-mixer] build failure with mpg123

3 participants

@LilyWangLL @BillyONeal @JackBoosY