Skip to content

[vcpkg baseline][wavelib] Fix parallel build#21671

Merged
BillyONeal merged 2 commits intomicrosoft:masterfrom
dg0yt:wavelib
Nov 26, 2021
Merged

[vcpkg baseline][wavelib] Fix parallel build#21671
BillyONeal merged 2 commits intomicrosoft:masterfrom
dg0yt:wavelib

Conversation

@dg0yt
Copy link
Copy Markdown
Contributor

@dg0yt dg0yt commented Nov 26, 2021

  • What does your PR fix?

    Fixes parallel builds by disabling the test dir which creates test executables in the source dir.
    (Assumed to fix msbuild issue in [vcpkg-cmake] Update parallel vcpkg_cmake_configure #21507.)

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all, no

  • Does your PR follow the maintainer guide?

    yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    yes

@JackBoosY JackBoosY self-assigned this Nov 26, 2021
@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Nov 26, 2021
@JackBoosY JackBoosY changed the title [wavelib] Fix parallel build [vcpkg baseline][wavelib] Fix parallel build Nov 26, 2021
@JackBoosY
Copy link
Copy Markdown
Contributor

Thanks for the fix!

@JackBoosY
Copy link
Copy Markdown
Contributor

Ping @BillyONeal for merge this PR first if the pipeline test pass.

@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Nov 26, 2021
@BillyONeal BillyONeal merged commit f35e0e3 into microsoft:master Nov 26, 2021
@BillyONeal
Copy link
Copy Markdown
Member

Thanks for the fix!

@dg0yt dg0yt deleted the wavelib branch December 11, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants