Enable arm64 build for Arrow#21467
Conversation
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout ba383ed2332f42593a30dd3f35b09f4a59d31d91 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/a-/arrow.json b/versions/a-/arrow.json
index af8c5e2..deb3acd 100644
--- a/versions/a-/arrow.json
+++ b/versions/a-/arrow.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "5e55365e8c85eb0d1a0aeb230c88179cf6c15141",
+ "git-tree": "bb1f4493a97f3e06a50b33d1669c3730095ab7a4",
"version": "5.0.0",
"port-version": 2
},You have modified or added at least one portfile where deprecated functions are used.
Details
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}The following files are affected:
ports/arrow/portfile.cmake
|
How can I tell the CI to build the arrow port on |
c3a45a2 to
3ad1537
Compare
3ad1537 to
d478f40
Compare
d478f40 to
84adba2
Compare
5ce11ec to
779fe15
Compare
779fe15 to
d3d9e28
Compare
|
LGTM. |
Describe the pull request
What does your PR fix?
This PR adds support for building Arrow for arm64, and for cross-compilation to work (e.g. building
arm64-osxfrom ax64-osxhost). Building onarm64-windowsis still not supported and would require a patch to Arrow (maybe for a future PR?).Which triplets are supported/not supported? Have you updated the CI baseline?
Adding non-Windows
arm64triplets to the current list (allx64triplets).No change to the CI baseline (The non-Windows
arm64triplets are community supported anyway).Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes