[vcpkg-cmake-config] Check for unguarded release lib paths#21415
Draft
dg0yt wants to merge 12 commits intomicrosoft:masterfrom
Draft
[vcpkg-cmake-config] Check for unguarded release lib paths#21415dg0yt wants to merge 12 commits intomicrosoft:masterfrom
dg0yt wants to merge 12 commits intomicrosoft:masterfrom
Conversation
Contributor
Author
|
I expected some false positives, but it looks like there are only real issues. x64-linux: |
dg0yt
commented
Nov 14, 2021
Contributor
Author
There was a problem hiding this comment.
The loop needs to avoid matching immediately again at the start of unprocessed. That's why the first character is changed into a : for string(FIND ...).
Contributor
Author
|
Windows (x64-windows): |
Contributor
Author
|
Maybe it should be merged with |
Merged
Contributor
|
I surprised that only so few cases of wrong |
Contributor
Author
Suggestion:
|
Contributor
Author
|
One frequent pattern: |
bb6b021 to
ac336ca
Compare
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for vcpkg-cmake-config but no changes to version or port version.
-- Version: 2021-11-01
-- Old SHA: 38a87ee8edd9ea8e8fff604fbcb785661a8d0e28
-- New SHA: a6843efe960d364ed93093c77e12501391fae93b
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
Contributor
Author
Implemented. This change now rebuilds the world, installing app. ~1310 ports on x64-windows. |
Contributor
|
Any progress in this PR? I'd like this. |
Contributor
Author
|
I was hesitating to remove draft state while it is not ready for merge. But is ready for review. |
Contributor
|
Okay, I need some professional advice. |
Contributor
|
Can you please merge to master? |
d2e1ed9 to
b5ae95b
Compare
Contributor
|
Ping @dg0yt for response. Is work still being done for this PR? |
Contributor
Author
|
"to leave as draft", #21415 (comment) |
Contributor
|
This check only works when there are absolute path in the cmake config file? |
Contributor
Author
Yes, absolute paths in the main config file. For another approach cf. |
9ce6f6e
Contributor
Author
|
9ce6f6e to
aae6c35
Compare
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout f9bea5d58186dc14e7e33132e43b52222147f51e -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index 397044c0..d43b4e19 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -7853,8 +7853,8 @@
"port-version": 0
},
"vcpkg-cmake-config": {
- "baseline": "2022-02-06",
- "port-version": 1
+ "baseline": "2022-12-31",
+ "port-version": 0
},
"vcpkg-cmake-get-vars": {
"baseline": "2022-09-04",
diff --git a/versions/v-/vcpkg-cmake-config.json b/versions/v-/vcpkg-cmake-config.json
index a354d873..2064c064 100644
--- a/versions/v-/vcpkg-cmake-config.json
+++ b/versions/v-/vcpkg-cmake-config.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "3456971f1876003de633b1fcf4a3a5daa33c6eab",
+ "version-date": "2022-12-31",
+ "port-version": 0
+ },
{
"git-tree": "8d54cc4f487d51b655abec5f9c9c3f86ca83311f",
"version-date": "2022-02-06",
Neumann-A
reviewed
Jan 1, 2023
Neumann-A
reviewed
Jan 1, 2023
Contributor
Author
|
False positives:
|
aae6c35 to
f5c2945
Compare
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout f9bea5d58186dc14e7e33132e43b52222147f51e -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index c3592cab..e3190405 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -7853,8 +7853,8 @@
"port-version": 0
},
"vcpkg-cmake-config": {
- "baseline": "2022-02-06",
- "port-version": 1
+ "baseline": "2022-12-31",
+ "port-version": 0
},
"vcpkg-cmake-get-vars": {
"baseline": "2022-09-04",
diff --git a/versions/v-/vcpkg-cmake-config.json b/versions/v-/vcpkg-cmake-config.json
index a354d873..4ca41337 100644
--- a/versions/v-/vcpkg-cmake-config.json
+++ b/versions/v-/vcpkg-cmake-config.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "e341da67a840d7cb4d82d0bbbd8d1b15ea52d88f",
+ "version-date": "2022-12-31",
+ "port-version": 0
+ },
{
"git-tree": "8d54cc4f487d51b655abec5f9c9c3f86ca83311f",
"version-date": "2022-02-06",f5c2945 to
344e033
Compare
Member
|
Closing this PR as there has not been activity in over 4 months. Please feel free to reopen it, or another PR, should you wish to continue this. |
Contributor
Author
Unprivileged contributors cannot reopen their own PRs here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does your PR fix?
Finds unguarded release lib paths in main cmake config files.
Unlike per-build-type files, main config files are used for release and debug. Unexpected mixing breaks builds. Examples:
szip in hdf5, openssl in aws-sdk-cpp ([netcdf-c] Update to 4.8.1, revise features #21239 (comment), Fix aws-sdk-cpp and OpenSSL cross-platform builds #20289 (comment)).
Which triplets are supported/not supported? Have you updated the CI baseline?
all, no
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Waiting for feedback on idea and implementation.