Skip to content

[miniz] Install pkgconfig files to the correct location.#21025

Merged
BillyONeal merged 1 commit intomicrosoft:masterfrom
BillyONeal:miniz-pkgconfig
Oct 28, 2021
Merged

[miniz] Install pkgconfig files to the correct location.#21025
BillyONeal merged 1 commit intomicrosoft:masterfrom
BillyONeal:miniz-pkgconfig

Conversation

@BillyONeal
Copy link
Copy Markdown
Member

No description provided.

@BillyONeal BillyONeal added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Oct 27, 2021
Comment on lines +9 to +10
- DESTINATION ${CMAKE_INSTALL_DATADIR}/pkgconfig)
+ DESTINATION ${CMAKE_INSTALL_LIBDIR}/pkgconfig)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe vcpkg_fixup_pkgconfig should set the search path like vcpkg_cmake_config_fixup and automatically copy pc to lib/pkgconfig and clean up the original path.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we? @Neumann-A

@BillyONeal BillyONeal merged commit 62de562 into microsoft:master Oct 28, 2021
@BillyONeal BillyONeal deleted the miniz-pkgconfig branch October 28, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants