Skip to content

[qca] Fix usage#20977

Merged
BillyONeal merged 12 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/20970
Oct 28, 2021
Merged

[qca] Fix usage#20977
BillyONeal merged 12 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/20970

Conversation

@JackBoosY
Copy link
Copy Markdown
Contributor

@JackBoosY JackBoosY commented Oct 25, 2021

  • Use vcpkg_cmake_config_fixup instead of hard code in portfile.cmake.
  • Fix other macro in the config file.

Fixes #20970.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Oct 25, 2021
@JackBoosY
Copy link
Copy Markdown
Contributor Author

JackBoosY commented Oct 25, 2021

@m-kuhn Please test my changes.

Thanks.

JackBoosY
JackBoosY commented Oct 25, 2021
View reviewed changes
@JackBoosY JackBoosY mentioned this pull request Oct 25, 2021
Closed
dg0yt
dg0yt reviewed Oct 25, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JackBoosY Maybe it is time to get rid of the cmake script downloads after # Remove these files on the cmake next update?

m-kuhn
m-kuhn approved these changes Oct 25, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@m-kuhn m-kuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix confirmed, thanks for the quick reaction

@BillyONeal BillyONeal mentioned this pull request Oct 27, 2021
Merged
@NancyLi1013 NancyLi1013 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Oct 28, 2021
@JackBoosY
Copy link
Copy Markdown
Contributor Author

JackBoosY commented Oct 28, 2021

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Oct 28, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Oct 28, 2021
@BillyONeal BillyONeal mentioned this pull request Oct 28, 2021
Merged
@BillyONeal BillyONeal merged commit 0f3bc67 into microsoft:master Oct 28, 2021
@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Oct 28, 2021

Thanks for the fix!

@JackBoosY JackBoosY deleted the dev/jack/20970 branch October 29, 2021 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

+3 more reviewers

@dg0yt dg0yt dg0yt left review comments

@m-kuhn m-kuhn m-kuhn approved these changes

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@NancyLi1013 NancyLi1013

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[qca] fails to be found in manifest mode / absolute path

5 participants

@JackBoosY @BillyONeal @m-kuhn @dg0yt @NancyLi1013