[scripts-audit] CMake buildsystem#20885
Merged
strega-nil-ms merged 6 commits intomicrosoft:masterfrom Nov 5, 2021
Merged
Conversation
51 tasks
Neumann-A
reviewed
Oct 21, 2021
Neumann-A
reviewed
Oct 21, 2021
Start auditing vcpkg_configure_cmake
58b2de3 to
cb825bb
Compare
BillyONeal
reviewed
Oct 22, 2021
BillyONeal
reviewed
Oct 22, 2021
BillyONeal
reviewed
Oct 22, 2021
BillyONeal
reviewed
Oct 22, 2021
BillyONeal
reviewed
Oct 22, 2021
|
|
||
| # If we use Ninja, make sure it's on PATH | ||
| if(GENERATOR STREQUAL "Ninja" AND NOT DEFINED ENV{VCPKG_FORCE_SYSTEM_BINARIES}) | ||
| if("${generator}" STREQUAL "Ninja" AND NOT DEFINED ENV{VCPKG_FORCE_SYSTEM_BINARIES}) |
Member
There was a problem hiding this comment.
I think the VCPKG_FORCE_SYSTEM_BINARIES check should be inside vcpkg_find_acquire_program?
Contributor
Author
There was a problem hiding this comment.
It probably should be, but it currently isn't and we aren't changing behavior right now.
Member
There was a problem hiding this comment.
I don't think it's actually a behavior change?
BillyONeal
reviewed
Oct 22, 2021
BillyONeal
reviewed
Oct 22, 2021
BillyONeal
approved these changes
Oct 26, 2021
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start auditing
vcpkg_*_cmake