Conversation
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for graphviz but no changes to version or port version.
-- Version: 2.47.3
-- Old SHA: 37d7f96823e611efdca1d7e256f267aa00aa4285
-- New SHA: 4bbd6335a4139353058c782566e6e83f3fab784e
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
Details
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}The following files are affected:
ports/graphviz/portfile.cmake
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for graphviz but no changes to version or port version.
-- Version: 2.47.3
-- Old SHA: 9e2375b27a517008eaa137b6e3653a891f543ae2
-- New SHA: 55bd07fbce65294c134c67411b6a4e2a843d5a80
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
Co-authored-by: Phoebe <20694052+PhoebeHui@users.noreply.github.com>
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for graphviz but no changes to version or port version.
-- Version: 2.47.3
-- Old SHA: 28b9cc63b06eb8e7d7325eea4c9a73884231fbba
-- New SHA: 2c0b4bb82c5de30956a3adfe87b34230af608e75
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
|
LGTM, thanks for your PR! Noted that graphviz passed with x86-windows x64-windows, x64-osx and x64-linux in CI testing, it cascaded with others triplets(x64-windows-static, x64-windows-static-md, x64-uwp, arm-uwp and arm64-windows) due to the dependency port pango and getopt cascaded. |
|
In my experience graphviz is generally only used in tool form rather than as a library, making it a somewhat poor fit for the builtin catalog. Do you @Ace314159 do you have example(s) using it as a library rather than as a tool? (Note that we have rejected attempts to add gcc before for similar reasons even though we have llvm because llvm is often used as a library while gcc is not) |
|
@BillyONeal Graphviz is a dependency for Gazebo, which is an important simulation library commonly used with ROS2. This will make building Gazebo and using it much easier when using ROS2 on Windows. |
|
@Ace314159 Thanks! |
|
Thanks for the PR! |
This adds the graphviz port
What does your PR fix?
Fixes Add graphviz #737 and graphviz #14043
Which triplets are supported/not supported? Have you updated the CI baseline?
all, Yes
Does your PR follow the maintainer guide?
YesIf you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/