Skip to content

[effolkronium-random] Update to 1.4.0#20496

Merged
strega-nil-ms merged 2 commits intomicrosoft:masterfrom
chausner:effolkronium-random-1.4.0
Oct 5, 2021
Merged

[effolkronium-random] Update to 1.4.0#20496
strega-nil-ms merged 2 commits intomicrosoft:masterfrom
chausner:effolkronium-random-1.4.0

Conversation

@chausner
Copy link
Copy Markdown
Contributor

@chausner chausner commented Oct 3, 2021

Describe the pull request

  • What does your PR fix?

    Updates effolkronium-random to 1.4.0

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    As before, Yes

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

@strega-nil-ms
Copy link
Copy Markdown
Contributor

strega-nil-ms commented Oct 5, 2021

Thanks!

@strega-nil-ms strega-nil-ms merged commit a51ecd8 into microsoft:master Oct 5, 2021
@chausner chausner deleted the effolkronium-random-1.4.0 branch October 5, 2021 00:17
@michaelkroener
Copy link
Copy Markdown

michaelkroener commented Oct 5, 2021 •
edited
Loading

Does not find the package configuration file anymore
with the suggested find_package(effolkronium-random CONFIG REQUIRED)

Could not find a package configuration file provided by
 "effolkronium-random" with any of the following names:

   effolkronium-randomConfig.cmake
   effolkronium-random-config.cmake

with the actual config filename find_package(effolkronium_random CONFIG REQUIRED)

Could not find a package configuration file provided by
  "effolkronium_random" with any of the following names:

    effolkronium_randomConfig.cmake
    effolkronium_random-config.cmake

It worked fine before this version update using find_package(effolkronium_random CONFIG REQUIRED)

@chausner Would seem like the fixup PACKAGE_NAME part is missing here

vcpkg_from_github(
    OUT_SOURCE_PATH SOURCE_PATH
    REPO effolkronium/random
    REF v1.4.0
    SHA512 B3DDEC048BBFB48877FD12295D4E0492E25976E1C4FE66F13E9E6E611DAAF654BD8D4AE75EA75125CB5AB420B82472C1CC1AB0BED3AEF632911B0934B45B23AF
    HEAD_REF master
)

vcpkg_cmake_configure(
    SOURCE_PATH "${SOURCE_PATH}"
    OPTIONS
		-DRandom_BuildTests=OFF
)
vcpkg_cmake_install()
vcpkg_cmake_config_fixup(PACKAGE_NAME "effolkronium_random" CONFIG_PATH "cmake")
vcpkg_fixup_pkgconfig()

file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug" "${CURRENT_PACKAGES_DIR}/lib")
file(INSTALL "${SOURCE_PATH}/LICENSE.MIT" DESTINATION "${CURRENT_PACKAGES_DIR}/share/${PORT}" RENAME copyright)

Works fine but changes find_package(effolkronium-random) to find_package(effolkronium_random)
If we need to support the old find_package name we would probably need to rename the cmake config files.
But it did not work with find_package(effolkronium-random) in the previous version you had to use find_package(effolkronium_random)
I do not really have experience with pull requests I could try to make do one.

Im not sure if this part "CONFIG_PATH "cmake" takes into account debug/cmake/*.cmake files

@michaelkroener michaelkroener mentioned this pull request Oct 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chausner @strega-nil-ms @michaelkroener