[gpgerror] build on Windows using vanilla source by wrobelda · Pull Request #20447 · microsoft/vcpkg

wrobelda · 2021-09-30T17:59:25Z

This replaces usage of SMP fork with a vanilla source for Windows builds

Depends on:

[vcpkg_acquire_msys] Add gzip to default packages #20393
Which triplets are supported/not supported? Have you updated the CI baseline?

Removes support for ARM on UWP and Windows (currently fails to build). https://dev.gnupg.org/T5687 for the reference.
Does your PR follow the maintainer guide?

Yes
If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 8ad33ead9075cd8d6d357e0b870ba8d501efe35c -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index d190798..43d958e 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3402,7 +3402,7 @@
     },
     "libgpg-error": {
       "baseline": "1.42",
-      "port-version": 1
+      "port-version": 2
     },
     "libgpod": {
       "baseline": "2019-08-29",
diff --git a/versions/l-/libgpg-error.json b/versions/l-/libgpg-error.json
index 395eb94..d174c05 100644
--- a/versions/l-/libgpg-error.json
+++ b/versions/l-/libgpg-error.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "81c5626a051c7cf6490652da04076a2cf20122e1",
+      "version": "1.42",
+      "port-version": 2
+    },
     {
       "git-tree": "b5abbf9cf832337e202ff5d8d4296025b47be1a0",
       "version": "1.42",

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 8ad33ead9075cd8d6d357e0b870ba8d501efe35c -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index d190798..43d958e 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3402,7 +3402,7 @@
     },
     "libgpg-error": {
       "baseline": "1.42",
-      "port-version": 1
+      "port-version": 2
     },
     "libgpod": {
       "baseline": "2019-08-29",
diff --git a/versions/l-/libgpg-error.json b/versions/l-/libgpg-error.json
index 395eb94..ec15a01 100644
--- a/versions/l-/libgpg-error.json
+++ b/versions/l-/libgpg-error.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "c191411a9e4ae6b55b5ac65c65886c74c4b8e9e3",
+      "version": "1.42",
+      "port-version": 2
+    },
     {
       "git-tree": "b5abbf9cf832337e202ff5d8d4296025b47be1a0",
       "version": "1.42",

ports/libgpg-error/portfile.cmake

wrobelda · 2021-11-14T23:01:50Z

ARM cross-compilation reported upstream: https://dev.gnupg.org/T5687

wrobelda · 2021-11-14T23:05:49Z

Regarding the x64-uwp, the error is:

compile cl.exe -E -I. -I.././../src/error-1.43-dfb1333f1a.clean/src -I..   _gpg-error.def.h | \
  grep -v '^#' >gpg-error.def
rm _gpg-error.def.h
Microsoft (R) Incremental Linker Version 14.29.30137.0
Copyright (C) Microsoft Corporation.  All rights reserved.

/out:mkheader.exe 
mkheader.obj 
WindowsApp.lib WindowsApp.lib /MANIFEST /DYNAMICBASE /WINMD:NO /APPCONTAINER 
LINK : fatal error LNK1104: cannot open file 'LIBCMT.lib'

Looks like a Spectre-mitigation issue: https://stackoverflow.com/questions/9356135/link-fatal-error-lnk-1104-cannot-open-file-libcmt-lib#comment106230725_53212863

wrobelda · 2022-04-19T12:51:27Z

Regarding the x64-uwp, the error is:
compile cl.exe -E -I. -I.././../src/error-1.43-dfb1333f1a.clean/src -I..   _gpg-error.def.h | \
  grep -v '^#' >gpg-error.def
rm _gpg-error.def.h
Microsoft (R) Incremental Linker Version 14.29.30137.0
Copyright (C) Microsoft Corporation.  All rights reserved.

/out:mkheader.exe 
mkheader.obj 
WindowsApp.lib WindowsApp.lib /MANIFEST /DYNAMICBASE /WINMD:NO /APPCONTAINER 
LINK : fatal error LNK1104: cannot open file 'LIBCMT.lib'
Looks like a Spectre-mitigation issue: https://stackoverflow.com/questions/9356135/link-fatal-error-lnk-1104-cannot-open-file-libcmt-lib#comment106230725_53212863

@Neumann-A would you be able to takie this over from me? I am out of free time recently and this rewrite was almost complete, except ARM on UWP and Windows fails to build due to error quoted. Alternatively, it could be pushed upstream as-is, with the support for said platforms removed.

@ras0219-msft would appreciate your feedback here, as well.

EDIT: I rebased the code against master.

EDIT2: I updated to 1.45 and oddly getting a gettext infrastructure mismatch: using a Makefile.in.in from gettext version 0.19 but the autoconf macros are from gettext version 0.20 error now. First time I see it. I assumed forcing autoreconf with vcpkg's own gettext in PATH would do the trick, but it doesn't. Now fixed.

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/libgpg-error/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/libgpg-error/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/libgpg-error/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/libgpg-error/vcpkg.json

Valid values for the license field can be found in the documentation

wrobelda · 2022-04-19T18:00:06Z

@PhoebeHui this is now ready for a review. As noted above , support for UWP and ARM on Windows is removed. Both issues potentially fixable, but currently beyond my time resources.

Neumann-A · 2022-04-19T18:49:20Z

except ARM on UWP and Windows fails to build due to error quoted.

the error looks like the port is using CC_FOR_BUILD and the portfile is not correctly setup to deal with crosscompilation
LINK : fatal error LNK1104: cannot open file 'LIBCMT.lib' basically means something is not getting the correct build flags and has the implicit default /DEFAULTLIB:LIBCMT.lib

JackBoosY · 2022-06-24T07:58:39Z

Please temporary close this PR if you don't have spare time to finish it.

JackBoosY · 2022-07-15T05:33:34Z

Closing this PR since it seems that no progress is being made. Please reopen if work is still being done.

wrobelda · 2022-08-15T19:09:05Z

@JackBoosY can you reopen this PR, please?

LilyWangLL · 2022-08-16T01:53:41Z

@wrobelda We can't reopen this PR, because the GitHub remind this branch was force-pushed or recreated as below:

You can create a new PR to commit these changes. Thanks~

github-actions bot approved these changes Sep 30, 2021

View reviewed changes

wrobelda force-pushed the gpgerror_vanilla branch from e79b7fe to 9ab9e1f Compare September 30, 2021 18:26

github-actions bot requested changes Sep 30, 2021

View reviewed changes

wrobelda force-pushed the gpgerror_vanilla branch from 9ab9e1f to 73a7691 Compare September 30, 2021 18:32

github-actions bot requested changes Sep 30, 2021

View reviewed changes

github-actions bot approved these changes Sep 30, 2021

View reviewed changes

wrobelda force-pushed the gpgerror_vanilla branch from a37ede3 to ffec0d1 Compare September 30, 2021 18:47

github-actions bot approved these changes Sep 30, 2021

View reviewed changes

github-actions bot approved these changes Oct 5, 2021

View reviewed changes

PhoebeHui self-assigned this Oct 8, 2021

PhoebeHui added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Oct 8, 2021

cenit reviewed Oct 8, 2021

View reviewed changes

ports/libgpg-error/portfile.cmake Outdated Show resolved Hide resolved

wrobelda mentioned this pull request Oct 13, 2021

[shiftmedia-gnutls] new port (Windows fork of GnuTLS) #18029

Merged

wrobelda force-pushed the gpgerror_vanilla branch from f9642b2 to 00a6dd1 Compare November 14, 2021 21:30

github-actions bot approved these changes Nov 14, 2021

View reviewed changes

wrobelda force-pushed the gpgerror_vanilla branch from 00a6dd1 to 70e1fb4 Compare November 14, 2021 23:09

github-actions bot approved these changes Nov 14, 2021

View reviewed changes

[libgpg-error] build on Windows using vanilla

ddeff11

wrobelda force-pushed the gpgerror_vanilla branch from 70e1fb4 to 555bdfd Compare April 19, 2022 13:05