Skip to content

[kf5codecs] add explicit gperf dependency#20266

Merged
BillyONeal merged 9 commits intomicrosoft:masterfrom
wrobelda:kf5codecs_gperf_fix
Oct 27, 2021
Merged

[kf5codecs] add explicit gperf dependency#20266
BillyONeal merged 9 commits intomicrosoft:masterfrom
wrobelda:kf5codecs_gperf_fix

Conversation

@wrobelda
Copy link
Copy Markdown
Contributor

@wrobelda wrobelda commented Sep 20, 2021

Describe the pull request

  • What does your PR fix?

    This prevents built failures on macOS with its outdated GNU gperf 3.0.3 that chokes on kf5codec's 'register' specifiers.
    Also wraps paths in quotes and removes the line deleting /etc, which isn't being populated.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    No change.

  • Does your PR follow the maintainer guide?

    No change.

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Sep 22, 2021
JackBoosY
JackBoosY suggested changes Sep 22, 2021
View reviewed changes
@JackBoosY JackBoosY added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Sep 23, 2021
BillyONeal
BillyONeal requested changes Sep 24, 2021
View reviewed changes
@BillyONeal BillyONeal added requires:author-response and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Sep 24, 2021
github-actions[bot]
github-actions bot requested changes Sep 24, 2021
View reviewed changes
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated 
git add -u && git commit
git checkout 8275003fd8c5119cb9438fea1425ebe774f2e527 -- versions
./vcpkg x-add-version --all
Diff 
diff --git a/versions/k-/kf5codecs.json b/versions/k-/kf5codecs.json
index 92131ab..97dd3eb 100644
--- a/versions/k-/kf5codecs.json
+++ b/versions/k-/kf5codecs.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "1d73ea7605ea09c70422ab94b8d3f7ce96739df2",
+      "git-tree": "dc0771047423064842c3d9cf2caddab57b6d67c8",
       "version": "5.84.0",
       "port-version": 3
     },

@JackBoosY
Copy link
Copy Markdown
Contributor

JackBoosY commented Sep 27, 2021

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Sep 27, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Copy Markdown
Contributor

JackBoosY commented Sep 27, 2021

Please get failure logs here.

@wrobelda wrobelda force-pushed the kf5codecs_gperf_fix branch from eecb0b5 to e232a43 Compare October 19, 2021 23:38
@wrobelda
Copy link
Copy Markdown
Contributor Author

wrobelda commented Oct 19, 2021 •
edited
Loading

@JackBoosY I addressed @BillyONeal concern, all issues are fixed now.

EDIT: sorry, still has an issue, see comment above

@wrobelda wrobelda force-pushed the kf5codecs_gperf_fix branch from e232a43 to eebbb53 Compare October 19, 2021 23:40
@JackBoosY
Copy link
Copy Markdown
Contributor

JackBoosY commented Oct 20, 2021 

[102/142] cd /mnt/vcpkg-ci/buildtrees/kf5codecs/x64-linux-dbg/src && /mnt/vcpkg-ci/buildtrees/kf5codecs/x64-linux-dbg/\"/usr/bin/gperf\" "--key-positions=*" -D -s 2 --output-file=/mnt/vcpkg-ci/buildtrees/kf5codecs/x64-linux-dbg/src/kentities.h /mnt/vcpkg-ci/buildtrees/kf5codecs/src/v5.84.0-430ab2609a.clean/src/kentities.gperf
FAILED: src/kentities.h /mnt/vcpkg-ci/buildtrees/kf5codecs/x64-linux-dbg/src/kentities.h 
cd /mnt/vcpkg-ci/buildtrees/kf5codecs/x64-linux-dbg/src && /mnt/vcpkg-ci/buildtrees/kf5codecs/x64-linux-dbg/\"/usr/bin/gperf\" "--key-positions=*" -D -s 2 --output-file=/mnt/vcpkg-ci/buildtrees/kf5codecs/x64-linux-dbg/src/kentities.h /mnt/vcpkg-ci/buildtrees/kf5codecs/src/v5.84.0-430ab2609a.clean/src/kentities.gperf
/bin/sh: 1: /mnt/vcpkg-ci/buildtrees/kf5codecs/x64-linux-dbg/"/usr/bin/gperf": not found
ninja: build stopped: subcommand failed

gperf should be find above vcpkg_configure_make and set it to the environment PATH using vcpkg_add_path.

dg0yt
dg0yt reviewed Oct 20, 2021
View reviewed changes
@wrobelda wrobelda force-pushed the kf5codecs_gperf_fix branch from 36b5775 to 94ef400 Compare October 20, 2021 09:47
@wrobelda wrobelda force-pushed the kf5codecs_gperf_fix branch from 94ef400 to 44a31a3 Compare October 20, 2021 22:48
@wrobelda
Copy link
Copy Markdown
Contributor Author

wrobelda commented Oct 20, 2021

@JackBoosY all issues were fixed, although the CI has some hiccups.

@JackBoosY
Copy link
Copy Markdown
Contributor

JackBoosY commented Oct 21, 2021

@wrobelda Yes, we are handling this.

@JackBoosY JackBoosY added depends:different-pr This PR or Issue depends on a PR which has been filed and removed depends:different-pr This PR or Issue depends on a PR which has been filed labels Oct 21, 2021
@JackBoosY JackBoosY requested a review from BillyONeal October 21, 2021 10:03
@JackBoosY JackBoosY added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. labels Oct 22, 2021
@wrobelda wrobelda mentioned this pull request Oct 22, 2021
Merged
3 tasks
@BillyONeal BillyONeal merged commit e37021e into microsoft:master Oct 27, 2021
@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Oct 27, 2021

Thanks for working through the CI mess!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@BillyONeal BillyONeal Awaiting requested review from BillyONeal

+2 more reviewers

@dg0yt dg0yt dg0yt left review comments

@JackBoosY JackBoosY JackBoosY approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JackBoosY JackBoosY

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wrobelda @JackBoosY @BillyONeal @dg0yt