[scripts-audit] Make buildsystem by JackBoosY · Pull Request #20165 · microsoft/vcpkg

JackBoosY · 2021-09-15T06:53:44Z

Audit the Makefile build system according to the documentation.

Related: #17691

Depends on PR [scripts-audit] vcpkg_fixup_pkgconfig #19658

scripts/cmake/vcpkg_configure_make.cmake

JackBoosY · 2021-09-16T02:17:47Z

/azp run

azure-pipelines · 2021-09-16T02:17:57Z

Azure Pipelines successfully started running 1 pipeline(s).

JackBoosY · 2021-09-16T08:53:02Z

@BillyONeal Can you investigate on the crash issue?

Building package icu[core]:x64-windows-static-md...
Error: vcpkg has crashed; no additional details are available.

https://dev.azure.com/vcpkg/public/_build/results?buildId=59690&view=logs&j=36cc18b5-b00b-5122-dfd2-906b0f3945db&t=a2fc3f1b-543d-5cac-7a17-d6646137a2ea

Thanks.

JackBoosY · 2021-09-17T08:14:17Z

Crashed in this line -> https://github.com/microsoft/vcpkg-tool/blob/main/src/vcpkg/build.cpp#L1238:

 Checks::check_exit(VCPKG_LINE_INFO, status_it != status_db.end());

The pipeline log shows:

2021-09-16T09:56:13.3841766Z Starting package 180/622: icu:x64-windows
2021-09-16T09:56:13.3849146Z Building package icu[core]:x64-windows...
...
2021-09-16T09:57:43.6733894Z -- Building x64-windows-dbg
2021-09-16T09:57:43.6741382Z CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:155 (message):
2021-09-16T09:57:43.6748794Z     Command failed: D:/downloads/tools/msys2/8a1f6fda6ae3aa5c/usr/bin/make.exe -j 33 --trace -f Makefile all
2021-09-16T09:57:43.6756061Z     Working Directory: D:/buildtrees/icu/x64-windows-dbg
2021-09-16T09:57:43.6763636Z     See logs for more information:
2021-09-16T09:57:43.6771269Z       D:\buildtrees\icu\build-x64-windows-dbg-out.log
2021-09-16T09:57:43.6778924Z       D:\buildtrees\icu\build-x64-windows-dbg-err.log
2021-09-16T09:57:43.6781989Z 
2021-09-16T09:57:43.6789692Z Call Stack (most recent call first):
2021-09-16T09:57:43.6799368Z   scripts/cmake/vcpkg_build_make.cmake:198 (vcpkg_execute_build_process)
2021-09-16T09:57:43.6806698Z   scripts/cmake/vcpkg_install_make.cmake:26 (vcpkg_build_make)
2021-09-16T09:57:43.6813904Z   ports/icu/portfile.cmake:124 (vcpkg_install_make)
2021-09-16T09:57:43.6821118Z   scripts/ports.cmake:140 (include)
2021-09-16T09:57:43.6823851Z 
2021-09-16T09:57:43.6826742Z 
2021-09-16T09:57:43.6834235Z Error: Building package icu:x64-windows failed with: BUILD_FAILED
2021-09-16T09:57:43.6841328Z Elapsed time for package icu:x64-windows: 1.506 min
2021-09-16T09:57:43.6848387Z Starting package 181/622: icu:x86-windows
2021-09-16T09:57:43.6855752Z Building package icu[core]:x86-windows...
2021-09-16T09:57:43.6862931Z Error: vcpkg has crashed; no additional details are available.
2021-09-16T09:57:43.6870127Z The source line is D:\a\_work\1\s\src\vcpkg\build.cpp(1238)

Even if --keep-going was added, since icu is a host port, icu[core]:x86-windows requires icu[core]:x64-windows. So what is expected is to stop building icu[core]:x86-windows after the build of icu[core]:x64-windows fails. But it doesn't.

Confirmed, I can use this branch and command ./vcpkg install icu[core]:x86-windows --keepgoing to reproduce this issue,

dg0yt · 2021-09-18T11:37:42Z

I just noticed that you have another open PR with the same title: #19753.

scripts/cmake/vcpkg_build_make.cmake

BillyONeal · 2021-09-20T19:37:31Z

Crashed in this line -> https://github.com/microsoft/vcpkg-tool/blob/main/src/vcpkg/build.cpp#L1238:

 Checks::check_exit(VCPKG_LINE_INFO, status_it != status_db.end());

The pipeline log shows:

2021-09-16T09:56:13.3841766Z Starting package 180/622: icu:x64-windows
2021-09-16T09:56:13.3849146Z Building package icu[core]:x64-windows...
...
2021-09-16T09:57:43.6733894Z -- Building x64-windows-dbg
2021-09-16T09:57:43.6741382Z CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:155 (message):
2021-09-16T09:57:43.6748794Z     Command failed: D:/downloads/tools/msys2/8a1f6fda6ae3aa5c/usr/bin/make.exe -j 33 --trace -f Makefile all
2021-09-16T09:57:43.6756061Z     Working Directory: D:/buildtrees/icu/x64-windows-dbg
2021-09-16T09:57:43.6763636Z     See logs for more information:
2021-09-16T09:57:43.6771269Z       D:\buildtrees\icu\build-x64-windows-dbg-out.log
2021-09-16T09:57:43.6778924Z       D:\buildtrees\icu\build-x64-windows-dbg-err.log
2021-09-16T09:57:43.6781989Z 
2021-09-16T09:57:43.6789692Z Call Stack (most recent call first):
2021-09-16T09:57:43.6799368Z   scripts/cmake/vcpkg_build_make.cmake:198 (vcpkg_execute_build_process)
2021-09-16T09:57:43.6806698Z   scripts/cmake/vcpkg_install_make.cmake:26 (vcpkg_build_make)
2021-09-16T09:57:43.6813904Z   ports/icu/portfile.cmake:124 (vcpkg_install_make)
2021-09-16T09:57:43.6821118Z   scripts/ports.cmake:140 (include)
2021-09-16T09:57:43.6823851Z 
2021-09-16T09:57:43.6826742Z 
2021-09-16T09:57:43.6834235Z Error: Building package icu:x64-windows failed with: BUILD_FAILED
2021-09-16T09:57:43.6841328Z Elapsed time for package icu:x64-windows: 1.506 min
2021-09-16T09:57:43.6848387Z Starting package 181/622: icu:x86-windows
2021-09-16T09:57:43.6855752Z Building package icu[core]:x86-windows...
2021-09-16T09:57:43.6862931Z Error: vcpkg has crashed; no additional details are available.
2021-09-16T09:57:43.6870127Z The source line is D:\a\_work\1\s\src\vcpkg\build.cpp(1238)

Even if --keep-going was added, since icu is a host port, icu[core]:x86-windows requires icu[core]:x64-windows. So what is expected is to stop building icu[core]:x86-windows after the build of icu[core]:x64-windows fails. But it doesn't.

Confirmed, I can use this branch and command ./vcpkg install icu[core]:x86-windows --keepgoing to reproduce this issue,

This happens whenever a port depends on a host-port, and the host-port build failed.

…jack/script-audit-make

strega-nil-ms

Hopefully you get some good things to look at so that you can continue making these changes.

scripts/cmake/vcpkg_build_make.cmake

…oosY/vcpkg into dev/jack/script-audit-make

JackBoosY · 2021-10-12T00:27:29Z

@strega-nil-ms Do you have any suggestions?

scripts/cmake/vcpkg_backup_restore_env_vars.cmake

strega-nil · 2021-10-12T00:49:50Z

@JackBoosY this is all that I see that needs to be done, thanks!

…jack/script-audit-make

JackBoosY · 2021-10-13T06:24:56Z

@strega-nil-ms Ready for merge 🚀

strega-nil-ms

Merge as soon as green! :)

JackBoosY · 2021-10-19T00:33:38Z

@strega-nil-ms All green now! 🤖

strega-nil-ms · 2021-10-20T21:13:07Z

Thank you so much @JackBoosY for this <3

gerard-ryan-immersaview · 2022-08-23T02:01:45Z

This PR introduces some undocumented changes.
VCPKG_MAKE_CONFIGURE_OPTIONS -> VCPKG_CONFIGURE_MAKE_OPTIONS

Relevent Triplet Files documentation

KUGA2 · 2023-08-23T14:24:43Z

This PR introduces some undocumented changes. VCPKG_MAKE_CONFIGURE_OPTIONS -> VCPKG_CONFIGURE_MAKE_OPTIONS

Relevent Triplet Files documentation

I just added an issue there.

[script-audit] Make buildsystem

b23ce77

JackBoosY added info:internal category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly labels Sep 15, 2021

JackBoosY assigned PhoebeHui Sep 15, 2021

JackBoosY mentioned this pull request Sep 15, 2021

[scripts-audit] Scripts tree auditing #17691

Closed

51 tasks

JackBoosY added the category:scripts-audit label Sep 15, 2021

JackBoosY changed the title ~~[script-audit] Make buildsystem~~ [scripts-audit] Make buildsystem Sep 15, 2021

JackBoosY requested a review from strega-nil-ms September 15, 2021 06:55

JackBoosY added the info:world-rebuild label Sep 15, 2021

github-actions bot approved these changes Sep 15, 2021

View reviewed changes

dg0yt reviewed Sep 15, 2021

View reviewed changes

scripts/cmake/vcpkg_configure_make.cmake Show resolved Hide resolved

Fix wrongly merge

ead2251

github-actions bot approved these changes Sep 16, 2021

View reviewed changes

Fix rename

de62209

github-actions bot approved these changes Sep 16, 2021

View reviewed changes

dg0yt reviewed Sep 18, 2021

View reviewed changes

scripts/cmake/vcpkg_build_make.cmake Outdated Show resolved Hide resolved

Merge remote-tracking branch 'origin/master' into HEAD

a40a1e5

github-actions bot approved these changes Sep 20, 2021

View reviewed changes

Merge branch 'master' of https://github.com/microsoft/vcpkg into dev/…

9271826

…jack/script-audit-make

strega-nil-ms suggested changes Sep 22, 2021

View reviewed changes

JackBoosY mentioned this pull request Sep 23, 2021

[icu] Fix mingw builds #20253

Merged

JackBoosY added 2 commits September 22, 2021 23:28

Format

0707b07

Merge branch 'dev/jack/script-audit-make' of https://github.com/JackB…

1d59c0b

…oosY/vcpkg into dev/jack/script-audit-make

github-actions bot approved these changes Sep 23, 2021

View reviewed changes

github-actions bot approved these changes Oct 9, 2021

View reviewed changes

Fix un=parser code, move macros to the top

0253abd

github-actions bot approved these changes Oct 11, 2021

View reviewed changes

strega-nil suggested changes Oct 12, 2021

View reviewed changes

scripts/cmake/vcpkg_backup_restore_env_vars.cmake Outdated Show resolved Hide resolved

scripts/cmake/vcpkg_backup_restore_env_vars.cmake Outdated Show resolved Hide resolved

scripts/cmake/vcpkg_backup_restore_env_vars.cmake Outdated Show resolved Hide resolved

JackBoosY added 2 commits October 11, 2021 20:00

Apply suggestions

ba71ca8

Update docs

7ec1b49

github-actions bot approved these changes Oct 12, 2021

View reviewed changes

update doc

7bf63d1

github-actions bot approved these changes Oct 12, 2021

View reviewed changes

Merge branch 'master' of https://github.com/microsoft/vcpkg into dev/…

4aacf21

…jack/script-audit-make

github-actions bot approved these changes Oct 12, 2021

View reviewed changes

CRLF

46cb8cd

github-actions bot approved these changes Oct 12, 2021

View reviewed changes

JackBoosY requested a review from strega-nil-ms October 13, 2021 06:25

JackBoosY added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Oct 14, 2021

add docs and add a PARENT_SCOPE

bb7c9e5

github-actions bot approved these changes Oct 15, 2021

View reviewed changes

Update doc

6ea7693

github-actions bot approved these changes Oct 18, 2021

View reviewed changes

strega-nil-ms approved these changes Oct 18, 2021

View reviewed changes

strega-nil-ms merged commit 5283cdb into microsoft:master Oct 20, 2021

JackBoosY deleted the dev/jack/script-audit-make branch October 21, 2021 02:28

KUGA2 mentioned this pull request Aug 23, 2023

Rename VCPKG_MAKE_CONFIGURE_OPTIONS -> VCPKG_CONFIGURE_MAKE_OPTIONS not documented MicrosoftDocs/vcpkg-docs#137

Closed

Conversation

JackBoosY commented Sep 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

JackBoosY commented Sep 16, 2021

Uh oh!

azure-pipelines bot commented Sep 16, 2021

Uh oh!

JackBoosY commented Sep 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JackBoosY commented Sep 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dg0yt commented Sep 18, 2021

Uh oh!

Uh oh!

BillyONeal commented Sep 20, 2021

Uh oh!

strega-nil-ms left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JackBoosY commented Oct 12, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

strega-nil commented Oct 12, 2021

Uh oh!

JackBoosY commented Oct 13, 2021

Uh oh!

strega-nil-ms left a comment

Choose a reason for hiding this comment

Uh oh!

JackBoosY commented Oct 19, 2021

Uh oh!

strega-nil-ms commented Oct 20, 2021

Uh oh!

gerard-ryan-immersaview commented Aug 23, 2022

Uh oh!

KUGA2 commented Aug 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

JackBoosY commented Sep 15, 2021 •

edited

Loading

JackBoosY commented Sep 16, 2021 •

edited

Loading

JackBoosY commented Sep 17, 2021 •

edited

Loading