[libgxps] Add new port by c72578 · Pull Request #20062 · microsoft/vcpkg

c72578 · 2021-09-08T20:05:48Z

Describe the pull request

What does your PR fix?

Add new port libgxps, version 0.3.2
libgxps is a GObject based library for handling and rendering XPS documents.
https://gitlab.gnome.org/GNOME/libgxps
Which triplets are supported/not supported? Have you updated the CI baseline?

all, No
- x64-linux (fixed by [libarchive,lz4] Fix pc file, modernize portfile #20146)
Does your PR follow the maintainer guide?

Yes
If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

c72578 · 2021-09-08T20:30:43Z

package-x64-linux-dbg-out.log

[36/43] /usr/bin/cc  -o libgxps/libgxps.so.2.2.4 libgxps/libgxps.so.2.2.4.p/gxps-archive.c.o libgxps/libgxps.so.2.2.4.p/gxps-fonts.c.o libgxps/libgxps.so.2.2.4.p/gxps-images.c.o libgxps/libgxps.so.2.2.4.p/gxps-parse-utils.c.o libgxps/libgxps.so.2.2.4.p/gxps-resources.c.o libgxps/libgxps.so.2.2.4.p/gxps-brush.c.o libgxps/libgxps.so.2.2.4.p/gxps-color.c.o libgxps/libgxps.so.2.2.4.p/gxps-core-properties.c.o libgxps/libgxps.so.2.2.4.p/gxps-debug.c.o libgxps/libgxps.so.2.2.4.p/gxps-document.c.o libgxps/libgxps.so.2.2.4.p/gxps-document-structure.c.o libgxps/libgxps.so.2.2.4.p/gxps-error.c.o libgxps/libgxps.so.2.2.4.p/gxps-file.c.o libgxps/libgxps.so.2.2.4.p/gxps-glyphs.c.o libgxps/libgxps.so.2.2.4.p/gxps-links.c.o libgxps/libgxps.so.2.2.4.p/gxps-matrix.c.o libgxps/libgxps.so.2.2.4.p/gxps-page.c.o libgxps/libgxps.so.2.2.4.p/gxps-path.c.o -L/mnt/vcpkg-ci/installed/x64-linux/debug/lib -Wl,--as-needed -Wl,--no-undefined -shared -fPIC -Wl,--start-group -Wl,-soname,libgxps.so.2 -Wl,-Bsymbolic /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libglib-2.0.a -pthread /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libpcre.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libgobject-2.0.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libffi.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libgio-2.0.a -ldl /usr/lib/gcc/x86_64-linux-gnu/9/../../../x86_64-linux-gnu/libresolv.so /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libgmodule-2.0.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libz.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libcairo.a -lm /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/liblzo2.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libfontconfig.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libuuid.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libexpat.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libfreetyped.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libbz2d.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libpng16d.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libbrotlidec-static.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libbrotlicommon-static.a /usr/lib/x86_64-linux-gnu/libXext.so /usr/lib/x86_64-linux-gnu/libXrender.so /usr/lib/x86_64-linux-gnu/libX11.so /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libpixman-1.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libarchive.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libxml2.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/liblzmad.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libssl.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libcrypto.a -L/mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib -loptimized -ldebug -lbz2 -lLibLZMA::LibLZMA -llz4::lz4 -lzstd::libzstd_static -lOpenSSL::Crypto -llzma -l-pthread /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/liblcms2d.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libjpeg.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libtiffd.a -Wl,--end-group
FAILED: libgxps/libgxps.so.2.2.4 
/usr/bin/cc  -o libgxps/libgxps.so.2.2.4 libgxps/libgxps.so.2.2.4.p/gxps-archive.c.o libgxps/libgxps.so.2.2.4.p/gxps-fonts.c.o libgxps/libgxps.so.2.2.4.p/gxps-images.c.o libgxps/libgxps.so.2.2.4.p/gxps-parse-utils.c.o libgxps/libgxps.so.2.2.4.p/gxps-resources.c.o libgxps/libgxps.so.2.2.4.p/gxps-brush.c.o libgxps/libgxps.so.2.2.4.p/gxps-color.c.o libgxps/libgxps.so.2.2.4.p/gxps-core-properties.c.o libgxps/libgxps.so.2.2.4.p/gxps-debug.c.o libgxps/libgxps.so.2.2.4.p/gxps-document.c.o libgxps/libgxps.so.2.2.4.p/gxps-document-structure.c.o libgxps/libgxps.so.2.2.4.p/gxps-error.c.o libgxps/libgxps.so.2.2.4.p/gxps-file.c.o libgxps/libgxps.so.2.2.4.p/gxps-glyphs.c.o libgxps/libgxps.so.2.2.4.p/gxps-links.c.o libgxps/libgxps.so.2.2.4.p/gxps-matrix.c.o libgxps/libgxps.so.2.2.4.p/gxps-page.c.o libgxps/libgxps.so.2.2.4.p/gxps-path.c.o -L/mnt/vcpkg-ci/installed/x64-linux/debug/lib -Wl,--as-needed -Wl,--no-undefined -shared -fPIC -Wl,--start-group -Wl,-soname,libgxps.so.2 -Wl,-Bsymbolic /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libglib-2.0.a -pthread /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libpcre.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libgobject-2.0.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libffi.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libgio-2.0.a -ldl /usr/lib/gcc/x86_64-linux-gnu/9/../../../x86_64-linux-gnu/libresolv.so /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libgmodule-2.0.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libz.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libcairo.a -lm /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/liblzo2.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libfontconfig.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libuuid.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libexpat.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libfreetyped.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libbz2d.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libpng16d.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libbrotlidec-static.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libbrotlicommon-static.a /usr/lib/x86_64-linux-gnu/libXext.so /usr/lib/x86_64-linux-gnu/libXrender.so /usr/lib/x86_64-linux-gnu/libX11.so /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libpixman-1.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libarchive.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libxml2.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/liblzmad.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libssl.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libcrypto.a -L/mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib -loptimized -ldebug -lbz2 -lLibLZMA::LibLZMA -llz4::lz4 -lzstd::libzstd_static -lOpenSSL::Crypto -llzma -l-pthread /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/liblcms2d.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libjpeg.a /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/../../lib/libtiffd.a -Wl,--end-group
/usr/bin/ld: cannot find -loptimized
/usr/bin/ld: cannot find -ldebug
/usr/bin/ld: cannot find -lbz2
/usr/bin/ld: cannot find -lLibLZMA::LibLZMA
/usr/bin/ld: cannot find -llz4::lz4
/usr/bin/ld: cannot find -lzstd::libzstd_static
/usr/bin/ld: cannot find -lOpenSSL::Crypto
/usr/bin/ld: cannot find -llzma
/usr/bin/ld: cannot find -l-pthread
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.

failure logs for x64-linux.zip

dg0yt · 2021-09-09T05:33:55Z

The build seems to get cmake-style linking information from a dependency, probably via a .pc file. This would be a bug in that .pc file. Check the list of dependencies, in particular cairo, lcms.

c72578 · 2021-09-09T19:31:28Z

The broken linking information is coming from libarchive.pc under x64-linux.

libarchive.pc x64-linux:

prefix=${pcfiledir}/../..

exec_prefix=${prefix}
libdir=${exec_prefix}/lib
includedir=${prefix}/include

Name: libarchive
Description: library that can create and read several streaming archive formats
Version: 3.4.3
Cflags: -I"${includedir}"
Cflags.private: -DLIBARCHIVE_STATIC
Libs: -L"${libdir}" -larchive  -loptimized -lz -ldebug -lz -loptimized -lbz2 -ldebug -lbz2d -lLibLZMA::LibLZMA -llz4::lz4 -lzstd::libzstd_static -lOpenSSL::Crypto -loptimized -lxml2 -ldebug -lxml2 -loptimized -llzma -ldebug -llzmad -loptimized -lz -ldebug -lz -lm -lssl -lcrypto -l-pthread -ldl -ldl -l-pthread -lssl -lcrypto -l-pthread -ldl -ldl -l-pthread -lssl -lcrypto -l-pthread -ldl -ldl -l-pthread -lssl -lcrypto -l-pthread -ldl -ldl -l-pthread -lssl -lcrypto -l-pthread -ldl -ldl -l-pthread -lssl -lcrypto -l-pthread -ldl -ldl -l-pthread -lxml2 -lz -llzma -lm

For comparison:
libarchive.pc x64-windows

prefix=${pcfiledir}/../..

exec_prefix=${prefix}
libdir=${exec_prefix}/lib
includedir=${prefix}/include

Name: libarchive
Description: library that can create and read several streaming archive formats
Version: 3.4.3
Cflags: -I"${includedir}"
Cflags.private: -DLIBARCHIVE_STATIC
Libs: -L"${libdir}" -larchive
Libs.private:  -loptimized -lzlib -ldebug -lzlibd -loptimized -lbz2 -ldebug -lbz2d -lLibLZMA::LibLZMA -llz4::lz4 -lzstd::libzstd_shared -lOpenSSL::Crypto -lxml2 -lssl -lcrypto -lssl -lcrypto -lssl -lcrypto -lssl -lcrypto -lssl -lcrypto -lssl -lcrypto

libarchive.pc.in

prefix=@prefix@
exec_prefix=@exec_prefix@
libdir=@libdir@
includedir=@includedir@

Name: libarchive
Description: library that can create and read several streaming archive formats
Version: @VERSION@
Cflags: -I${includedir}
Cflags.private: -DLIBARCHIVE_STATIC
Libs: -L${libdir} -larchive
Libs.private: @LIBS@

This means, that under x64-linux, Libs.private: is deleted from libarchive.pc, and all the linking information shows up under Libs:

The original buildtrees/libarchive/x64-linux-rel/build/pkgconfig/libarchive.pc contains Libs.private:, which is removed during vcpkg_fixup_pkgconfig()

c72578 · 2021-09-09T20:01:11Z

Link to current REGEX REPLACE code by vcpkg_fixup_pkgconfig.cmake:

vcpkg/scripts/cmake/vcpkg_fixup_pkgconfig.cmake

Line 165 in b295670

# Libs comes before Libs.private

dg0yt · 2021-09-09T20:03:48Z

Thanks for the research.

The original buildtrees/libarchive/x64-linux-rel/build/pkgconfig/libarchive.pc is OK

I don't think so. I guess the wrong data is already there, in Libs.private.

IMO the prefered fix is to get rid of explicit Libs which have a pkgconfig module, and refer to this module via Requires.private.

c72578 · 2021-09-10T05:07:26Z

@dg0yt thanks for the feedback.
This means, that libarchive needs to be fixed, so that it produces a valid libarchive.pc, without the additional, incorrect entries in Libs.private.

JonLiu1993 · 2021-09-10T09:31:41Z

@c72578 ,So this pr depends #16845 fix?

dg0yt · 2021-09-10T10:18:37Z

@JonLiu1993 This PR depends on a libarchive fix. #16845 doesn't include such a fix AFAICT but it is the best candidate to fix this as well.

dg0yt · 2021-09-11T06:39:31Z

I do have preliminary work to fix the libarchive pc file (dg0yt@ae67ab7), based on #16845 and #20108. With the usual speed of merges in vcpkg, the timeframe is going to be several weeks...

c72578 · 2021-09-11T06:41:24Z

@dg0yt That's great, thanks for working on it.

JonLiu1993 · 2021-09-13T03:11:20Z

@dg0yt ,Thanks for your contribution.

JonLiu1993 · 2021-09-13T06:19:53Z

depends on #16845 and #20108

JonLiu1993 · 2021-09-14T02:28:56Z

/azp run

azure-pipelines · 2021-09-14T02:29:06Z

Azure Pipelines successfully started running 1 pipeline(s).

JonLiu1993 · 2021-09-14T06:07:44Z

@dg0yt @c72578 ,Pr #16845 and #20108 have merged. I tried rerun the CI but also failed, this pr need other repairs?

dg0yt · 2021-09-14T06:51:49Z

@JonLiu1993 I promised to fix the libarchive pc file in a separate PR. I just finished it: #20146

JonLiu1993 · 2021-09-14T06:57:27Z

@JonLiu1993 I promised to fix the libarchive pc file in a separate PR. I just finished it: #20146

Thanks again for your efforts

c72578 · 2021-09-14T07:42:56Z

Depends on: #20146

c72578 · 2021-09-19T07:44:16Z

@JonLiu1993, @dg0yt The PR #20146 has been tested and is OK. However, there is a remaining issue concerning port lz4 and debug\lib\pkgconfig\liblz4.pc.
For details see: #20146 (comment)

c72578 · 2021-09-19T12:46:32Z

@JonLiu1993 libgxps:x64-linux builds fine now, with the updated PR [libarchive,lz4] Fix pc file, modernize portfile #20146
@dg0yt Thanks for fixing the pkg-config files of libarchive and lz4.

JonLiu1993 · 2021-09-22T07:52:50Z

@JonLiu1993 libgxps:x64-linux builds fine now, with the updated PR [libarchive,lz4] Fix pc file, modernize portfile #20146
@dg0yt Thanks for fixing the pkg-config files of libarchive and lz4.

@c72578 ,Thank for your report, wait for lz4 to be repaired, I will review this pr

Add libgxps version 0.3.2

c72578 · 2021-09-25T19:04:00Z

@JonLiu1993 The PR #20146, which fixed the pkg-config files of libarchive and lz4 has been merged in the meantime.
CI has passed now.

JonLiu1993 · 2021-09-26T02:22:12Z

@c72578 @dg0yt ,Thanks for your hard working!

BillyONeal · 2021-09-28T00:22:41Z

Thanks!

github-actions bot approved these changes Sep 8, 2021

View reviewed changes

c72578 marked this pull request as ready for review September 8, 2021 20:40

JonLiu1993 self-assigned this Sep 9, 2021

JonLiu1993 added category:new-port The issue is requesting a new library to be added; consider making a PR! requires:author-response labels Sep 9, 2021

dg0yt mentioned this pull request Sep 10, 2021

[libarchive] update to 3.5.2 #16845

Merged

JonLiu1993 added depends:upstream-changes Waiting on a change to the upstream project and removed requires:author-response labels Sep 10, 2021

c72578 force-pushed the 2021-08-02_libgxps_Add_new_port branch from 442cba6 to a1d7135 Compare September 11, 2021 06:32

github-actions bot approved these changes Sep 11, 2021

View reviewed changes

JonLiu1993 added depends:different-pr This PR or Issue depends on a PR which has been filed and removed depends:upstream-changes Waiting on a change to the upstream project labels Sep 13, 2021

JonLiu1993 removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Sep 14, 2021

JonLiu1993 added the requires:author-response label Sep 14, 2021

dg0yt mentioned this pull request Sep 14, 2021

[libarchive,lz4] Fix pc file, modernize portfile #20146

Merged

4 tasks

JonLiu1993 added depends:different-pr This PR or Issue depends on a PR which has been filed and removed requires:author-response labels Sep 14, 2021

dg0yt mentioned this pull request Sep 16, 2021

[scripts-audit] vcpkg_fixup_pkgconfig #19658

Merged

[libgxps] Add new port

37c80b6

Add libgxps version 0.3.2

c72578 force-pushed the 2021-08-02_libgxps_Add_new_port branch from a1d7135 to 37c80b6 Compare September 25, 2021 05:59

github-actions bot approved these changes Sep 25, 2021

View reviewed changes

JonLiu1993 removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Sep 26, 2021

JonLiu1993 approved these changes Sep 26, 2021

View reviewed changes

JonLiu1993 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Sep 26, 2021

BillyONeal merged commit d49854f into microsoft:master Sep 28, 2021

Conversation

c72578 commented Sep 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does your PR fix?

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Uh oh!

c72578 commented Sep 8, 2021

Uh oh!

dg0yt commented Sep 9, 2021

Uh oh!

c72578 commented Sep 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

c72578 commented Sep 9, 2021

Uh oh!

dg0yt commented Sep 9, 2021

Uh oh!

c72578 commented Sep 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonLiu1993 commented Sep 10, 2021

Uh oh!

dg0yt commented Sep 10, 2021

Uh oh!

dg0yt commented Sep 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

c72578 commented Sep 11, 2021

Uh oh!

JonLiu1993 commented Sep 13, 2021

Uh oh!

JonLiu1993 commented Sep 13, 2021

Uh oh!

JonLiu1993 commented Sep 14, 2021

Uh oh!

azure-pipelines bot commented Sep 14, 2021

Uh oh!

JonLiu1993 commented Sep 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dg0yt commented Sep 14, 2021

Uh oh!

JonLiu1993 commented Sep 14, 2021

Uh oh!

c72578 commented Sep 14, 2021

Uh oh!

c72578 commented Sep 19, 2021

Uh oh!

c72578 commented Sep 19, 2021

Uh oh!

JonLiu1993 commented Sep 22, 2021

Uh oh!

c72578 commented Sep 25, 2021

Uh oh!

JonLiu1993 commented Sep 26, 2021

Uh oh!

BillyONeal commented Sep 28, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

c72578 commented Sep 8, 2021 •

edited

Loading

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?

c72578 commented Sep 9, 2021 •

edited

Loading

c72578 commented Sep 10, 2021 •

edited

Loading

dg0yt commented Sep 11, 2021 •

edited

Loading

JonLiu1993 commented Sep 14, 2021 •

edited

Loading