[openmvg] Fix for building with eigen 3.4.0. by aluaces · Pull Request #20056 · microsoft/vcpkg

aluaces · 2021-09-08T16:28:41Z

This solves the building error when upgrading eigen in #19665

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for openmvg but no changes to version or port version.
-- Version: 1.6#2
-- Old SHA: f62103b28735c9e72b9a866e6530c52629e77295
-- New SHA: 1ea71fe13af7500b8593c5bcff43cd74d1d8ce0c
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout bcf551b980380fe7f84fa302ad7ef3c184f9bf4f -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 31586ba..497bd89 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -4734,7 +4734,7 @@
     },
     "openmvg": {
       "baseline": "1.6",
-      "port-version": 2
+      "port-version": 3
     },
     "openmvs": {
       "baseline": "1.1",
diff --git a/versions/o-/openmvg.json b/versions/o-/openmvg.json
index bced436..d450c86 100644
--- a/versions/o-/openmvg.json
+++ b/versions/o-/openmvg.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "219414d49228ae50fcd76d08d153f326a119849e",
+      "version-string": "1.6",
+      "port-version": 3
+    },
     {
       "git-tree": "f62103b28735c9e72b9a866e6530c52629e77295",
       "version-string": "1.6",

ports/openmvg/0001-eigen_3.4.0.patch

ports/openmvg/portfile.cmake

ports/openmvg/vcpkg.json

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout bcf551b980380fe7f84fa302ad7ef3c184f9bf4f -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index e2da5b2..aac28e4 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -4734,7 +4734,7 @@
     },
     "openmvg": {
       "baseline": "1.6",
-      "port-version": 2
+      "port-version": 3
     },
     "openmvs": {
       "baseline": "1.1",
diff --git a/versions/o-/openmvg.json b/versions/o-/openmvg.json
index bced436..67945f7 100644
--- a/versions/o-/openmvg.json
+++ b/versions/o-/openmvg.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "f171436873c79834dd6616216da68a61af4dbebe",
+      "version": "1.6",
+      "port-version": 3
+    },
     {
       "git-tree": "f62103b28735c9e72b9a866e6530c52629e77295",
       "version-string": "1.6",

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout bcf551b980380fe7f84fa302ad7ef3c184f9bf4f -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index e2da5b2..aac28e4 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -4734,7 +4734,7 @@
     },
     "openmvg": {
       "baseline": "1.6",
-      "port-version": 2
+      "port-version": 3
     },
     "openmvs": {
       "baseline": "1.1",
diff --git a/versions/o-/openmvg.json b/versions/o-/openmvg.json
index bced436..1731c06 100644
--- a/versions/o-/openmvg.json
+++ b/versions/o-/openmvg.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "6f3087d8d002d7f226e77427ce363e2b20371485",
+      "version": "1.6",
+      "port-version": 3
+    },
     {
       "git-tree": "f62103b28735c9e72b9a866e6530c52629e77295",
       "version-string": "1.6",

NancyLi1013 · 2021-09-13T05:53:08Z

Could you please run vcpkg x-add-version openmvg to update version files? @aluaces

Also have you tested these features in this PR?

aluaces · 2021-09-13T11:04:31Z

Could you please run vcpkg x-add-version openmvg to update version files? @aluaces

Done

Also have you tested these features in this PR?

I'm not an user of the library, but the changes have been reviewed and approved by upstream, so I'm confident that they are right, being almost trivial.

NancyLi1013 · 2021-09-14T06:06:33Z

Also have you tested these features in this PR?

I'm not an user of the library, but the changes have been reviewed and approved by upstream, so I'm confident that they are right, being almost trivial.

Thanks for your information. I mean if you have tested these features opencv ,software with openmvg. Namely build openmvg[opencv,software] on x86-windows, x64-windows-static and x64-linux.

Since our CI test machine will only test the default features. Other features need to be tested manually.

aluaces · 2021-09-14T10:15:30Z

Thanks for your information. I mean if you have tested these features opencv ,software with openmvg. Namely build openmvg[opencv,software] on x86-windows, x64-windows-static and x64-linux.

Since our CI test machine will only test the default features. Other features need to be tested manually.

Oh, now I understand, thanks

x86-windows is working.
x64-windows-static fails with OpenMVG software currently cannot be built with static CRT linking. Please open an issue if you require this feature.
x64-linux fails when building fontconfig:
/usr/bin/ld: cannot find -lfreetyped
/usr/bin/ld: cannot find -lbz2d
/usr/bin/ld: cannot find -lpng16d

Edit: sorry, I meant fontconfig, not freetype.

NancyLi1013 · 2021-09-16T06:23:11Z

Thanks for your feedback.

For the status on x64-windows-static, it is expected. So we can leave it alone.

For the status on x64-linux, I will check the current status on master branch to confirm if it is the new problem caused by this PR.

aluaces · 2021-09-17T08:16:56Z

Well, I did a fresh build of fontconfig and it's working fine. Unsurprisingly, since eigen shouldn't be one of its dependencies.

NancyLi1013 · 2021-09-17T10:48:20Z

Well, I did a fresh build of fontconfig and it's working fine. Unsurprisingly, since eigen shouldn't be one of its dependencies.

So there is no any problems for the features on Linux, right?

aluaces · 2021-09-21T08:23:24Z

Well, I cannot be completely sure, since it is stopping now at qt5-base, but I get the same error in master, so I think it has nothing to do with this patch.

NancyLi1013 · 2021-09-23T02:10:53Z

LGTM now, thanks for your fixing. @aluaces

BillyONeal · 2021-09-24T00:38:00Z

Thanks for the fix!

[openmvg] Fix for building with eigen 3.4.0.

2a1f9a7

aluaces mentioned this pull request Sep 8, 2021

[eigen3] Update to 3.4.0 #19665

Merged

github-actions bot requested changes Sep 8, 2021

View reviewed changes

Bump port version.

f386f2d

github-actions bot requested changes Sep 8, 2021

View reviewed changes

JonLiu1993 assigned NancyLi1013 Sep 9, 2021

NancyLi1013 suggested changes Sep 9, 2021

View reviewed changes

ports/openmvg/0001-eigen_3.4.0.patch Show resolved Hide resolved

ports/openmvg/portfile.cmake Show resolved Hide resolved

ports/openmvg/vcpkg.json Outdated Show resolved Hide resolved

NancyLi1013 added category:port-bug The issue is with a library, which is something the port should already support requires:author-response labels Sep 9, 2021

Convert "version-string" field into "version"

539f456

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>

github-actions bot requested changes Sep 9, 2021

View reviewed changes

Update vcpkg_check_features call

33a7d6f

github-actions bot requested changes Sep 9, 2021

View reviewed changes

[openmvg] x-add-version

9d0cc21

github-actions bot approved these changes Sep 13, 2021

View reviewed changes

NancyLi1013 approved these changes Sep 14, 2021

View reviewed changes

NancyLi1013 added requires:all-feature-testing and removed requires:author-response labels Sep 14, 2021

NancyLi1013 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:all-feature-testing labels Sep 23, 2021

BillyONeal merged commit 5b61ee0 into microsoft:master Sep 24, 2021

ThGravo mentioned this pull request Nov 13, 2021

[openmvg] update to 2.0 #21364

Closed

Conversation

aluaces commented Sep 8, 2021

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

NancyLi1013 commented Sep 13, 2021

Uh oh!

aluaces commented Sep 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NancyLi1013 commented Sep 14, 2021

Uh oh!

aluaces commented Sep 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NancyLi1013 commented Sep 16, 2021

Uh oh!

aluaces commented Sep 17, 2021

Uh oh!

NancyLi1013 commented Sep 17, 2021

Uh oh!

aluaces commented Sep 21, 2021

Uh oh!

NancyLi1013 commented Sep 23, 2021

Uh oh!

BillyONeal commented Sep 24, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

aluaces commented Sep 13, 2021 •

edited

Loading

aluaces commented Sep 14, 2021 •

edited

Loading