[vcpkg_fixup_pkgconfig] Add support for Cflags.private#19852
Merged
strega-nil-ms merged 1 commit intomicrosoft:masterfrom Sep 23, 2021
Merged
[vcpkg_fixup_pkgconfig] Add support for Cflags.private#19852strega-nil-ms merged 1 commit intomicrosoft:masterfrom
strega-nil-ms merged 1 commit intomicrosoft:masterfrom
Conversation
Contributor
|
cc @Neumann-A for review this PR. |
Contributor
|
Any port which hits this ? |
Contributor
Author
|
89cadc4 to
f8d6fdc
Compare
JackBoosY
approved these changes
Sep 7, 2021
Contributor
|
This should be merged after #19658 |
Contributor
libarchive: |
Contributor
|
@dg0yt additional this needs to be hardcoded in the main include file of libarchive because otherwise the vs integration does not work. |
Contributor
Author
@strega-nil-ms Wouldn't it be possible, please, to get this merged first and for you to pull that trivial change into your branch? It is a blocker for another port I have pending, which, in turn, is a blocker for several others. |
Contributor
|
@wrobelda hmm, okay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Adds support merging
CFlags.privateintoCFlagsfor static builds.Which triplets are supported/not supported? Have you updated the CI baseline?
All
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?N/A