[kf5declarative] new port#19813
Merged
vicroms merged 34 commits intomicrosoft:masterfrom Oct 22, 2021
Merged
Conversation
c704bcf to
4cae7ae
Compare
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for kf5declarative but no changes to version or port version.
-- Version: 5.84.0
-- Old SHA: bce20c3b942e4f4403efcb239c0058955ac0c5dd
-- New SHA: c62865e53d9c10a985be2bb016df04aa9ba06968
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout a761a22de8a5b82503837e58630f9aec38f05d52 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index cc146fd..166ad96 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2964,6 +2964,10 @@
"baseline": "5.84.0",
"port-version": 0
},
+ "kf5notifications": {
+ "baseline": "5.75.0",
+ "port-version": 0
+ },
"kf5package": {
"baseline": "5.84.0",
"port-version": 0841f509 to
3469eff
Compare
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for kf5declarative but no changes to version or port version.
-- Version: 5.84.0
-- Old SHA: bce20c3b942e4f4403efcb239c0058955ac0c5dd
-- New SHA: c62865e53d9c10a985be2bb016df04aa9ba06968
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
3469eff to
be976f9
Compare
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for kf5declarative but no changes to version or port version.
-- Version: 5.84.0
-- Old SHA: bce20c3b942e4f4403efcb239c0058955ac0c5dd
-- New SHA: c62865e53d9c10a985be2bb016df04aa9ba06968
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 9fb1585e7a375cfa873697557ced116dfacbd1d7 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index f7101cf..35a6f0f 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2924,11 +2924,11 @@
"baseline": "5.84.0",
"port-version": 1
},
- "kf5globalaccel": {
+ "kf5declarative": {
"baseline": "5.84.0",
"port-version": 0
},
- "kf5declarative": {
+ "kf5globalaccel": {
"baseline": "5.84.0",
"port-version": 0
},
@@ -2960,7 +2960,7 @@
"baseline": "5.84.0",
"port-version": 0
},
- "kf5package": {
+ "kf5kio": {
"baseline": "5.84.0",
"port-version": 0
},
@@ -2968,7 +2968,7 @@
"baseline": "5.84.0",
"port-version": 0
},
- "kf5kio": {
+ "kf5package": {
"baseline": "5.84.0",
"port-version": 0
},There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 9fb1585e7a375cfa873697557ced116dfacbd1d7 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index f7101cf..35a6f0f 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2924,11 +2924,11 @@
"baseline": "5.84.0",
"port-version": 1
},
- "kf5globalaccel": {
+ "kf5declarative": {
"baseline": "5.84.0",
"port-version": 0
},
- "kf5declarative": {
+ "kf5globalaccel": {
"baseline": "5.84.0",
"port-version": 0
},
@@ -2960,7 +2960,7 @@
"baseline": "5.84.0",
"port-version": 0
},
- "kf5package": {
+ "kf5kio": {
"baseline": "5.84.0",
"port-version": 0
},
@@ -2968,7 +2968,7 @@
"baseline": "5.84.0",
"port-version": 0
},
- "kf5kio": {
+ "kf5package": {
"baseline": "5.84.0",
"port-version": 0
},There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 9fb1585e7a375cfa873697557ced116dfacbd1d7 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index f7101cf..35a6f0f 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2924,11 +2924,11 @@
"baseline": "5.84.0",
"port-version": 1
},
- "kf5globalaccel": {
+ "kf5declarative": {
"baseline": "5.84.0",
"port-version": 0
},
- "kf5declarative": {
+ "kf5globalaccel": {
"baseline": "5.84.0",
"port-version": 0
},
@@ -2960,7 +2960,7 @@
"baseline": "5.84.0",
"port-version": 0
},
- "kf5package": {
+ "kf5kio": {
"baseline": "5.84.0",
"port-version": 0
},
@@ -2968,7 +2968,7 @@
"baseline": "5.84.0",
"port-version": 0
},
- "kf5kio": {
+ "kf5package": {
"baseline": "5.84.0",
"port-version": 0
},There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 9fb1585e7a375cfa873697557ced116dfacbd1d7 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index f7101cf..35a6f0f 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2924,11 +2924,11 @@
"baseline": "5.84.0",
"port-version": 1
},
- "kf5globalaccel": {
+ "kf5declarative": {
"baseline": "5.84.0",
"port-version": 0
},
- "kf5declarative": {
+ "kf5globalaccel": {
"baseline": "5.84.0",
"port-version": 0
},
@@ -2960,7 +2960,7 @@
"baseline": "5.84.0",
"port-version": 0
},
- "kf5package": {
+ "kf5kio": {
"baseline": "5.84.0",
"port-version": 0
},
@@ -2968,7 +2968,7 @@
"baseline": "5.84.0",
"port-version": 0
},
- "kf5kio": {
+ "kf5package": {
"baseline": "5.84.0",
"port-version": 0
},b31a998 to
4df84b0
Compare
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 9fb1585e7a375cfa873697557ced116dfacbd1d7 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index 10f578b..35a6f0f 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2924,11 +2924,11 @@
"baseline": "5.84.0",
"port-version": 1
},
- "kf5globalaccel": {
+ "kf5declarative": {
"baseline": "5.84.0",
"port-version": 0
},
- "kf5declarative": {
+ "kf5globalaccel": {
"baseline": "5.84.0",
"port-version": 0
},
@@ -2960,15 +2960,15 @@
"baseline": "5.84.0",
"port-version": 0
},
- "kf5package": {
+ "kf5kio": {
"baseline": "5.84.0",
"port-version": 0
},
- "kf5kio": {
+ "kf5notifications": {
"baseline": "5.84.0",
"port-version": 0
},
- "kf5notifications": {
+ "kf5package": {
"baseline": "5.84.0",
"port-version": 0
},4df84b0 to
d116cb2
Compare
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 5bc27e8a5073ba139e29432a1b0d8ced50794a41 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index fd3a461..3eb38c8 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2932,7 +2932,6 @@
"baseline": "5.84.0",
"port-version": 0
},
-
"kf5guiaddons": {
"baseline": "5.84.0",
"port-version": 2There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 5bc27e8a5073ba139e29432a1b0d8ced50794a41 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index e1a3e04..feb5be0 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2932,7 +2932,6 @@
"baseline": "5.84.0",
"port-version": 0
},
-
"kf5guiaddons": {
"baseline": "5.84.0",
"port-version": 2
@@ -2972,7 +2971,7 @@
"kf5package": {
"baseline": "5.84.0",
"port-version": 0
- },
+ },
"kf5plotting": {
"baseline": "5.84.0",
"port-version": 19b87255 to
8a094fe
Compare
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 5d734efcef674dbf9b7b204484fc8f006101dcb5 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index 783aad3..39de514 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2992,7 +2992,6 @@
"baseline": "5.84.0",
"port-version": 0
},
- },
"kf5globalaccel": {
"baseline": "5.84.0",
"port-version": 0
@@ -3025,11 +3024,11 @@
"baseline": "5.84.0",
"port-version": 0
},
- "kf5notifications": {
+ "kf5kio": {
"baseline": "5.84.0",
"port-version": 0
},
- "kf5kio": {
+ "kf5notifications": {
"baseline": "5.84.0",
"port-version": 0
},8a094fe to
ad61150
Compare
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 5d734efcef674dbf9b7b204484fc8f006101dcb5 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index f30b096..39de514 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3024,11 +3024,11 @@
"baseline": "5.84.0",
"port-version": 0
},
- "kf5notifications": {
+ "kf5kio": {
"baseline": "5.84.0",
"port-version": 0
},
- "kf5kio": {
+ "kf5notifications": {
"baseline": "5.84.0",
"port-version": 0
},
This was referenced Sep 16, 2021
ad61150 to
dfc1187
Compare
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for kf5declarative but no changes to version or port version.
-- Version: 5.84.0
-- Old SHA: c62865e53d9c10a985be2bb016df04aa9ba06968
-- New SHA: dc898926b69ad5ef32655c80d3cc2acdf47d166f
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
Details
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}The following files are affected:
ports/ecm/portfile.cmakeports/kf5bookmarks/portfile.cmakeports/kf5declarative/portfile.cmakeports/kf5kio/portfile.cmakeports/kf5notifications/portfile.cmakeports/kf5xmlgui/portfile.cmakeports/libcanberra/portfile.cmake
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
32fd57e to
ea0a554
Compare
Contributor
Author
|
@NancyLi1013 no longer has dependencies, ready to be merged. |
NancyLi1013
reviewed
Oct 21, 2021
NancyLi1013
approved these changes
Oct 22, 2021
Contributor
|
LGTM now, thanks for adding this new port. @wrobelda |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Adds new port. Depends on:
[kf5kio] new port #19779
[kf5package] new port #19195
[kf5notifications] new port #19828
[libcanberra] Linux static .pc fix & other improvements #20782
Which triplets are supported/not supported? Have you updated the CI baseline?
All official, plus
arm64-osxDoes your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes