Skip to content

[qt] Add patches to fix missing includes#19668

Merged
BillyONeal merged 4 commits intomicrosoft:masterfrom
nicolasfella:limits
Sep 16, 2021
Merged

[qt] Add patches to fix missing includes#19668
BillyONeal merged 4 commits intomicrosoft:masterfrom
nicolasfella:limits

Conversation

@nicolasfella
Copy link
Copy Markdown
Contributor

This is needed to build with GCC11

Fixes #19226

@ghost
Copy link
Copy Markdown

ghost commented Aug 20, 2021

CLA assistant check
All CLA requirements met.

This is needed to build with GCC11

Fixes microsoft#19226
@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Aug 23, 2021
@JackBoosY
Copy link
Copy Markdown
Contributor

cc @Neumann-A for review this PR.

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for qt5-declarative but no changes to version or port version.
-- Version: 5.15.2
-- Old SHA: b07a27c5aa8905b158c0f72f2b9e7977391191c1
-- New SHA: 73651d72566e84681a7e07becc7a87b89aea53e1
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout ab60f27567ec24ab97289fb7a1d8455c74bcad04 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/q-/qt5-base.json b/versions/q-/qt5-base.json
index 88f911c..0552cee 100644
--- a/versions/q-/qt5-base.json
+++ b/versions/q-/qt5-base.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "2824837f3a0c083c90bf8fe0e564df3cefcb110f",
+      "git-tree": "54437f7d15be929ce63891f04a86f4cebed97bb2",
       "version-semver": "5.15.2",
       "port-version": 10
     },

@JackBoosY
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@Be-ing
Copy link
Copy Markdown
Contributor

Be-ing commented Sep 16, 2021

Ready for merge?

@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Sep 16, 2021
@BillyONeal BillyONeal merged commit e14842c into microsoft:master Sep 16, 2021
@BillyONeal
Copy link
Copy Markdown
Member

Thanks for fixing GCC 11 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[qt5-base] build failure: qt5-base[core]:x64-linux -> 5.15.2

5 participants