Skip to content

[kddockwidgets] Add port#19548

Closed
ThijsWithaar wants to merge 3 commits intomicrosoft:masterfrom
ThijsWithaar:kddockwidget
Closed

[kddockwidgets] Add port#19548
ThijsWithaar wants to merge 3 commits intomicrosoft:masterfrom
ThijsWithaar:kddockwidget

Conversation

@ThijsWithaar
Copy link
Copy Markdown
Contributor

@ThijsWithaar ThijsWithaar commented Aug 13, 2021

Describe the pull request

  • What does your PR fix?

    Adds a new port for KDDockWidgets

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    Waiting for CI results. Since it's generic Qt code, expect it to be all.

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes.

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

github-actions[bot]
github-actions bot requested changes Aug 13, 2021
View reviewed changes
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for kddockwidgets but no changes to version or port version.
-- Version: 1.4.0
-- Old SHA: 700399ec96198705f082f6e3a4e8f6a15216adb0
-- New SHA: 3fe41ab12f97c1fa35802d078362fedac8d547a2
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

github-actions[bot]
github-actions bot requested changes Aug 13, 2021
View reviewed changes
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for kddockwidgets but no changes to version or port version.
-- Version: 1.4.0
-- Old SHA: 700399ec96198705f082f6e3a4e8f6a15216adb0
-- New SHA: 6eeaf6af61420805bf96a0f9504d4f0388badae6
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

github-actions[bot]
github-actions bot requested changes Aug 13, 2021
View reviewed changes
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for kddockwidgets but no changes to version or port version.
-- Version: 1.4.0
-- Old SHA: 6eeaf6af61420805bf96a0f9504d4f0388badae6
-- New SHA: 5891bf0bf87c91e287ee4b147e34b77790b0ca83
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

github-actions[bot]
github-actions bot requested changes Aug 13, 2021
View reviewed changes
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for kddockwidgets but no changes to version or port version.
-- Version: 1.4.0
-- Old SHA: 5891bf0bf87c91e287ee4b147e34b77790b0ca83
-- New SHA: e8aa235501adf2ab1d496ee7e54d68e1c8f86ae1
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

github-actions[bot]
github-actions bot requested changes Aug 13, 2021
View reviewed changes
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for kddockwidgets but no changes to version or port version.
-- Version: 1.4.0
-- Old SHA: e8aa235501adf2ab1d496ee7e54d68e1c8f86ae1
-- New SHA: c7a14c183fb3a3f2a761eeb9f504576c9cc5c90a
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

@ThijsWithaar ThijsWithaar force-pushed the kddockwidget branch 2 times, most recently from a354782 to 2f0c072 Compare August 13, 2021 18:17
github-actions[bot]
github-actions bot requested changes Aug 13, 2021
View reviewed changes
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for kddockwidgets but no changes to version or port version.
-- Version: 1.4.0
-- Old SHA: c7a14c183fb3a3f2a761eeb9f504576c9cc5c90a
-- New SHA: 1cd7baa41549d5bcbf5caa70e2352bbd3a2c03be
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Aug 16, 2021
@JonLiu1993
Copy link
Copy Markdown
Contributor

JonLiu1993 commented Aug 16, 2021

@ThijsWithaar ,If pr is ready for review please let me know

@ThijsWithaar ThijsWithaar marked this pull request as ready for review August 16, 2021 11:04
JonLiu1993
JonLiu1993 reviewed Aug 17, 2021
View reviewed changes
@strega-nil-ms
Copy link
Copy Markdown
Contributor

strega-nil-ms commented Aug 20, 2021

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Aug 20, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@JonLiu1993
Copy link
Copy Markdown
Contributor

JonLiu1993 commented Aug 23, 2021

@ThijsWithaar ,Could you please take a look?
https://dev.azure.com/vcpkg/public/_build/results?buildId=58065&view=artifacts&pathAsName=false&type=publishedArtifacts

@JonLiu1993
Copy link
Copy Markdown
Contributor

JonLiu1993 commented Sep 10, 2021

@ThijsWithaar ,Could you please take a look?

CMake Error at /agent/_work/1/s/scripts/buildsystems/vcpkg.cmake:574 (_add_library):
  Target "kddockwidgets" links to target "Qt5::X11Extras" but the target was
  not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?
Call Stack (most recent call first):
  src/CMakeLists.txt:239 (add_library)

@JonLiu1993
Copy link
Copy Markdown
Contributor

JonLiu1993 commented Sep 28, 2021

@ThijsWithaar ,Is this PR being worked on?

@ThijsWithaar
Copy link
Copy Markdown
Contributor Author

ThijsWithaar commented Sep 28, 2021

@ThijsWithaar ,Is this PR being worked on?

Effectively not, no. I thought this would be an easy one, but somehow I can't get the build-servers to pass the build. I'm sure that's me just not understanding things, but I am just stuck.

@JonLiu1993
Copy link
Copy Markdown
Contributor

JonLiu1993 commented Oct 8, 2021

@ThijsWithaar ,Maybe the error related to Qt5:

CMake Warning at /agent/_work/1/s/scripts/buildsystems/vcpkg.cmake:786 (_find_package):
  By not providing "FindQt5X11Extras.cmake" in CMAKE_MODULE_PATH this project
  has asked CMake to find a package configuration file provided by
  "Qt5X11Extras", but CMake did not find one.

  Could not find a package configuration file provided by "Qt5X11Extras" with
  any of the following names:

    Qt5X11ExtrasConfig.cmake
    qt5x11extras-config.cmake

  Add the installation prefix of "Qt5X11Extras" to CMAKE_PREFIX_PATH or set
  "Qt5X11Extras_DIR" to a directory containing one of the above files.  If
  "Qt5X11Extras" provides a separate development package or SDK, be sure it
  has been installed.
Call Stack (most recent call first):
  src/CMakeLists.txt:294 (find_package)


CMake Error at /agent/_work/1/s/scripts/buildsystems/vcpkg.cmake:576 (_add_library):
  Target "kddockwidgets" links to target "Qt5::X11Extras" but the target was
  not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?
Call Stack (most recent call first):
  src/CMakeLists.txt:239 (add_library)


CMake Warning:
  Manually-specified variables were not used by the project:

    VCPKG_PLATFORM_TOOLSET
    VCPKG_SET_CHARSET_FLAG
    _VCPKG_ROOT_DIR


CMake Generate step failed.  Build files cannot be regenerated correctly.

@JonLiu1993
Copy link
Copy Markdown
Contributor

JonLiu1993 commented Oct 26, 2021

@ThijsWithaar ,Is there any progress on this pr?

@JonLiu1993
Copy link
Copy Markdown
Contributor

JonLiu1993 commented Nov 12, 2021

@ThijsWithaar, any progress?

@dg0yt dg0yt mentioned this pull request Dec 11, 2021
Merged
@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Dec 13, 2021

I'm closing this PR due to:

Sorry things took so long and hope any further experience you have with vcpkg is better :)

@BillyONeal BillyONeal closed this Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

+1 more reviewer

@JonLiu1993 JonLiu1993 JonLiu1993 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@JonLiu1993 JonLiu1993

Labels

category:new-port The issue is requesting a new library to be added; consider making a PR!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ThijsWithaar @JonLiu1993 @strega-nil-ms @BillyONeal