[onnx-optimizer] create a new port#19258
Merged
BillyONeal merged 4 commits intomicrosoft:masterfrom Sep 16, 2021
luncliff:port/onnx-optimizer
Merged
[onnx-optimizer] create a new port#19258BillyONeal merged 4 commits intomicrosoft:masterfrom luncliff:port/onnx-optimizer
BillyONeal merged 4 commits intomicrosoft:masterfrom
luncliff:port/onnx-optimizer
Conversation
Contributor
Author
|
I will rebase this when #18073 is merged |
19 tasks
JackBoosY
suggested changes
Aug 2, 2021
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for onnx but no changes to version or port version.
-- Version: 1.9.0
-- Old SHA: 5a0d95a1cf6502998635c8bdb58b1a5fbd416328
-- New SHA: bcfebbd5bb6d0072f56fb5166503522864636265
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for onnx but no changes to version or port version.
-- Version: 1.9.0
-- Old SHA: 5a0d95a1cf6502998635c8bdb58b1a5fbd416328
-- New SHA: bcfebbd5bb6d0072f56fb5166503522864636265
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
Error: Local changes detected for onnx-optimizer but no changes to version or port version.
-- Version: 0.2.6
-- Old SHA: 0bf85a2b4276beb2a541549955510e4dfdb85dc2
-- New SHA: 644473963518056d45a410b9658565affdcc8ecb
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for onnx but no changes to version or port version.
-- Version: 1.9.0
-- Old SHA: b53c9c9e969928def925c57ea5ddcdfb09293693
-- New SHA: 43475433efc6966a156018fcc698cb74357f1613
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 21935b744dc411e0fb1926618fdfb18c67d4b188 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index 2028c11..fc92276 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -4584,6 +4584,10 @@
"baseline": "1.9.0",
"port-version": 0
},
+ "onnx-optimizer": {
+ "baseline": "0.2.6",
+ "port-version": 0
+ },
"onnxruntime-gpu": {
"baseline": "1.5.1",
"port-version": 0There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for onnx but no changes to version or port version.
-- Version: 1.9.0
-- Old SHA: b53c9c9e969928def925c57ea5ddcdfb09293693
-- New SHA: 43475433efc6966a156018fcc698cb74357f1613
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 21935b744dc411e0fb1926618fdfb18c67d4b188 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index 2028c11..fc92276 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -4584,6 +4584,10 @@
"baseline": "1.9.0",
"port-version": 0
},
+ "onnx-optimizer": {
+ "baseline": "0.2.6",
+ "port-version": 0
+ },
"onnxruntime-gpu": {
"baseline": "1.5.1",
"port-version": 0There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for onnx but no changes to version or port version.
-- Version: 1.9.0
-- Old SHA: b53c9c9e969928def925c57ea5ddcdfb09293693
-- New SHA: 43475433efc6966a156018fcc698cb74357f1613
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 21935b744dc411e0fb1926618fdfb18c67d4b188 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/o-/onnx.json b/versions/o-/onnx.json
index 4efd7e2..5f4fc6e 100644
--- a/versions/o-/onnx.json
+++ b/versions/o-/onnx.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "43475433efc6966a156018fcc698cb74357f1613",
+ "git-tree": "b53c9c9e969928def925c57ea5ddcdfb09293693",
"version-semver": "1.9.0",
"port-version": 0
}
JackBoosY
suggested changes
Aug 30, 2021
* migrate changes to new branch
* ONNX_USE_PROTOBUF_SHARED_LIBS is for Windows
Contributor
Author
|
Tried |
JackBoosY
suggested changes
Sep 13, 2021
JackBoosY
approved these changes
Sep 16, 2021
Member
|
Thanks for the new port! |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does your PR fix?
Create a new port for https://github.com/onnx/optimizer
Which triplets are supported/not supported? Have you updated the CI baseline?
Same as
onnx#18073x64-windowsx86-windowsx64-osxx64-linuxDoes your PR follow the maintainer guide?
Checked!